Thanks to the Team for the relase.
AmigoJack wrote: ↑Sat May 01, 2021 10:39 pm
While I'm used to never being mentioned because only git pull requests are counted (the "contributed code" phrase is simply wrong as I can easily do that)
It is correct IMHO, who spends his/her time and effort giving the community his own contribution(s) using the ways offered by the developpers it is mentioned, I recall spending many hours/days trying to understand the workflow, I studied it and I have never give up, now I use the facilities the right way, I asked for help and I was helped out so I do not understand what's your problem. If you can easily do that, please go ahead.
AmigoJack wrote: ↑Sat May 01, 2021 10:39 pm
and grasping the problem and then precisely pointing at the culprit was my work
You pointed to the culprit giving an hint, solution was not even perfect nor exhaustive.
AmigoJack wrote: ↑Sat May 01, 2021 10:39 pm
I don't understand why only IMAGETYPE_WEBP was implemented and not MAGETYPE_JPEG2000 and IMAGETYPE_ICO, too, while being at it. "Nobody uses those" cannot be the answer, as formats like IMAGETYPE_XBM are supported for years already.
Because the ticket has been made just for WEBP. Feel free to create a ticket for those, it will be evaluated.
Not to mention that JPEG 2000 was built to supersede the original JPEG format by having better compression and more features.
WebP, AVIF and JPEG XL are all designed to supersede JPEG 2000.
https://caniuse.com/?search=jp2 - a format tha not even all browsers support.
AmigoJack wrote: ↑Sat May 01, 2021 10:39 pm
I also want to point out that the WEBP support could have been implemented 2+ years ago already.
Nope, first because
IMAGETYPE_WEBP
it is available as of PHP 7.1.0 (and phpBB 3.3.0 has been released on 06-jan-2020) -
https://github.com/phpbb/phpbb/releases ... ease-3.3.0 - then because nobody opened a ticket and/or pushed the code for that.