What was changed in phpBB3 to prevent Firefox double views?

Do not post support requests, bug reports or feature requests. Discuss phpBB here. Non-phpBB related discussion goes in General Discussion!
Anti-Spam Guide
Post Reply
User avatar
stevemagruder
Registered User
Posts: 210
Joined: Wed Jul 02, 2003 2:05 pm
Location: Louisville, KY
Contact:

What was changed in phpBB3 to prevent Firefox double views?

Post by stevemagruder »

In phpBB2, using Firefox 2.0.0.12 without add-ons, whenever I look at a topic, the number of views goes up by 2, but with phpBB3, it only goes up by 1, which is what is expected.

What was specifically changed in the code to fix this anomaly?
Steve Magruder - WebCommons :: Media
Administrator for the Louisville History & Issues discussion board

ToonArmy
Former Team Member
Posts: 4608
Joined: Sat Mar 06, 2004 5:29 pm
Location: Worcestershire, UK
Name: Chris Smith
Contact:

Re: What was changed in phpBB3 to prevent Firefox double views?

Post by ToonArmy »

Pretty much everything :P
Chris SmithGitHub

User avatar
Eelke
QA Team
Posts: 2903
Joined: Thu Dec 20, 2001 8:00 am
Location: NL, Bussum
Name: Eelke Blok
Contact:

Re: What was changed in phpBB3 to prevent Firefox double views?

Post by Eelke »

I don't see this behaviour on my own phpBB2. Do you have any mods installed?

User avatar
stevemagruder
Registered User
Posts: 210
Joined: Wed Jul 02, 2003 2:05 pm
Location: Louisville, KY
Contact:

Re: What was changed in phpBB3 to prevent Firefox double views?

Post by stevemagruder »

Eelke wrote:I don't see this behaviour on my own phpBB2. Do you have any mods installed?
My own implementation of phpBB is heavily modded, but I have tested this problem out on versions of phpBB that other sites are running. On boards that run phpBB2, views are double-incremented, on phpBB3, they aren't.
Steve Magruder - WebCommons :: Media
Administrator for the Louisville History & Issues discussion board

User avatar
Techie-Micheal
Security Consultant
Posts: 19511
Joined: Sun Oct 14, 2001 12:11 am
Location: In your servers

Re: What was changed in phpBB3 to prevent Firefox double views?

Post by Techie-Micheal »

What makes you think it was an issue to be fixed in the first place? ;)

What I mean by that is, phpBB2 did not suffer from this, and phpBB3 doesn't. Chances are, it is a problem with your installation. As asked, any MODs? Are phpBB2 and 3 on the same server? Do you have links to both for us to see?
Proven Offensive Security Expertise. OSCP - GXPN

User avatar
Eelke
QA Team
Posts: 2903
Joined: Thu Dec 20, 2001 8:00 am
Location: NL, Bussum
Name: Eelke Blok
Contact:

Re: What was changed in phpBB3 to prevent Firefox double views?

Post by Eelke »

stevemagruder wrote:On boards that run phpBB2
No. Like I said, mine doesn't. I'm not saying you're lying, I am saying it can't be as simple as you're suggesting.

User avatar
stevemagruder
Registered User
Posts: 210
Joined: Wed Jul 02, 2003 2:05 pm
Location: Louisville, KY
Contact:

Re: What was changed in phpBB3 to prevent Firefox double views?

Post by stevemagruder »

Techie-Micheal wrote:What makes you think it was an issue to be fixed in the first place? ;)

What I mean by that is, phpBB2 did not suffer from this, and phpBB3 doesn't. Chances are, it is a problem with your installation. As asked, any MODs? Are phpBB2 and 3 on the same server? Do you have links to both for us to see?
OK, using Firefox 2.0.0.12, go to http://forums.courier-journal.com/index.php (phpBB 2), view a topic and watch the view count go up by 2, then go to http://www.wineloverspage.com/forum/hotbytes/ (phpBB 3), view a topic, and watch the view count go up by 1.
Steve Magruder - WebCommons :: Media
Administrator for the Louisville History & Issues discussion board

User avatar
jaunty_mellifluous
Registered User
Posts: 438
Joined: Mon May 21, 2007 1:59 am
Name: Asad Kay
Contact:

Re: What was changed in phpBB3 to prevent Firefox double views?

Post by jaunty_mellifluous »

Does that mean you'll get a 2 click reward with every click on your site's ads? lol.. joke.
Stay Cool!

User avatar
Techie-Micheal
Security Consultant
Posts: 19511
Joined: Sun Oct 14, 2001 12:11 am
Location: In your servers

Re: What was changed in phpBB3 to prevent Firefox double views?

Post by Techie-Micheal »

http://micheal.webfactional.com/phpBB/phpBB2/

I setup a fresh 2.0.23. It does not exhibit the behavior you are seeing elsewhere (I did see it on the site running phpBB2 that you linked to). I think that it is not a phpBB problem, but rather other factors at work, such as MODs, database issues, or conversions, along with a slew of other possible issues.
Proven Offensive Security Expertise. OSCP - GXPN

User avatar
stevemagruder
Registered User
Posts: 210
Joined: Wed Jul 02, 2003 2:05 pm
Location: Louisville, KY
Contact:

Re: What was changed in phpBB3 to prevent Firefox double views?

Post by stevemagruder »

Techie-Micheal wrote:http://micheal.webfactional.com/phpBB/phpBB2/

I setup a fresh 2.0.23. It does not exhibit the behavior you are seeing elsewhere (I did see it on the site running phpBB2 that you linked to). I think that it is not a phpBB problem, but rather other factors at work, such as MODs, database issues, or conversions, along with a slew of other possible issues.
Thanks for checking! There must something in common between the Courier-Journal forum and my own phpBB2 installation that causes the double hits.

It's hard for me to believe it's a database issue as that's server-side and the difference I'm seeing is between client-side browsers. I've never seen the double hits with IE 6 or 7. Of course, maybe there's some aspect I'm missing there.

I've even checked my own phpBB2 code, and have verified there was only one spot where the topic view counter is incremented.

Another related anomaly is that whenever I've used Firefox to rearrange the ordering of forums in the ACP, phpBB2 receives double hits for that as well, and forums move up or down two spots instead of one. So, whenever I need to reorder forums, I jump to IE for that. Strange, huh?
Steve Magruder - WebCommons :: Media
Administrator for the Louisville History & Issues discussion board

User avatar
Techie-Micheal
Security Consultant
Posts: 19511
Joined: Sun Oct 14, 2001 12:11 am
Location: In your servers

Re: What was changed in phpBB3 to prevent Firefox double views?

Post by Techie-Micheal »

stevemagruder wrote:
Techie-Micheal wrote:http://micheal.webfactional.com/phpBB/phpBB2/

I setup a fresh 2.0.23. It does not exhibit the behavior you are seeing elsewhere (I did see it on the site running phpBB2 that you linked to). I think that it is not a phpBB problem, but rather other factors at work, such as MODs, database issues, or conversions, along with a slew of other possible issues.
Thanks for checking! There must something in common between the Courier-Journal forum and my own phpBB2 installation that causes the double hits.

It's hard for me to believe it's a database issue as that's server-side and the difference I'm seeing is between client-side browsers. I've never seen the double hits with IE 6 or 7. Of course, maybe there's some aspect I'm missing there.

I've even checked my own phpBB2 code, and have verified there was only one spot where the topic view counter is incremented.

Another related anomaly is that whenever I've used Firefox to rearrange the ordering of forums in the ACP, phpBB2 receives double hits for that as well, and forums move up or down two spots instead of one. So, whenever I need to reorder forums, I jump to IE for that. Strange, huh?
Well, the database issue can be something like improperly incrementing (I had the strangest issue with time going backwards on phpBB.com for a few years ...), corruption, improper conversion, etc.
Proven Offensive Security Expertise. OSCP - GXPN

User avatar
stevemagruder
Registered User
Posts: 210
Joined: Wed Jul 02, 2003 2:05 pm
Location: Louisville, KY
Contact:

Re: What was changed in phpBB3 to prevent Firefox double views?

Post by stevemagruder »

Techie-Micheal wrote:Well, the database issue can be something like improperly incrementing (I had the strangest issue with time going backwards on phpBB.com for a few years ...), corruption, improper conversion, etc.
Yes, I understand, but would there be a difference between browsers/clients with regards to database behavior?
Steve Magruder - WebCommons :: Media
Administrator for the Louisville History & Issues discussion board

User avatar
Techie-Micheal
Security Consultant
Posts: 19511
Joined: Sun Oct 14, 2001 12:11 am
Location: In your servers

Re: What was changed in phpBB3 to prevent Firefox double views?

Post by Techie-Micheal »

stevemagruder wrote:
Techie-Micheal wrote:Well, the database issue can be something like improperly incrementing (I had the strangest issue with time going backwards on phpBB.com for a few years ...), corruption, improper conversion, etc.
Yes, I understand, but would there be a difference between browsers/clients with regards to database behavior?
Not necessarily.
Proven Offensive Security Expertise. OSCP - GXPN

User avatar
stevemagruder
Registered User
Posts: 210
Joined: Wed Jul 02, 2003 2:05 pm
Location: Louisville, KY
Contact:

Re: What was changed in phpBB3 to prevent Firefox double views?

Post by stevemagruder »

I found the exact cause of my particular problem.

http://brian.pontarelli.com/2006/05/02/ ... mment-2100

When there's a "url()" specified in inline CSS, it triggers a second page load.

Some mod along the line added "background-image: url({T_BODY_BACKGROUND});" to my overall_header.tpl file. The T_BODY_BACKGROUND value was empty, thus the "url()".

Clearly a bug with Firefox rather than phpBB, but it's very easy to workaround.
Steve Magruder - WebCommons :: Media
Administrator for the Louisville History & Issues discussion board

User avatar
Techie-Micheal
Security Consultant
Posts: 19511
Joined: Sun Oct 14, 2001 12:11 am
Location: In your servers

Re: What was changed in phpBB3 to prevent Firefox double views?

Post by Techie-Micheal »

stevemagruder wrote:I found the exact cause of my particular problem.

http://brian.pontarelli.com/2006/05/02/ ... mment-2100

When there's a "url()" specified in inline CSS, it triggers a second page load.

Some mod along the line added "background-image: url({T_BODY_BACKGROUND});" to my overall_header.tpl file. The T_BODY_BACKGROUND value was empty, thus the "url()".

Clearly a bug with Firefox rather than phpBB, but it's very easy to workaround.
Thanks for the follow-up, very interesting.
Proven Offensive Security Expertise. OSCP - GXPN

Post Reply

Return to “phpBB Discussion”