[SPLIT] phpBB 3.3 style changes

Need some custom code changes to the phpBB core simple enough that you feel doesn't require an extension? Then post your request here so that community members can provide some assistance.

NOTE: NO OFFICIAL SUPPORT IS PROVIDED IN THIS SUB-FORUM
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

NOTE: NO OFFICIAL SUPPORT IS PROVIDED IN THIS SUB-FORUM
User avatar
Hero.73
Registered User
Posts: 62
Joined: Fri Feb 14, 2020 8:27 pm
Location: Germany

[SPLIT] phpBB 3.3 style changes

Post by Hero.73 »

hi friends I have a problem that bothers me I modified

Code: Select all

legend {
	padding: 1px 0;
	font-family: Tahoma,arial,Verdana,Sans-serif;
	font-size: .9em;
	font-weight: bold;
	color: #115098;
	margin-top: -.4em;
	position: relative;
	text-transform: none;
	line-height: 1.2em;
	top: -.2em;
	vertical-align: middle;
and modified like this

Code: Select all

legend {
	padding: 1px 0;
	font-family: Tahoma,arial,Verdana,Sans-serif;
	font-size: .9em;
	font-weight: bold;
	color: #115098;
	margin-top: -.4em;
	position: relative;
	text-transform: none;
	line-height: 1.2em;
	top: -.8em;
	vertical-align: middle;
look at the screens after the modification there remains a white background where I can delete it
the first screen and the original position
Attachments
Cattura (1).PNG
Cattura.PNG

User avatar
Tastenplayer
Registered User
Posts: 622
Joined: Thu Jul 03, 2014 9:20 pm
Location: Switzerland
Name: Jutta Koliofotis
Contact:

Re: phpBB 3.3 style changes

Post by Tastenplayer »

But this is an acp change and not a style change, right?. Why do you want to change something in acp?
Did you want to change something in the style? Then make a screen what you wanted to change in style. Write also in which style you want to change it.
More of my styles you can find in my phpBB Style Board & More
Be the best version of yourself rather than a bad copy of someone else!
Excuse me for my English, but I learned the language by speaking to people and not at school.

User avatar
Lumpy Burgertushie
Registered User
Posts: 67390
Joined: Mon May 02, 2005 3:11 am
Contact:

Re: phpBB 3.3 style changes

Post by Lumpy Burgertushie »

since the only change you made was the top: -.8em;
undo that change and see what happens.

not sure why you made that change to start with. what exactly did you want that change to accomplish?

robert
I'm baaaaaccckkkk. still doing work on donation basis. PM your needs.

Premium phpBB 3.3 Styles by PlanetStyles.net

If nobody is in the forest, does a tree really fall?

User avatar
warmweer
Jr. Extension Validator
Posts: 4273
Joined: Fri Jul 04, 2003 6:34 am
Location: Van Allen Bel ... gium

Re: phpBB 3.3 style changes

Post by warmweer »

It moves the Select user up, to above the white area but the the white area directly under Select user moves up a little bit.
Even if you move it up -3 em so that there is a lot of space, the white covers the bluegreyish border of form_id select user.

Actually: if you look very closely at the unmodified section, the grayish border under the Select user isn't present even.

On a sidenote: this has nothing to do with phpBB3.3 style changes (more of a custom styling issue).
We should embrace problems, without which there wouldn't be any solutions.

User avatar
Hero.73
Registered User
Posts: 62
Joined: Fri Feb 14, 2020 8:27 pm
Location: Germany

Re: [SPLIT] phpBB 3.3 style changes

Post by Hero.73 »

yes I know this bothers me that the writing ends up on the edge and I wanted to have a clearer view so if someone can indicate me beyond the change I made, how to improve that white space that goes up together with the writing

Code: Select all

fieldset {
	margin: 15px 0;
	padding: 10px;
	border-top: 0px solid #D7D7D7;
	border-right: 1px solid #CCCCCC;
	border-bottom: 1px solid #CCCCCC;
	border-left: 1px solid #D7D7D7;
	background-color: #FFFFFF;
	position: relative;
	border-radius: 3px;
}
I also changed this but I lose the edge
Attachments
Cattura.PNG

User avatar
Tastenplayer
Registered User
Posts: 622
Joined: Thu Jul 03, 2014 9:20 pm
Location: Switzerland
Name: Jutta Koliofotis
Contact:

Re: phpBB 3.3 style changes

Post by Tastenplayer »

warmweer wrote:
Wed Feb 26, 2020 8:23 pm
On a sidenote: this has nothing to do with phpBB3.3 style changes (more of a custom styling issue).
But that's in the acp and not a style - or do I definitely have one on my mind :) I don't understand, why something like that should be changed in the acp. Maybe if someone has trouble with their eyes.
The problem, in my opinion, could be that if you make an unspecified change in acp, it could also affect the styles. Because the fieldset, which this white background in acp is, also exists in the styles. The same applies to the legend.

Alternative solution (But I don't know if this has any effect anywhere else in the acp.):

Code: Select all

legend {
font-family: Tahoma,arial,Verdana,Sans-serif;
font-size: .9em;
font-weight: bold;
color: #115098;
margin-top: -.4em;
position: relative;
text-transform: none;
line-height: 1.2em;
top: -.2em;
vertical-align: middle;
background-color: white;
padding: 2px 5px;
margin-left: -10px;
}
acp_adapt..jpg
acp_adapt..jpg (9.11 KiB) Viewed 453 times
More of my styles you can find in my phpBB Style Board & More
Be the best version of yourself rather than a bad copy of someone else!
Excuse me for my English, but I learned the language by speaking to people and not at school.

User avatar
warmweer
Jr. Extension Validator
Posts: 4273
Joined: Fri Jul 04, 2003 6:34 am
Location: Van Allen Bel ... gium

Re: [SPLIT] phpBB 3.3 style changes

Post by warmweer »

Hero.73 wrote:
Fri Feb 28, 2020 3:25 pm
yes I know this bothers me that the writing ends up on the edge and I wanted to have a clearer view so if someone can indicate me beyond the change I made, how to improve that white space that goes up together with the writing
It doesn't go up with the writing (initially I also thought it did).
As I mentioned the white part is there even with the "writing" in the original position. And if you move the "writing" way up, that thin white area remains (and doesn't follow the "writing"). (and I still don't know why).
We should embrace problems, without which there wouldn't be any solutions.

User avatar
Tastenplayer
Registered User
Posts: 622
Joined: Thu Jul 03, 2014 9:20 pm
Location: Switzerland
Name: Jutta Koliofotis
Contact:

Re: [SPLIT] phpBB 3.3 style changes

Post by Tastenplayer »

It has to do with, in my opinion - from the legend.

Code: Select all

margin-top: -.4em;
	top: -.2em;
More of my styles you can find in my phpBB Style Board & More
Be the best version of yourself rather than a bad copy of someone else!
Excuse me for my English, but I learned the language by speaking to people and not at school.

User avatar
Hero.73
Registered User
Posts: 62
Joined: Fri Feb 14, 2020 8:27 pm
Location: Germany

Re: [SPLIT] phpBB 3.3 style changes

Post by Hero.73 »

I tried the white writing always remains
I have also tried various modifications such as the one indicated above but that white line follows the line and I am not even sure where to eliminate it

Code: Select all

legend {
font-family: Tahoma,arial,Verdana,Sans-serif;
font-size: .9em;
font-weight: bold;
color: #115098;
margin-top: -.4em;
position: relative;
text-transform: none;
line-height: 1.2em;
top: -.2em;
vertical-align: middle;
background-color: white;
padding: 2px 5px 7px 10px;
margin-left: -10px;
}
I can move this change all the way to the right, but that damned white background always remains there

User avatar
Gumboots
Registered User
Posts: 315
Joined: Fri Oct 11, 2019 1:59 am

Re: [SPLIT] phpBB 3.3 style changes

Post by Gumboots »

Try this:

Code: Select all

legend {
    padding: 0;
    font-family: Tahoma,arial,Verdana,Sans-serif;
    font-size: .9em;
    font-weight: bold;
    color: #115098;
    margin-top: 0;
    position: relative;
    text-transform: none;
    line-height: 1.2em;
    top: -.6em;
    vertical-align: middle;
    border-bottom: 1px solid #D7D7D7;
}
Note that this may need more refinement for use with non-standard font sizes, as .1em increments are pretty crude.

User avatar
Hero.73
Registered User
Posts: 62
Joined: Fri Feb 14, 2020 8:27 pm
Location: Germany

Re: [SPLIT] phpBB 3.3 style changes

Post by Hero.73 »

Gumboots wrote:
Fri Feb 28, 2020 9:15 pm
Try this:

Code: Select all

legend {
    padding: 0;
    font-family: Tahoma,arial,Verdana,Sans-serif;
    font-size: .9em;
    font-weight: bold;
    color: #115098;
    margin-top: 0;
    position: relative;
    text-transform: none;
    line-height: 1.2em;
    top: -.6em;
    vertical-align: middle;
    border-bottom: 1px solid #D7D7D7;
}
Note that this may need more refinement for use with non-standard font sizes, as .1em increments are pretty crude.
same also with that modification the border is added but the white background remains the same
Attachments
Cattura.PNG

User avatar
Tastenplayer
Registered User
Posts: 622
Joined: Thu Jul 03, 2014 9:20 pm
Location: Switzerland
Name: Jutta Koliofotis
Contact:

Re: [SPLIT] phpBB 3.3 style changes

Post by Tastenplayer »

It is about the <legend>General settings</legend> (legend title) is in the fieldset in the html. Therefore both are always shifted simultaneously.
It must go above. Then the legend can be adjusted with background and distance (By default the legend title should be placed above the fieldset and not in the fieldset!)
acp legend.jpg
The only question is in which html file? Quite likely in several :) .

Code: Select all

legend {
	font-family: Tahoma,arial,Verdana,Sans-serif;
	font-size: .9em;
	font-weight: bold;
	color: #115098;
	position: relative;
	text-transform: none;
	line-height: 1.2em;
	vertical-align: middle;
	background: white;
	padding-left: 11px;
	margin: 0 1px -16px;
	padding-bottom: 5px;
	padding-top: 3px;
}
Unfortunately I got somewhere and the adjustment is gone again. That's why I can't do a screen anymore. There is a very thin grey line under the title legend - If it bothers you you also have to remove the border-top in the fieldset. But it looks quite good with the grey dividing line.
Otherwise everything is even.
However, I could no longer see what it would look like with the legendary title underneath.

Maybe you should also remove vertical-align: middle; in the legend?

Or you simply leave the legendary title further up in the gray part. There it can be adjusted quite well.
More of my styles you can find in my phpBB Style Board & More
Be the best version of yourself rather than a bad copy of someone else!
Excuse me for my English, but I learned the language by speaking to people and not at school.

User avatar
Hero.73
Registered User
Posts: 62
Joined: Fri Feb 14, 2020 8:27 pm
Location: Germany

Re: [SPLIT] phpBB 3.3 style changes

Post by Hero.73 »

I also tried as you say this is the result
Attachments
Cattura.PNG

User avatar
Hero.73
Registered User
Posts: 62
Joined: Fri Feb 14, 2020 8:27 pm
Location: Germany

Re: [SPLIT] phpBB 3.3 style changes

Post by Hero.73 »

Yes resolved

Code: Select all

fieldset dt {
	width: 45%;
	text-align: left;
	border: none;
	border-right: 0px solid #CCCCCC;
	padding-top: 3px;
}

Code: Select all

legend {
    font-family: Tahoma,arial,Verdana,Sans-serif;
    font-size: .9em;
    font-weight: bold;
    color: #115098;
    margin-top: 0;
    position: relative;
    text-transform: none;
    line-height: 1.2em;
    top: -.9em;
    border-bottom: 1px solid #D7D7D7;
    padding-left: 1px;
    margin: 0px -5px -10px;
    padding-bottom: 1px;
    padding-top: 7px;
}

User avatar
Tastenplayer
Registered User
Posts: 622
Joined: Thu Jul 03, 2014 9:20 pm
Location: Switzerland
Name: Jutta Koliofotis
Contact:

Re: [SPLIT] phpBB 3.3 style changes

Post by Tastenplayer »

Hero.73 wrote:
Sat Feb 29, 2020 3:56 pm
I also tried as you say this is the result
I have no idea what you did. With my html modification and code adaption here viewtopic.php?p=15445491#p15445491 it looked perfect.
Main Matter you've found a solution.
More of my styles you can find in my phpBB Style Board & More
Be the best version of yourself rather than a bad copy of someone else!
Excuse me for my English, but I learned the language by speaking to people and not at school.

Post Reply

Return to “phpBB Custom Coding”