converting code from wp to phpbb

[greenwingmacaws2]

thanks for your help guys
<a href="mailto:?subject={TOPIC_TITLE}&body={CURRENT_URL}" target="_blank"> this works
just added a line to functions,php

Code: Select all

'CURRENT_URL'	                 	=> generate_board_url(true) . '/' . $user->page['page'],

[warmweer]

With custom coding:
ALWAYS keep track of what you've done since the recommended update/grade will overwrite your edits, so you'll have to reapply those.
Also be aware that custom code may or may not function as intended/expected in the next version(s). (in this case it probably will).

[AmigoJack]

Code: Select all

append_sid

Adding a SID to a URI that will land in an email which most likely is sent to a different person than the sender makes no sense at all. It's more like weakening security.

[greenwingmacaws2]

this enables anyone to share any post from my website by email, the email is sent from the users own email and not my website. so im not seeing a security issue here and i am not enabling spammers to access my sites email.
If anyone would likw to check this out in just a few simple steps
open /styles/prosilver/template/viewtopic_body.html and find this

Code: Select all

<!-- END postrow -->

and then add this

Code: Select all

<div class="panel">a href="mailto:?subject={TOPIC_TITLE}&body={CURRENT_URL} " target="_blank"> 
<img src="/email.png" border="0" alt="Email" width="40" height="40"></div>

you will need to upload an email image to the root of your server or modify the image src section above
then go open /includes/functions.php and around line 4000 add the following

Code: Select all

'CURRENT_URL'	                 	=> generate_board_url(true) . '/' . $user->page['page'],

Save these file and upload them , purge the cache from ACP.
and go to any post on your site you will find the email link underneath the post

[Steve]

Wrong post. Sorry

[Steve]

I done a big of digging, you could copy root/phpbb/message/topic_forum.php and convert it to email posts quite easily.

[greenwingmacaws2]

a slight addition
just in case anyone is using gmail on an android phone or tablet , gmail does not like the =number in automated urls
my work around for this is

Code: Select all

<a href="mailto:?subject={TOPIC_TITLE}&amp;body='.rawurlencode({CURRENT_URL}).' title="{TOPIC_TITLE}" target="_blank">
<img src="/email.png" border="0" alt="Email" width="40" height="40" >

now the link is sent successfully in gmail.

[AmigoJack]

gmail does not like the =number

I'm pretty sure it's the &, which is neither the entity it needs to be in the HTML context (&), nor being percent-encoded in the URI parameter value context (%25).

Code: Select all

<a href="mailto:?subject={TOPIC_TITLE}&amp;body='.rawurlencode({CURRENT_URL}).' title="

Guys, you need to concentrate:

1. This is invalid HTML: the attribute href begins with a quotation (") but doesn't end with one - its content includes title=.
2. What if the topic title itself contains &? That will suddenly end your email subject right there and afterwards begin a different URI parameter. Expect an URI that becomes mailto:?subject=Laurel & Hardy=funny&body=https%3A%2F%2Fboard.net%2Fviewtopic.php%3Ft=2620891%26start=15 to see what "encoding" means in each parameter.
3. You have to mind that you put URI parameters into an URI - if you cannot tell apart parameters from an URI then you're just pushing your luck.

You need to

1. URL encode any parameter, not just the one for body. Also for subject.
2. Preferably do that in your extension or PHP file, not the style's generated PHP file, or
3. as per Twig use {{ TOPIC_TITLE | url_encode(true) }} in your template file instead of {TOPIC_TITLE}.