Nope.
show us a screenshot of the settings that you set for the attachments.
robert
That did the trick. Didn't get the error message that time. I had just assumed that if I deleted the valies that were in there by default, 0 would be automatically substituted. That's what used to happen with previous versions of phpBB. I'd just delete the default value, save the settings, and then when I'd check on them later on, 0 would have automatically been inserted in those boxes.
Just tested here, if you delete those 3 values leaving empty those fields and submit the form the values are set back to 0.Bruce Banner wrote: βWed Mar 25, 2020 3:43 pm Not solved. It must be something else. Because I just retested the attachment settings by again deleting all the values and clicking Submit, and this time, there was no error message. So it must have been something else that caused the error message the first time.
So you're saying the reason I got those error messages was because, as well as leaving the values blank, I had the value types set to MB and KB. If I'd had them set to Bytes, those messages wouldn't have appeared, right?EA117 wrote: βWed Mar 25, 2020 10:37 pm I believe there are two parts to encountering the issue: Blank out the value instead of having a number entered or set by the spinner control, and have either "kilobytes" or "megabytes" selected as the value type. If you leave it with simply "bytes" selected, there isn't any math that needs to be performed against the value that is entered, and therefore no "but this is not a number" warning would occur.
You clearly didn't read every previous post in the thread. If you had, you'd know that I was aleeady aware that leaving fields blank should automatically set them to 0. I had assumed that's what would happen this time but then I got those error messages.3Di wrote: βWed Mar 25, 2020 11:31 pmJust tested here, if you delete those 3 values leaving empty those fields and submit the form the values are set back to 0.Bruce Banner wrote: βWed Mar 25, 2020 3:43 pm Not solved. It must be something else. Because I just retested the attachment settings by again deleting all the values and clicking Submit, and this time, there was no error message. So it must have been something else that caused the error message the first time.
In the code nothing changed since 5 years ago and before it was 13 years ago.
https://github.com/phpbb/phpbb/blame/ma ... s.php#L555
As you just did here.3Di wrote: βWed Mar 25, 2020 11:39 pm Oh, found the bug!
Fixed locally, I will set up a PR. And done https://github.com/phpbb/phpbb/pull/5924
Thanks. I'll try them.stevemaury wrote: βThu Mar 26, 2020 4:44 pm OP, here are the additions and deletions to try:
https://github.com/3D-I/phpbb/commit/5b ... 309bd8c4bf
Correct. I was not seeing the issue either, even when blanking out the value. But after looking at the code, realized that no math would have been attempted with the entered values unless something other than "bytes" was selected.Bruce Banner wrote: βThu Mar 26, 2020 5:16 pm So you're saying the reason I got those error messages was because, as well as leaving the values blank, I had the value types set to MB and KB. If I'd had them set to Bytes, those messages wouldn't have appeared, right?
What that link literally shows are the differences between 3Di's v1 and v2 of the proposed fix, and not "the fix relative to the baseline found in the phpBB 3.3.0 release."stevemaury wrote: βThu Mar 26, 2020 4:44 pm OP, here are the additions and deletions to try:
https://github.com/3D-I/phpbb/commit/5b ... 309bd8c4bf
Yes, sorry. Misread what I was looking at.EA117 wrote: βThu Mar 26, 2020 5:39 pm
What that link literally shows are the differences between 3Di's v1 and v2 of the proposed fix, and not "the fix relative to the baseline found in the phpBB 3.3.0 release."stevemaury wrote: βThu Mar 26, 2020 4:44 pm OP, here are the additions and deletions to try:
https://github.com/3D-I/phpbb/commit/5b ... 309bd8c4bf
Potentially https://github.com/phpbb/phpbb/pull/5924/files gives a better view of what will be seen when looking for what change to add to an otherwise phpBB 3.3.0 acp_attachments.php, although the proposed fix is still receiving review feedback.
EA117 wrote: βThu Mar 26, 2020 5:39 pmWhat that link literally shows are the differences between 3Di's v1 and v2 of the proposed fix, and not "the fix relative to the baseline found in the phpBB 3.3.0 release."
Potentially https://github.com/phpbb/phpbb/pull/5924/files gives a better view of what will be seen when looking for what change to add to an otherwise phpBB 3.3.0 acp_attachments.php, although the proposed fix is still receiving review feedback.
stevemaury wrote: βThu Mar 26, 2020 5:50 pm