Problem with updating attachment settings

Bruce Banner · Post by **Bruce Banner** » Wed Mar 25, 2020 2:07 pm

Just updated my attachment settings the way I wanted them, and the "configuration updated successfully", but the following line appeared three times at the top of the screen.

[phpBB Debug] PHP Warning: in file [ROOT]/includes/acp/acp_attachments.php on line 214: A non-numeric value encountered

Lumpy Burgertushie · Post by **Lumpy Burgertushie** » Wed Mar 25, 2020 3:02 pm

were you editing that file for some reason?

show us a screenshot of the settings that you set for the attachments.

robert

Bruce Banner · Post by **Bruce Banner** » Wed Mar 25, 2020 3:21 pm

Lumpy Burgertushie wrote: ↑Wed Mar 25, 2020 3:02 pm were you editing that file for some reason?

Nope.

show us a screenshot of the settings that you set for the attachments.

robert

Post by **KevC** » Wed Mar 25, 2020 3:26 pm

What happens if you put a zero (or any digit) in the boxes that are empty. I'm not sure you can have nothing in them.

Bruce Banner · Post by **Bruce Banner** » Wed Mar 25, 2020 3:33 pm

KevC wrote: ↑Wed Mar 25, 2020 3:26 pm What happens if you put a zero (or any digit) in the boxes that are empty. I'm not sure you can have nothing in them.

That did the trick. Didn't get the error message that time. I had just assumed that if I deleted the valies that were in there by default, 0 would be automatically substituted. That's what used to happen with previous versions of phpBB. I'd just delete the default value, save the settings, and then when I'd check on them later on, 0 would have automatically been inserted in those boxes.

Bruce Banner · Post by **Bruce Banner** » Wed Mar 25, 2020 3:43 pm

Not solved. It must be something else. Because I just retested the attachment settings by again deleting all the values and clicking Submit, and this time, there was no error message. So it must have been something else that caused the error message the first time.

EA117 · Post by **EA117** » Wed Mar 25, 2020 10:37 pm

I believe there are two parts to encountering the issue: Blank out the value instead of having a number entered or set by the spinner control, and have either "kilobytes" or "megabytes" selected as the value type. If you leave it with simply "bytes" selected, there isn't any math that needs to be performed against the value that is entered, and therefore no "but this is not a number" warning would occur.

3Di · Post by **3Di** » Wed Mar 25, 2020 11:31 pm

Bruce Banner wrote: ↑Wed Mar 25, 2020 3:43 pm Not solved. It must be something else. Because I just retested the attachment settings by again deleting all the values and clicking Submit, and this time, there was no error message. So it must have been something else that caused the error message the first time.

Just tested here, if you delete those 3 values leaving empty those fields and submit the form the values are set back to 0.

In the code nothing changed since 5 years ago and before it was 13 years ago.
https://github.com/phpbb/phpbb/blame/ma ... s.php#L555

3Di · Post by **3Di** » Wed Mar 25, 2020 11:39 pm

Oh, found the bug!

: 2020-03-26 00_38_16-Information.png (11.35 KiB) Viewed 500 times

Fixed locally, I will set up a PR. And done https://github.com/phpbb/phpbb/pull/5924

Post by **stevemaury** » Thu Mar 26, 2020 4:44 pm

OP, here are the additions and deletions to try:

https://github.com/3D-I/phpbb/commit/5b ... 309bd8c4bf

Bruce Banner · Post by **Bruce Banner** » Thu Mar 26, 2020 5:16 pm

EA117 wrote: ↑Wed Mar 25, 2020 10:37 pm I believe there are two parts to encountering the issue: Blank out the value instead of having a number entered or set by the spinner control, and have either "kilobytes" or "megabytes" selected as the value type. If you leave it with simply "bytes" selected, there isn't any math that needs to be performed against the value that is entered, and therefore no "but this is not a number" warning would occur.

So you're saying the reason I got those error messages was because, as well as leaving the values blank, I had the value types set to MB and KB. If I'd had them set to Bytes, those messages wouldn't have appeared, right?

3Di wrote: ↑Wed Mar 25, 2020 11:31 pm
Bruce Banner wrote: ↑Wed Mar 25, 2020 3:43 pm Not solved. It must be something else. Because I just retested the attachment settings by again deleting all the values and clicking Submit, and this time, there was no error message. So it must have been something else that caused the error message the first time.
Just tested here, if you delete those 3 values leaving empty those fields and submit the form the values are set back to 0.

In the code nothing changed since 5 years ago and before it was 13 years ago.
https://github.com/phpbb/phpbb/blame/ma ... s.php#L555

You clearly didn't read every previous post in the thread. If you had, you'd know that I was aleeady aware that leaving fields blank should automatically set them to 0. I had assumed that's what would happen this time but then I got those error messages.

3Di wrote: ↑Wed Mar 25, 2020 11:39 pm Oh, found the bug!

2020-03-26 00_38_16-Information.png
Fixed locally, I will set up a PR. And done https://github.com/phpbb/phpbb/pull/5924

As you just did here.

stevemaury wrote: ↑Thu Mar 26, 2020 4:44 pm OP, here are the additions and deletions to try:

https://github.com/3D-I/phpbb/commit/5b ... 309bd8c4bf

Thanks. I'll try them.

EA117 · Post by **EA117** » Thu Mar 26, 2020 5:39 pm

Bruce Banner wrote: ↑Thu Mar 26, 2020 5:16 pm So you're saying the reason I got those error messages was because, as well as leaving the values blank, I had the value types set to MB and KB. If I'd had them set to Bytes, those messages wouldn't have appeared, right?

Correct. I was not seeing the issue either, even when blanking out the value. But after looking at the code, realized that no math would have been attempted with the entered values unless something other than "bytes" was selected.

stevemaury wrote: ↑Thu Mar 26, 2020 4:44 pm OP, here are the additions and deletions to try:

https://github.com/3D-I/phpbb/commit/5b ... 309bd8c4bf

What that link literally shows are the differences between 3Di's v1 and v2 of the proposed fix, and not "the fix relative to the baseline found in the phpBB 3.3.0 release."

Potentially https://github.com/phpbb/phpbb/pull/5924/files gives a better view of what will be seen when looking for what change to add to an otherwise phpBB 3.3.0 acp_attachments.php, although the proposed fix is still receiving review feedback.

Post by **stevemaury** » Thu Mar 26, 2020 5:50 pm

EA117 wrote: ↑Thu Mar 26, 2020 5:39 pm

stevemaury wrote: ↑Thu Mar 26, 2020 4:44 pm OP, here are the additions and deletions to try:

https://github.com/3D-I/phpbb/commit/5b ... 309bd8c4bf
What that link literally shows are the differences between 3Di's v1 and v2 of the proposed fix, and not "the fix relative to the baseline found in the phpBB 3.3.0 release."

Potentially https://github.com/phpbb/phpbb/pull/5924/files gives a better view of what will be seen when looking for what change to add to an otherwise phpBB 3.3.0 acp_attachments.php, although the proposed fix is still receiving review feedback.

Yes, sorry. Misread what I was looking at.

Bruce Banner · Post by **Bruce Banner** » Thu Mar 26, 2020 5:56 pm

EA117 wrote: ↑Thu Mar 26, 2020 5:39 pmWhat that link literally shows are the differences between 3Di's v1 and v2 of the proposed fix, and not "the fix relative to the baseline found in the phpBB 3.3.0 release."

Potentially https://github.com/phpbb/phpbb/pull/5924/files gives a better view of what will be seen when looking for what change to add to an otherwise phpBB 3.3.0 acp_attachments.php, although the proposed fix is still receiving review feedback.

stevemaury wrote: ↑Thu Mar 26, 2020 5:50 pm
EA117 wrote: ↑Thu Mar 26, 2020 5:39 pm

stevemaury wrote: ↑Thu Mar 26, 2020 4:44 pmYes, sorry. Misread what I was looking at.
Yeah, just tried making those deletions but couldn't find the first line of code I was supposed to delete.

Bruce Banner · Post by **Bruce Banner** » Thu Mar 26, 2020 6:19 pm

Sorry, messed up that last post. Put what I said inside one of the quotes. Meant to say

"Yeah, just tried making those deletions but couldn't find the first line of code I was supposed to delete."