After upgrading from 3.3.0 to 3.3.1 in ACP, the tab began to work incorrectly

[Harry_Harry]

Hello!
After upgrading from 3.3.0 to 3.3.1 in ACP, the tab began to work incorrectly. I show a screenshot.

[david63]

I believe that is normal behaviour if all the tabs cannot be displayed on the screen width. Try making your screen display wider.

[Harry_Harry]

I believe that is normal behaviour if all the tabs cannot be displayed on the screen width. Try making your screen display wider.

I don’t quite agree as there was no such thing in 3.3.0.

[david63]

I don’t quite agree as there was no such thing in 3.3.0.

There is (just tested it) - and as far as I can recall this has been the case since phpBB 3.1

[Harry_Harry]

There is (just tested it) - and as far as I can recall this has been the case since phpBB 3.1

I'm sorry, but I've never had this before.

[Harry_Harry]

Up to 3.3.1 container

Code: Select all

<div class="pointer">
   <div class="pointer-inner"></div>
</div>

always closed like this and not after the menu

Code: Select all

<div class="pointer">
   <div class="pointer-inner"></div>
     <ul class="dropdown-contents dropdown-nonscroll"....  
</div>

[Mellx1]

Just update my board to 3.3.1,yeah the dropdown style is not good.

[Tread]

Not really hard to fix its an typo max should be min-width

[GIK-Team]

The problem is similar in the main template:

[Harry_Harry]

So far I came up with it. I did it like that. Just no hassle. Let's see what will happen next.
In file
phpBB/adm/style/admin.js
in the tab management function

Code: Select all

/**
* Responsive tabs
*/

Code: Select all

item = ul.append('
<li class="tab responsive-tab" style="display:none;">
   <a href="javascript:void(0);" class="responsive-tab-link">&nbsp;</a>
   <div class="dropdown tab-dropdown" style="display: none;">
      <div class="pointer">
          <div class="pointer-inner" /></div>
      </div>
<ul class="dropdown-contents" /></div></li>
').find('li.responsive-tab'),

Just added second tag </div> after closed block <div class="pointer-inner" /></div>

In the end, this is how it happened: <div class="pointer-inner" /></div></div>


I understand that this is not entirely true, but it works

[HaioPaio]

I would appreciate a response from the development team if this is either a known an tolerated problem or a new and surprising behaviour.
Both reasons would be acceptable to me, other than "silence" and "smart" behaviour.

[GIK-Team]

Just added second tag </div> after closed block <div class="pointer-inner" /></div>

In the end, this is how it happened: <div class="pointer-inner" /></div></div>


I understand that this is not entirely true, but it works

I did the same, but without the backslash

Code: Select all

<div class="pointer-inner"></div>

And twice in
/styles/prosilver/template/forum_fn.js
Line: 462
Line: 816

[Harry_Harry]

Just added second tag </div> after closed block <div class="pointer-inner" /></div>

In the end, this is how it happened: <div class="pointer-inner" /></div></div>


I understand that this is not entirely true, but it works

I did the same, but without the backslash

Code: Select all

<div class="pointer-inner"></div>

Hi!
This is it works and it's good. All perfectly! I am sure they and we will find a why in the future if strong need be.

[GIK-Team]

Hi!
This is it works and it's good. All perfectly! I am sure they and we will find a why in the future if strong need be.

Yes, this will definitely be fixed in the future, but we somehow need to live now. It is one thing when it is in the administrative part, and quite another when it affects users of our sites.

[Tread]

The issue is they used max-width it should be min-width