UCP Pagination Pull Request (PHPBB3-12976)

Get help with installation and running phpBB 3.3.x here. Please do not post bug reports, feature requests, or extension related questions here.
Post Reply
User avatar
GTI
Registered User
Posts: 96
Joined: Mon Aug 24, 2020 4:59 pm
Location: Hastings
Name: Laura M

UCP Pagination Pull Request (PHPBB3-12976)

Post by GTI »

I have been making some changes to my UCP pagination and found an old pull request which is marked as fixed, https://tracker.phpbb.com/browse/PHPBB3-12976

This PR mentions that on the UCP attachments page, if there is only 1 attachment, the pagination still says "1 attachments" (with the S)

Although the code changes are still present in 3.3.4, I currently have 1 attachment in my UCP list and it still says "1 attachments" rather than "1 attachment"

I don't see any comments saying the change has not worked so could this be something to do with the way my database is set up ?
User avatar
3Di
Former Team Member
Posts: 16947
Joined: Mon Apr 04, 2005 11:09 pm
Location: Have a guess... 🇮🇹
Name: Marco
Contact:

Re: UCP Pagination Pull Request (PHPBB3-12976)

Post by 3Di »

In ROOT\posting.php line 197

FIND
'NUM_ATTACHMENTS' => $user->lang('NUM_ATTACHMENTS', $num_attachments),

REPLACE WITH
'NUM_ATTACHMENTS' => $user->lang('NUM_ATTACHMENTS', (int) $num_attachments),
🆓 Free support for our extensions also provided here: phpBB Studio
🚀 Looking for a specific feature or alternative option? We will rock you!
Please PM me only to request paid works. Thx. Buy me a coffee -> Image
My development's activity º PhpStorm's proud user º Extensions, Scripts, MOD porting, Update/Upgrades
User avatar
3Di
Former Team Member
Posts: 16947
Joined: Mon Apr 04, 2005 11:09 pm
Location: Have a guess... 🇮🇹
Name: Marco
Contact:

Re: UCP Pagination Pull Request (PHPBB3-12976)

Post by 3Di »

3Di wrote:
Thu Aug 05, 2021 12:16 pm
In ROOT\posting.php line 197
Sorry, in ROOT\includes\ucp\ucp_attachments.php, same line ;)
🆓 Free support for our extensions also provided here: phpBB Studio
🚀 Looking for a specific feature or alternative option? We will rock you!
Please PM me only to request paid works. Thx. Buy me a coffee -> Image
My development's activity º PhpStorm's proud user º Extensions, Scripts, MOD porting, Update/Upgrades
User avatar
3Di
Former Team Member
Posts: 16947
Joined: Mon Apr 04, 2005 11:09 pm
Location: Have a guess... 🇮🇹
Name: Marco
Contact:

Re: UCP Pagination Pull Request (PHPBB3-12976)

Post by 3Di »

🆓 Free support for our extensions also provided here: phpBB Studio
🚀 Looking for a specific feature or alternative option? We will rock you!
Please PM me only to request paid works. Thx. Buy me a coffee -> Image
My development's activity º PhpStorm's proud user º Extensions, Scripts, MOD porting, Update/Upgrades
Post Reply

Return to “[3.3.x] Support Forum”