UCP Pagination Pull Request (PHPBB3-12976)

Get help with installation and running phpBB 3.3.x here. Please do not post bug reports, feature requests, or extension related questions here.
Post Reply
User avatar
GTI
Registered User
Posts: 300
Joined: Mon Aug 24, 2020 4:59 pm
Location: West Sussex
Name: Laura

UCP Pagination Pull Request (PHPBB3-12976)

Post by GTI »

I have been making some changes to my UCP pagination and found an old pull request which is marked as fixed, https://tracker.phpbb.com/browse/PHPBB3-12976

This PR mentions that on the UCP attachments page, if there is only 1 attachment, the pagination still says "1 attachments" (with the S)

Although the code changes are still present in 3.3.4, I currently have 1 attachment in my UCP list and it still says "1 attachments" rather than "1 attachment"

I don't see any comments saying the change has not worked so could this be something to do with the way my database is set up ?
Most of us will enjoy Christmas in the comfort of our own homes this year, however, sadly, that can't be said for people in the Ukraine who are suffering day after day, due to the Russian invasion.

If you would like to make a small donation to help Ukrainians in their time of need, you can donate to help all Ukrainians via BritishRedCross or you can donate to help the Ukrainian children via Unicef. ๐Ÿ‡บ๐Ÿ‡ฆ Thank You ๐Ÿ‡บ๐Ÿ‡ฆ
User avatar
3Di
I've Been Banned!
Posts: 17538
Joined: Mon Apr 04, 2005 11:09 pm
Location: I'm with Ukraine 🇺🇦
Name: Marco
Contact:

Re: UCP Pagination Pull Request (PHPBB3-12976)

Post by 3Di »

In ROOT\posting.php line 197

FIND
'NUM_ATTACHMENTS' => $user->lang('NUM_ATTACHMENTS', $num_attachments),

REPLACE WITH
'NUM_ATTACHMENTS' => $user->lang('NUM_ATTACHMENTS', (int) $num_attachments),
๐Ÿ†“ Free support for our extensions also provided here: phpBB Studio
๐Ÿš€ Looking for a specific feature or alternative option? We will rock you!
Please PM me only to request paid works. Thx. Buy me a coffee -> Image
My development's activity ยบ PhpStorm's proud user ยบ Extensions, Scripts, MOD porting, Update/Upgrades
User avatar
3Di
I've Been Banned!
Posts: 17538
Joined: Mon Apr 04, 2005 11:09 pm
Location: I'm with Ukraine 🇺🇦
Name: Marco
Contact:

Re: UCP Pagination Pull Request (PHPBB3-12976)

Post by 3Di »

3Di wrote: โ†‘Thu Aug 05, 2021 12:16 pm In ROOT\posting.php line 197
Sorry, in ROOT\includes\ucp\ucp_attachments.php, same line ;)
๐Ÿ†“ Free support for our extensions also provided here: phpBB Studio
๐Ÿš€ Looking for a specific feature or alternative option? We will rock you!
Please PM me only to request paid works. Thx. Buy me a coffee -> Image
My development's activity ยบ PhpStorm's proud user ยบ Extensions, Scripts, MOD porting, Update/Upgrades
User avatar
3Di
I've Been Banned!
Posts: 17538
Joined: Mon Apr 04, 2005 11:09 pm
Location: I'm with Ukraine 🇺🇦
Name: Marco
Contact:

Re: UCP Pagination Pull Request (PHPBB3-12976)

Post by 3Di »

๐Ÿ†“ Free support for our extensions also provided here: phpBB Studio
๐Ÿš€ Looking for a specific feature or alternative option? We will rock you!
Please PM me only to request paid works. Thx. Buy me a coffee -> Image
My development's activity ยบ PhpStorm's proud user ยบ Extensions, Scripts, MOD porting, Update/Upgrades
Post Reply

Return to โ€œ[3.3.x] Support Forumโ€