Bug in MCP (3.3.5)

Get help with installation and running phpBB 3.3.x here. Please do not post bug reports, feature requests, or extension related questions here.
Post Reply
yukayuka
Registered User
Posts: 1
Joined: Thu Oct 21, 2021 2:28 pm

Bug in MCP (3.3.5)

Post by yukayuka »

Hi. Upgraded from 3.3.2 to 3.3.5 and now I'm unable to move posts from one topic to another as I cannot select new topic in MCP. Found out that f-param is missing in actions select box. Looks like phpbb_extra_url() in functions_mcp.php was modified without proper testing.
Before:

Code: Select all

function phpbb_extra_url()
{
	global $forum_id, $topic_id, $post_id, $report_id, $user_id;

	$url_extra = '';
	$url_extra .= ($forum_id) ? "&f=$forum_id" : '';
	$url_extra .= ($topic_id) ? "&t=$topic_id" : '';
	$url_extra .= ($post_id) ? "&p=$post_id" : '';
	$url_extra .= ($user_id) ? "&u=$user_id" : '';
	$url_extra .= ($report_id) ? "&r=$report_id" : '';

	return $url_extra;
}
After:

Code: Select all

function phpbb_extra_url()
{
	global $forum_id, $topic_id, $post_id, $report_id, $user_id;

	if ($post_id)
	{
		$url_extra = "&p=$post_id";
	}
	else if ($topic_id)
	{
		$url_extra = "&t=$topic_id";
	}
	else if ($forum_id)
	{
		$url_extra = "&f=$forum_id";
	}
	else
	{
		$url_extra = '';
	}
	$url_extra .= ($user_id) ? "&u=$user_id" : '';
	$url_extra .= ($report_id) ? "&r=$report_id" : '';

	return $url_extra;
}
User avatar
david63
Registered User
Posts: 20646
Joined: Thu Dec 19, 2002 8:08 am

Re: Bug in MCP (3.3.5)

Post by david63 »

Is your style 3.3.5 compatible?

If you believe you have found a bug then you should post in the Bug Tracker so that it can be investigated and, if necessary, fixed.
David
Remember: You only know what you know and - you don't know what you don't know!

I now no longer support any of my extensions but they will start to become available here
Post Reply

Return to “[3.3.x] Support Forum”