Mistake in Prosilver

For support and discussion related to templates and themes in phpBB 3.3.
User avatar
3Di
Former Team Member
Posts: 14823
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: Mistake in Prosilver

Post by 3Di »

Talk19Zehn wrote:
Mon Jan 13, 2020 6:30 pm
I'm not registered there
Credentials for the tracker are the same as phpbb dot com ;)
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
:studio_microphone: Premium extensions @ The Studio

User avatar
Tastenplayer
Registered User
Posts: 495
Joined: Thu Jul 03, 2014 9:20 pm
Location: Switzerland
Name: Jutta Koliofotis
Contact:

Re: Mistake in Prosilver

Post by Tastenplayer »

If I add that with my English there they might get states. Besides it looks complicated - I'm getting old ;)
My phpBB Style Board & More
Be the best version of yourself rather than a bad copy of someone else!
Excuse me for my English, but I learned the language by speaking to people and not at school.

User avatar
Talk19Zehn
Registered User
Posts: 449
Joined: Tue Aug 09, 2011 1:10 pm
Contact:

Re: Mistake in Prosilver

Post by Talk19Zehn »

3Di wrote:
Mon Jan 13, 2020 7:21 pm
...
Credentials for the tracker are the same as phpbb dot com ;)
...
Menno, ihr lest doch fast alles mit. :)

Hm, well, a message is created ....
https://tracker.phpbb.com/browse/PHPBB3-16319
Maybe we are lucky and a solution will not take a long time ....
Respect and thanks going to Sir Tim Berners-Lee
My own works: Ongray-Design-de | Rhea, Ongray-Design-de | Proteus
Take a look into some bundles: VT-Theme

User avatar
Hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 943
Joined: Wed Dec 30, 2009 8:14 am
Name: Michael Miday
Contact:

Re: Mistake in Prosilver

Post by Hanakin »

Ok let me shed some light on things here.
  1. We can not fix anything without there being a bug report in the tracker as all changes must be tied to a tracker ticket for proper tracking and documentation for version release. As we have to point our pull requests to a specific tracker ticket. This is how all development works.
  2. Prosilver is an ancient style built with very bad code practices and organizational patterns which make it extremely difficult to fix these sorts of things simply the way we should be able too. The original authors did not actually understand how CSS as a language actually worked combined with the infancy of the language at the time. Adding in lots of roadblocks to the development process.
  3. As for this issue. This is not an easy fix. It has actually been fixed or patched several times already. The problem stems from the fact that we are not using a grid but instead relying on arbitrary percents over several breakpoints. The way to fix it would probably require a complete re-write of the post. Best we could do is patch it again with px values as the percents do not render the same on every browser across every OS, but this would just be another patch.
  4. We also have to take Backwards compatibility (BC) in to consideration when making changes. In order to fix this we would have to completely re-code the entire post component from scratch. This is a huge BC change outside the scope of a minor release. there are 3 types of releases in development following semvar concepts Major, Minor, Patch. We do not allow BC for the them in Patch releases unless its a security or fatal bug. Minor releases can have some minor BCs but nothing major. That is where Major releases com in to play. Major releases maintain no BC requirement if necessary. This is done to prevent style/ext authors from having to make huge changes with every release.
That means we could not truly fix it until 4.0, however we are releasing a new default theme which is far more important in the grand scheme of things. This make a bug report more important as this is very low on the need to do list.

User avatar
Tastenplayer
Registered User
Posts: 495
Joined: Thu Jul 03, 2014 9:20 pm
Location: Switzerland
Name: Jutta Koliofotis
Contact:

Re: Mistake in Prosilver

Post by Tastenplayer »

All clear and plain Hanakin. But if a team member is aware of such a mistake, why doesn't he open a ticket? Why do you have to notice it yourself after several phpBB updates. Since 3.2.0 this error exists already! I definitely cannot understand that.

If I were a team member on .com and such a bug was reported to me in prosilver or if I knew about it, I would definitely not wait until someone opens a ticket, but do it myself!

On the side:
When I correct my files for errors in CSS Lint, all things that are not quite correct in prosilver are also displayed (actually not allowed) ;) :) They are not wrong, because not red - but yellow for just not quite correct. http://csslint.net/ Whether all this is up to date in CSS Lint? If I look at the version date in Notepad++, which unfortunately doesn't work for me anymore, probably not. To check my styles, before submitting them for validation, it is enough in any case.
My phpBB Style Board & More
Be the best version of yourself rather than a bad copy of someone else!
Excuse me for my English, but I learned the language by speaking to people and not at school.

User avatar
Hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 943
Joined: Wed Dec 30, 2009 8:14 am
Name: Michael Miday
Contact:

Re: Mistake in Prosilver

Post by Hanakin »

Firstly we have other priorities that take up what little time we have. Our focus is on not just patching or fixing bugs, but also reviewing all the fixes that are submitted. On top of that. This is an edge case bug as I pointed out before. Lastly I am the only Front-end developer for the project at the moment!

As for csslint? I have no idea what that is? we are using stylelint for all of our code control as of 4.0 forward to our standards which can be found here: https://github.com/phpbb/documentation/ ... opment/css the built version seems to be down at the moment.

Any code prior to that is not worth fixing unless it breaks as previously stated. Our focus is on replacing prosilver not fixing meaningless nuances. we are in a maintenance mode. While you will see some improvements to it in 4.0 they are only compatibility improvements for the new template system standards we are implementing for chameleon.

User avatar
John connor
Registered User
Posts: 2462
Joined: Fri Nov 14, 2014 5:14 pm
Location: U S Of A
Name: Aaron
Contact:

Re: Mistake in Prosilver

Post by John connor »

Talk19Zehn wrote:
Mon Jan 13, 2020 1:00 pm


Test, test, test ....


replace with:

Code: Select all

@media (min-width: 701px) and (max-width: 850px) {
	.postbody { width: 76%; }
	.postprofile { width: 22%; }
}

So is this the correct fix?

User avatar
Tastenplayer
Registered User
Posts: 495
Joined: Thu Jul 03, 2014 9:20 pm
Location: Switzerland
Name: Jutta Koliofotis
Contact:

Re: Mistake in Prosilver

Post by Tastenplayer »

If it is not a very extreme style, it always looks correct with this fix.
My phpBB Style Board & More
Be the best version of yourself rather than a bad copy of someone else!
Excuse me for my English, but I learned the language by speaking to people and not at school.

User avatar
Talk19Zehn
Registered User
Posts: 449
Joined: Tue Aug 09, 2011 1:10 pm
Contact:

Re: Mistake in Prosilver

Post by Talk19Zehn »

Hello, it's (only) basically a makeshift, non-binding approach. BTW: The particular case of a design is crucial. Especially since we are dealing with floated elements in percent et cetera.

Regards
Respect and thanks going to Sir Tim Berners-Lee
My own works: Ongray-Design-de | Rhea, Ongray-Design-de | Proteus
Take a look into some bundles: VT-Theme

User avatar
Tastenplayer
Registered User
Posts: 495
Joined: Thu Jul 03, 2014 9:20 pm
Location: Switzerland
Name: Jutta Koliofotis
Contact:

Re: Mistake in Prosilver

Post by Tastenplayer »

Which I just realized today, because I checked if I have inserted all icons in my style:

In prosilver 3.3.0-theme-images the bg_header and bg_list.gif is missing.
If you no longer need these images, they are still configured in tweaks.css. :?

Code: Select all

.headerbar, .forumbg {
	background-image: url("./images/bg_header.gif");
}

.forabg {
	background-image: url("./images/bg_list.gif");
So they would have to be put back in there, right?
In the phpBB 3.3.0 download on .com they are definitely missing in prosilver.
My phpBB Style Board & More
Be the best version of yourself rather than a bad copy of someone else!
Excuse me for my English, but I learned the language by speaking to people and not at school.

User avatar
Lumpy Burgertushie
Registered User
Posts: 67236
Joined: Mon May 02, 2005 3:11 am
Contact:

Re: Mistake in Prosilver

Post by Lumpy Burgertushie »

keep in mind that the tweaks.css file is only for very old versions of IE just in case anyone might still be using it.


robert
I'm baaaaaccckkkk. still doing work on donation basis. PM your needs.

Premium phpBB 3.3 Styles by PlanetStyles.net

If nobody is in the forest, does a tree really fall?

User avatar
Tastenplayer
Registered User
Posts: 495
Joined: Thu Jul 03, 2014 9:20 pm
Location: Switzerland
Name: Jutta Koliofotis
Contact:

Re: Mistake in Prosilver

Post by Tastenplayer »

Yes I know that (After all, a style author must know that), but if it is configured in the tweaks.css the pictures have to be inserted as well. Otherwise the old IE will search itself to death :mrgreen:
My phpBB Style Board & More
Be the best version of yourself rather than a bad copy of someone else!
Excuse me for my English, but I learned the language by speaking to people and not at school.

User avatar
Lumpy Burgertushie
Registered User
Posts: 67236
Joined: Mon May 02, 2005 3:11 am
Contact:

Re: Mistake in Prosilver

Post by Lumpy Burgertushie »

I agree. however, at some point you just have to stop supporting such old browsers that never worked very well to start with.

luck,
robert
I'm baaaaaccckkkk. still doing work on donation basis. PM your needs.

Premium phpBB 3.3 Styles by PlanetStyles.net

If nobody is in the forest, does a tree really fall?

User avatar
Talk19Zehn
Registered User
Posts: 449
Joined: Tue Aug 09, 2011 1:10 pm
Contact:

Re: Mistakes in Prosilver

Post by Talk19Zehn »

Hello and hello @Tastenplayer
phpBB - Proteus, style_version = 3.3.0, phpbb_version = 3.3.0

overall_header.html, arround line 64 (prosilver)

Conditional Comments: Internet Explorer versions, their version number [if lte IE 9]
<!--[if lte IE 9]>
<link href="{T_THEME_PATH}/tweaks.css?assets_version={T_ASSETS_VERSION}" rel="stylesheet">
<![endif]-->
IT MEANS:

<!--[if lte IE 9]>
All users worldwide with an Internet Explorer 9 or smaller see this content
<![endif]-->

BTW:
This also applies to simple_header.html, arround line 34 (prosilver)
Conditional Comments: [if lte IE 8]...

Before hastily deleting various concepts, you should know what the consequences are. So would this typical instruction "Conditional Comment" be superfluous?

Thanks and best regards
Respect and thanks going to Sir Tim Berners-Lee
My own works: Ongray-Design-de | Rhea, Ongray-Design-de | Proteus
Take a look into some bundles: VT-Theme

Post Reply

Return to “[3.3.x] Styles Support & Discussion”