forumtitle hover text decoration

For support and discussion related to templates and themes in phpBB 3.3.
User avatar
Prosk8er
Registered User
Posts: 1620
Joined: Sun Mar 12, 2006 3:30 am
Location: Rochester, NY
Name: Tyler
Contact:

forumtitle hover text decoration

Post by Prosk8er »

hi just noticed in prosilver in links.css
there's this below on line 92

Code: Select all

.row-item a:hover {
	text-decoration: none
}
i know its missing the ";" i'll make a ticket/PR for this but it blocks text underline which is set for the following

Code: Select all

a.forumtitle:hover {
	text-decoration: underline;
}

Code: Select all

a.lastsubject:hover {
	text-decoration: underline;
}
so was row-item a:hover meant to be none or was it suppose to be underline or should the class be removed entirely?
in prosilver for 3.0.x forumtitle was underlined when hovering

*went through the rest of the css files and found some more missing the semicolon but waiting on this before i make a ticket/PR
User avatar
Talk19Zehn
Registered User
Posts: 675
Joined: Tue Aug 09, 2011 1:10 pm
Contact:

Re: forumtitle hover text decoration

Post by Talk19Zehn »

I can confirm that. A justification for the behavior is unknown to me. For me personally, the behavior is a mistake (for a long time). Unless the developers have wanted this behavior and therefore these are not integrated (template PHP files).... (?).

viewforum_body.html

phpBB3/viewforum.php?f=1 (example)
  • <a href="./viewforum.php?f=2" class="forumtitle"> ...
The classes does not work through: a.forumtitle:hover, a.lastsubject:hover (links.css)

Code: Select all

a.forumtitle:hover {
	text-decoration: underline;
}

Code: Select all

a.lastsubject:hover {
	text-decoration: underline;
}

phpBB3/viewforum.php?f=2 (example)
  • <a href="./viewtopic.php?f=2&t=1" class="topictitle"> ...
The class is working through: a.topictitle:hover (links.css)

Code: Select all

a.topictitle:hover {
	text-decoration: underline;
}
AND also into the forumlist_body.html

The classes does not work through: a.forumtitle:hover, a.lastsubject:hover (links.css)

Code: Select all

a.forumtitle:hover {
	text-decoration: underline;
}

Code: Select all

a.lastsubject:hover {
	text-decoration: underline;
}

Whether the use in the colours.css can override links.css, would depend on a try. In my case it worked. The lack of semicolon is likely to be balanced in modern browsers.

Nevertheless, the described behavior is faulty.

Best regards
User avatar
Prosk8er
Registered User
Posts: 1620
Joined: Sun Mar 12, 2006 3:30 am
Location: Rochester, NY
Name: Tyler
Contact:

Re: forumtitle hover text decoration

Post by Prosk8er »

i've noticed it for a while but never really looked in to it hopefully Hanakin can chime in on this
User avatar
Prosk8er
Registered User
Posts: 1620
Joined: Sun Mar 12, 2006 3:30 am
Location: Rochester, NY
Name: Tyler
Contact:

Re: forumtitle hover text decoration

Post by Prosk8er »

also noticed in links.css on line 96

Code: Select all

.row-item .topictitle:hover,
.row-item .subforum:hover,
.row-item .username:hover,
.row-item .username-coloured:hover {
	text-decoration: underline;
}
we could switch it to

Code: Select all

.row-item .forumtitle:hover,
.row-item .topictitle:hover,
.row-item .lastsubject:hover,
.row-item .subforum:hover,
.row-item .username:hover,
.row-item .username-coloured:hover {
	text-decoration: underline;
}
if the following needs to stay

Code: Select all

.row-item a:hover {
	text-decoration: none
}
User avatar
Talk19Zehn
Registered User
Posts: 675
Joined: Tue Aug 09, 2011 1:10 pm
Contact:

Re: forumtitle hover text decoration

Post by Talk19Zehn »

Hello,

#96
That works just fine in my first tests.

Also (here) with the correction of the missing semicolon.
#92

Code: Select all

.row-item a:hover {
	text-decoration: none;
}

A ticket / PR would be good and desirable in my view. Many thanks for your effort.


====
BTW: In my "true child designs", I will not change the links.css, as it is maintained in the original. I will integrate this workaround in my stylesheet.css in the upcoming version 3.3.5 if the developers do not capture the solution (links.css).
User avatar
GTI
Registered User
Posts: 96
Joined: Mon Aug 24, 2020 4:59 pm
Location: Hastings
Name: Laura M

Re: forumtitle hover text decoration

Post by GTI »

I have been through the whole of the prosilver style and there are over 30 bugs/mistakes in it,

The one you mention above makes guest usernames in the last post section on forumlist look like a link when guests don't have a profile to link to,

The majority are hard to notice and probably not worth reporting with the new style being in the works, I just wanted to learn more css and html for tweaking my board and thought it be a fun way to learn,

Bear in mind that when prosilver was developed a lot of fancy css wasn't supported, but there is a hell of a lot of css in there that could be made more simple which woud mean shorter and without changing the look of the style.
User avatar
Prosk8er
Registered User
Posts: 1620
Joined: Sun Mar 12, 2006 3:30 am
Location: Rochester, NY
Name: Tyler
Contact:

Re: forumtitle hover text decoration

Post by Prosk8er »

GTI it does that already by default(none of the above edits) for me just switched to prosilver and made a guest post and hover has underline but cant be clicked

usernames were already underlined for hover just last subject and forumtitle are being altered here with above code

Code: Select all

.row-item .topictitle:hover,
.row-item .subforum:hover,
.row-item .username:hover,
.row-item .username-coloured:hover {
	text-decoration: underline;
}
.row-item .username:hover, is what controls that but it also styles registered users
User avatar
GTI
Registered User
Posts: 96
Joined: Mon Aug 24, 2020 4:59 pm
Location: Hastings
Name: Laura M

Re: forumtitle hover text decoration

Post by GTI »

That's what I mean,
If you view a topic by a guest, his username on the topic page post profile doesn't underline when it's hovered over, so in my opinion the forum list and topic list behaviour should be the same and only clickable links should be underlined,

The solution for that is
.row-item .username:hover should be a.row-item .username:hover
and
.row-item .username-coloured:hover should be a.row-item .username-coloured:hover

On your original point, the .row-item class wasn't in phpBB 3.1 so I would assume for whatever reason they added that class, they added the bit of code you've mentioned and didn't test it fully to check for any implications,

I believe the mistake was that the .row-item block from line: 92 to line: 101 in links.css was supposed to have been placed on line 58 instead :lol:
User avatar
Talk19Zehn
Registered User
Posts: 675
Joined: Tue Aug 09, 2011 1:10 pm
Contact:

Re: forumtitle hover text decoration

Post by Talk19Zehn »

Yes, possibly it can also work in other ways, if a guest area is used.

ANONYMOUS: Guest - class username used no color as username-coloured and will not be used by the a-TAG.

REGISTERED USERS: Users without color as like *)username-coloured used an a-TAG and this class (normally (!)):

Code: Select all

a {
	color: #105289;
}
ACP / Groups / Manage groups
*)Group colour:
Defines the colour members’ usernames will appear in, leave blank for user default.
In addition, there are also other aspects, such as a:hover, a:focus, a:active


So I think, we can test this .row-item a.username:hover, codes: links.css

Code: Select all

.row-item a.username:hover {
	text-decoration: underline;
}

Code: Select all

.row-item .forumtitle:hover,
.row-item .topictitle:hover,
.row-item .lastsubject:hover,
.row-item .subforum:hover,
.row-item .username-coloured:hover {
	text-decoration: underline;
}
Best regards
User avatar
Prosk8er
Registered User
Posts: 1620
Joined: Sun Mar 12, 2006 3:30 am
Location: Rochester, NY
Name: Tyler
Contact:

Re: forumtitle hover text decoration

Post by Prosk8er »

ah gotcha GTI i'll make a ticket/pr for it i just tested it with this instead

Code: Select all

.row-item .forumtitle:hover,
.row-item .topictitle:hover,
.row-item .lastsubject:hover,
.row-item .subforum:hover,
.row-item a.username:hover,
.row-item a.username-coloured:hover {
	text-decoration: underline;
}
User avatar
Talk19Zehn
Registered User
Posts: 675
Joined: Tue Aug 09, 2011 1:10 pm
Contact:

Re: forumtitle hover text decoration

Post by Talk19Zehn »

Uups, unfortunately I was not indicated that we have written a contribution almost at the same time .... :?

Thanks for a ticket/ PR. Can you then please provide us with the link if it is done.
User avatar
Prosk8er
Registered User
Posts: 1620
Joined: Sun Mar 12, 2006 3:30 am
Location: Rochester, NY
Name: Tyler
Contact:

Re: forumtitle hover text decoration

Post by Prosk8er »

yeah we thought about using same concept though

i'll submit the ticket/PR later today
User avatar
Prosk8er
Registered User
Posts: 1620
Joined: Sun Mar 12, 2006 3:30 am
Location: Rochester, NY
Name: Tyler
Contact:

Re: forumtitle hover text decoration

Post by Prosk8er »

Last edited by Prosk8er on Wed Aug 04, 2021 11:52 pm, edited 1 time in total.
User avatar
thecoalman
Community Team Member
Community Team Member
Posts: 4966
Joined: Wed Dec 22, 2004 3:52 am
Location: Pennsylvania, U.S.A.
Contact:

Re: forumtitle hover text decoration

Post by thecoalman »

Prosk8er wrote:
Sat Jul 31, 2021 7:00 pm
i know its missing the ";" i'll make a ticket/PR for this but it blocks text underline which is set for the following
While it's good practice to keep things consistent the semi-colon is not required for the last rule or single rule. If for example you are using something to minify CSS that is one of the things removed as unnecessary. ;)
“Results! Why, man, I have gotten a lot of results! I have found several thousand things that won’t work.”

Attributed - Thomas Edison
User avatar
3Di
Former Team Member
Posts: 16947
Joined: Mon Apr 04, 2005 11:09 pm
Location: Have a guess... 🇮🇹
Name: Marco
Contact:

Re: forumtitle hover text decoration

Post by 3Di »

Well, I did inspect the whole prosilver folder using PhpStorm (the latest) and the suggestions provided by phpBB here
https://area51.phpbb.com/docs/dev/3.3.x ... storm.html

Impressive is the number of errors and warnings (2376 and 45) as per the shot here below.

Of course I'm not going to chase each one individually, I've closed my IDE and moved on. :ugeek:

-
phpStorm-prosilver.png
-
The missing semicolon for example has been noted
2021-08-04 01_58_48-334vanilla – links.css.png
2021-08-04 01_58_48-334vanilla – links.css.png (11.48 KiB) Viewed 1532 times
🆓 Free support for our extensions also provided here: phpBB Studio
🚀 Looking for a specific feature or alternative option? We will rock you!
Please PM me only to request paid works. Thx. Buy me a coffee -> Image
My development's activity º PhpStorm's proud user º Extensions, Scripts, MOD porting, Update/Upgrades
Post Reply

Return to “[3.3.x] Styles Support & Discussion”