Mass PM Topic Participants

All new MODs released in our MOD Database will be announced in here. All support for released MODs needs to take place in the Customisations Database.
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

NOTICE: This forum is only for the announcement of new releases and/or updates of MODs. Any MOD support should be obtained through the Customisations Database in the support area designated for each MOD.

A direct link to support for each MOD is in the first post of the respective topic.
Mudjosh
Registered User
Posts: 234
Joined: Sat Jun 14, 2008 11:04 pm

Re: Mass PM Topic Participants

Post by Mudjosh »

ok I gotcha. That will work I guess. I don't see a reason regular members need to mass PM anyway.. That is a open gateway to send spam PM.. :P

Thanks for the quick responce! That has to be the fastest one I have recieved on this forum! :D

And thank you for making this mod.. I would donate to support it but I really can't afford to. I hope you understand.
joebert
Registered User
Posts: 224
Joined: Mon Jan 24, 2005 5:50 am
Location: Kenneth City, FL USA
Name: Joe

Re: Mass PM Topic Participants

Post by joebert »

I'm subscribed to email notifications for replies to this thread, if Im around & it's something I can answer or fix quickly that's what will happen. :)
updown
Registered User
Posts: 542
Joined: Sat Jan 05, 2008 6:53 am

Re: Mass PM Topic Participants

Post by updown »

Since update to 3.0.3, there's seems to be a little issue with an error-message in the pm-form, saying that the form-token was not valid.

Should be something with this line in mcp.php:

Code: Select all

				$_REQUEST['form_token'] = $_POST['form_token'] = sha1($now . $user->data['user_form_salt'] . 'ucp_pm_compose');
Any possible fix for that?
joebert
Registered User
Posts: 224
Joined: Mon Jan 24, 2005 5:50 am
Location: Kenneth City, FL USA
Name: Joe

Re: Mass PM Topic Participants

Post by joebert »

phpBB 3.0.3 made a tiny change in the check_form_key function that makes an elapsed time of zero invalid.

I'll submit a repackaged version of this MOD for review shortly, but in the mean time the fix is literally as simple as adding a few characters to "mcp.php".

Code: Select all

-------------[ OPEN ]------------------------------
mcp.php

-------------[ FIND ]-------------------------------
$now = $_REQUEST['creation_time'] = $_POST['creation_time'] = time()

-------------[ AFTER / ADD ]---------------------
 - 5

-------------[ SAVE / CLOSE ALL FILES ]------
The whole line should now read

Code: Select all

$now = $_REQUEST['creation_time'] = $_POST['creation_time'] = time() - 5;
This fix causes the artificial form token to have a creation date of 5 seconds ago so that when the actual token check is done there's not an elapsed time of zero.
updown
Registered User
Posts: 542
Joined: Sat Jan 05, 2008 6:53 am

Re: Mass PM Topic Participants

Post by updown »

Thanks, this works :!:

While you're at it, I made some changes to the SQL:

Code: Select all

			$sql = 'SELECT DISTINCT p.poster_id
					FROM ' . POSTS_TABLE . ' p, ' . USERS_TABLE . ' u
					WHERE p.forum_id = ' . $forum_id . '
					AND u.user_id = p.poster_id
					AND u.user_type <> ' . (int) USER_INACTIVE . '
					AND p.poster_id <> ' . $user->data['user_id'] . '
					AND p.poster_id <> ' . (int) ANONYMOUS . '
					AND p.topic_id = ' . $topic_id;
			$result = $db->sql_query($sql);
  • Don't select Anonymous users (e.g. if they have been deleted in the meanwhile)
  • Don't select Inactive users (e.g. if they have been deactivated)
  • Don't select PM-author directly in the SQL, so you don't need this anymore:

    Code: Select all

    			// Remove author from the recipients
    			if(isset($_REQUEST['address_list']['u'][$user->data['user_id']]))
    			{
    				unset($_REQUEST['address_list']['u'][$user->data['user_id']]);
    			}
    
joebert
Registered User
Posts: 224
Joined: Mon Jan 24, 2005 5:50 am
Location: Kenneth City, FL USA
Name: Joe

Re: Mass PM Topic Participants

Post by joebert »

Don't the PM functions already handle that stuff ?
updown
Registered User
Posts: 542
Joined: Sat Jan 05, 2008 6:53 am

Re: Mass PM Topic Participants

Post by updown »

joebert wrote:Don't the PM functions already handle that stuff ?
That's a good question that I can't answer at the moment - but if, then only when the PM is sent.

I just found it annoying that there appear "Anonymous" and long-time deactivated users in the PM-recipients, they shouldn't be there at all
joebert
Registered User
Posts: 224
Joined: Mon Jan 24, 2005 5:50 am
Location: Kenneth City, FL USA
Name: Joe

Re: Mass PM Topic Participants

Post by joebert »

I'll take a closer look at it for the next release since this is the first time I've heard about that happening. I'd already had the bug-fix release in the queue.
updown
Registered User
Posts: 542
Joined: Sat Jan 05, 2008 6:53 am

Re: Mass PM Topic Participants

Post by updown »

There is also an other thing - Sorry I almost forgot that to mention: For the topic-title, we additionally need htmlspecialchars_decode - some topicnames of my board have quotes in it - for some reason they get "html-nized" to """

Code: Select all

                if ($config['allow_post_links'])
                {
                    $_REQUEST['message'] = $user->lang['TOPIC'] . ": [url=" . generate_board_url() . "/viewtopic.$phpEx?f={$forum_id}&t={$topic_id}]" . htmlspecialchars_decode($row['topic_title']) . "[/url]\n\n";
                }
                else
                {
                    $_REQUEST['message'] = $user->lang['TOPIC'] . ': ' . htmlspecialchars_decode($row['topic_title']) . " (" . generate_board_url() . "/viewtopic.$phpEx?f={$forum_id}&t={$topic_id})\n\n";
                }
                $_REQUEST['subject'] = 'Re: ' . htmlspecialchars_decode($row['topic_title']);
                $_POST['preview'] = true; 
joebert
Registered User
Posts: 224
Joined: Mon Jan 24, 2005 5:50 am
Location: Kenneth City, FL USA
Name: Joe

Re: Mass PM Topic Participants

Post by joebert »

I've decided not to support any of my phpBB mods anymore.

The mod template changes every time I submit an update and frankly, I'm beyond aggrevated with trying to keep up with it.

Sorry folks.
User avatar
darkonia
Registered User
Posts: 1901
Joined: Tue May 13, 2008 1:10 pm
Location: Munich, Germany
Contact:

Re: Mass PM Topic Participants

Post by darkonia »

very n1 mod, works fine for me and my members, thx :D
MMOG-Heaven - Das Gaming Portal
Community bedeutet Gleichgesinnte finden - MMOG-Heaven ist Deine Community! Von Spielern für Spieler bietet Dir dieses Portal genau das, was ein Spieler braucht. Bleibe ständig informiert, finde die neuesten MMORPGs, oder suche die frischesten News aus der Welt des Online Gamings - dieses und vieles mehr erwartet Dich auf MMOG-Heaven.
updown
Registered User
Posts: 542
Joined: Sat Jan 05, 2008 6:53 am

Re: Mass PM Topic Participants

Post by updown »

joebert wrote:I've decided not to support any of my phpBB mods anymore.
I'm sorry to hear that - thanks for your existing MODs and for your latest support! :roll:
joebert
Registered User
Posts: 224
Joined: Mon Jan 24, 2005 5:50 am
Location: Kenneth City, FL USA
Name: Joe

Re: Mass PM Topic Participants

Post by joebert »

To clarify, I'll still be watching these threads and will be more than happy to provide essential patches in them.

I'm just not going to aggrevate myself with the MOD DB circus anymore. The process NEVER goes smoothly for me. :D
moh.elmadany
Registered User
Posts: 441
Joined: Fri Nov 23, 2007 1:25 pm

Re: Mass PM Topic Participants

Post by moh.elmadany »

joebert wrote:phpBB 3.0.3 made a tiny change in the check_form_key function that makes an elapsed time of zero invalid.

I'll submit a repackaged version of this MOD for review shortly, but in the mean time the fix is literally as simple as adding a few characters to "mcp.php".

Code: Select all

-------------[ OPEN ]------------------------------
mcp.php

-------------[ FIND ]-------------------------------
$now = $_REQUEST['creation_time'] = $_POST['creation_time'] = time()

-------------[ AFTER / ADD ]---------------------
 - 5

-------------[ SAVE / CLOSE ALL FILES ]------
The whole line should now read

Code: Select all

$now = $_REQUEST['creation_time'] = $_POST['creation_time'] = time() - 5;
This fix causes the artificial form token to have a creation date of 5 seconds ago so that when the actual token check is done there's not an elapsed time of zero.
done this update

and please .. put this update in new release :)

Thanks
joebert
Registered User
Posts: 224
Joined: Mon Jan 24, 2005 5:50 am
Location: Kenneth City, FL USA
Name: Joe

Re: Mass PM Topic Participants

Post by joebert »

I don't want to take the time to get aquainted with the new MOD format, I will not be updating the MOD. Sorry.
Locked

Return to “[3.0.x] MOD Database Releases”