Mass PM Topic Participants

[Mudjosh]

ok I gotcha. That will work I guess. I don't see a reason regular members need to mass PM anyway.. That is a open gateway to send spam PM..

Thanks for the quick responce! That has to be the fastest one I have recieved on this forum!

And thank you for making this mod.. I would donate to support it but I really can't afford to. I hope you understand.

[joebert]

I'm subscribed to email notifications for replies to this thread, if Im around & it's something I can answer or fix quickly that's what will happen.

[updown]

Since update to 3.0.3, there's seems to be a little issue with an error-message in the pm-form, saying that the form-token was not valid.

Should be something with this line in mcp.php:

Code: Select all

				$_REQUEST['form_token'] = $_POST['form_token'] = sha1($now . $user->data['user_form_salt'] . 'ucp_pm_compose');

Any possible fix for that?

[joebert]

phpBB 3.0.3 made a tiny change in the check_form_key function that makes an elapsed time of zero invalid.

I'll submit a repackaged version of this MOD for review shortly, but in the mean time the fix is literally as simple as adding a few characters to "mcp.php".

Code: Select all

-------------[ OPEN ]------------------------------
mcp.php

-------------[ FIND ]-------------------------------
$now = $_REQUEST['creation_time'] = $_POST['creation_time'] = time()

-------------[ AFTER / ADD ]---------------------
 - 5

-------------[ SAVE / CLOSE ALL FILES ]------

The whole line should now read

Code: Select all

$now = $_REQUEST['creation_time'] = $_POST['creation_time'] = time() - 5;

This fix causes the artificial form token to have a creation date of 5 seconds ago so that when the actual token check is done there's not an elapsed time of zero.

[updown]

Thanks, this works

While you're at it, I made some changes to the SQL:

Code: Select all

			$sql = 'SELECT DISTINCT p.poster_id
					FROM ' . POSTS_TABLE . ' p, ' . USERS_TABLE . ' u
					WHERE p.forum_id = ' . $forum_id . '
					AND u.user_id = p.poster_id
					AND u.user_type <> ' . (int) USER_INACTIVE . '
					AND p.poster_id <> ' . $user->data['user_id'] . '
					AND p.poster_id <> ' . (int) ANONYMOUS . '
					AND p.topic_id = ' . $topic_id;
			$result = $db->sql_query($sql);

• Don't select Anonymous users (e.g. if they have been deleted in the meanwhile)
• Don't select Inactive users (e.g. if they have been deactivated)
• Don't select PM-author directly in the SQL, so you don't need this anymore:

  Code: Select all

  			// Remove author from the recipients
  			if(isset($_REQUEST['address_list']['u'][$user->data['user_id']]))
  			{
  				unset($_REQUEST['address_list']['u'][$user->data['user_id']]);
  			}
  

[joebert]

Don't the PM functions already handle that stuff ?

[updown]

Don't the PM functions already handle that stuff ?

That's a good question that I can't answer at the moment - but if, then only when the PM is sent.

I just found it annoying that there appear "Anonymous" and long-time deactivated users in the PM-recipients, they shouldn't be there at all

[joebert]

I'll take a closer look at it for the next release since this is the first time I've heard about that happening. I'd already had the bug-fix release in the queue.

[updown]

There is also an other thing - Sorry I almost forgot that to mention: For the topic-title, we additionally need htmlspecialchars_decode - some topicnames of my board have quotes in it - for some reason they get "html-nized" to """

Code: Select all

                if ($config['allow_post_links'])
                {
                    $_REQUEST['message'] = $user->lang['TOPIC'] . ": [url=" . generate_board_url() . "/viewtopic.$phpEx?f={$forum_id}&t={$topic_id}]" . htmlspecialchars_decode($row['topic_title']) . "[/url]\n\n";
                }
                else
                {
                    $_REQUEST['message'] = $user->lang['TOPIC'] . ': ' . htmlspecialchars_decode($row['topic_title']) . " (" . generate_board_url() . "/viewtopic.$phpEx?f={$forum_id}&t={$topic_id})\n\n";
                }
                $_REQUEST['subject'] = 'Re: ' . htmlspecialchars_decode($row['topic_title']);
                $_POST['preview'] = true; 

[joebert]

I've decided not to support any of my phpBB mods anymore.

The mod template changes every time I submit an update and frankly, I'm beyond aggrevated with trying to keep up with it.

Sorry folks.

[darkonia]

very n1 mod, works fine for me and my members, thx

[updown]

I've decided not to support any of my phpBB mods anymore.

I'm sorry to hear that - thanks for your existing MODs and for your latest support!

[joebert]

To clarify, I'll still be watching these threads and will be more than happy to provide essential patches in them.

I'm just not going to aggrevate myself with the MOD DB circus anymore. The process NEVER goes smoothly for me.

[moh.elmadany]

phpBB 3.0.3 made a tiny change in the check_form_key function that makes an elapsed time of zero invalid.

I'll submit a repackaged version of this MOD for review shortly, but in the mean time the fix is literally as simple as adding a few characters to "mcp.php".

Code: Select all

-------------[ OPEN ]------------------------------
mcp.php

-------------[ FIND ]-------------------------------
$now = $_REQUEST['creation_time'] = $_POST['creation_time'] = time()

-------------[ AFTER / ADD ]---------------------
 - 5

-------------[ SAVE / CLOSE ALL FILES ]------

The whole line should now read

Code: Select all

$now = $_REQUEST['creation_time'] = $_POST['creation_time'] = time() - 5;

This fix causes the artificial form token to have a creation date of 5 seconds ago so that when the actual token check is done there's not an elapsed time of zero.

done this update

and please .. put this update in new release

Thanks

[joebert]

I don't want to take the time to get aquainted with the new MOD format, I will not be updating the MOD. Sorry.