User Notes/Warnings in Viewtopic

potku · Post by **potku** » Mon Jan 26, 2009 9:46 am

OK, we created another table for olympus_users, and that seems to have taken care of it. I'll come back crying if not...

potku · Post by **potku** » Mon Jan 26, 2009 10:06 am

I do have one question, though.

Does this MOD take into account warnings that have been cancelled? In other words, although the warning count says the user has 1 warning even if the warning has been cancelled (which is a little odd, IMHO), does the MOD realize that if that warning has been cancelled, it shouldn't count that warning toward the maximun set before being banned?

potku · Post by **potku** » Mon Jan 26, 2009 10:46 am

OK, tested that. It doesn't work as I would've wished.

However, this* seems to be a bug with phpBB itself, not this MOD, right? Has this been added to bugtracker or otherwise reported?

*Not being able to cancel warnings effectively

RMcGirr83 · Post by **RMcGirr83** » Mon Jan 26, 2009 11:22 am

How are you "canceling" a warning? The warning count is held in the users table for whichever user. IIRC, there is no phpbb function that allows to delete warnings from users so I am curious as to how you are canceling them.

Also, it is not considered a bug to not be able to delete/cancel a warning.

potku · Post by **potku** » Mon Jan 26, 2009 12:03 pm

Well, I was wondering about that. To cancel a warning I actually just cancelled the notification of it in the Notes section of MCP.

I can see where it's not really a bug in the phpBB system, but with this MOD, if too many false warnings are given to a certain user within a certain time limit, then unfavorable results would occur. Granted, there is not a great chance for this - unless the board is huge with a lot moderators, the warnings stay in effect for a long period of time, and ban follows after, say, only 2 warnings. Mistakes can happen. Of course, the ban can be reversed in a second, but for the user, that might be an awkward experience nonetheless.

On our board, this is far from being a problem. In the last year or so, we have probably given less than 10 warnings to our 3300 or so users.

I like this, thanks

EDIT: typo...

RMcGirr83 · Post by **RMcGirr83** » Mon Jan 26, 2009 1:30 pm

potku wrote:Well, I was wondering about that. To cancel a warning I actually just cancelled the notification of it in the Notes section of MCP.

Nope, won't reduce the number of warnings in the users table which is where the "count" of warnings is kept. User is still warned, just no notification of being warned. Like a "stealth warning".

There is this mod, but it's BETA code...and you know what they say about beta code.

I can see where it's not really a bug in the phpBB system, but with this MOD, if too many false warnings are given to a certain user within a certain time limit, then unfavorable results would occur. Granted, there is not a great chance for this - unless the board is huge with a lot moderators, the warnings stay in effect for a long period of time, and ban follows after, say, only 2 warnings. Mistakes can happen. Of course, the ban can be reversed in a second, but for the user, that might be an awkward experience nonetheless.

On our board, this is far from being a problem. In the last year or so, we have probably given less than 10 warnings to our 3300 or so users.

I'm not really sure what a "false warning" is?

A warning mistake (warned the wrong user)?

A warning is a very serious offense in phpBB and you are either warning someone ("submit") or not (do nothing....go to another page). Setting to not notify the user does not effect (affect? I always get the two bassackwards) the updating of the database when warning a user.

The length that a warning can be set to expire is set in the ACP (default, IIRC is 90 days). It is then that the user warning count is updated.

I like this, thanks

Thank you and please vote on the mod if so inclined.

potku · Post by **potku** » Mon Jan 26, 2009 1:51 pm

Thanks for the link, I'll check it out.

Yeah, false warning, that's my English...

You are right, I meant issuing a warning to the wrong user - but also possibly giving a warning that might be retracted. For example on our board, all the moderators always discuss all disciplinary actions, but still issuing warnings is something that can and should be done promptly and without the approval of anyone else. That's how we do it.

When I learned the two terms in high school, effect and affect, I used to mix them up, too. Then I saw the movie "FX" with Bryan Brown (good movie at the time) and decided I would remember them from that point on. And I do, but I still have to think of that title every time I hear or see the terms

Effect is a noun, affect is a verb.

I voted now...

thecrewstyle · Post by **thecrewstyle** » Tue Jan 27, 2009 7:12 am

Hi ,
I gave a problem when installing this mod

Code: Select all

[phpBB Debug] PHP Notice: in file /includes/functions.php on line 3763: Cannot modify header information - headers already sent by (output started at /language/en/common.php:1)
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 3765: Cannot modify header information - headers already sent by (output started at /language/en/common.php:1)
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 3766: Cannot modify header information - headers already sent by (output started at /language/en/common.php:1)
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 3767: Cannot modify header information - headers already sent by (output started at /language/en/common.php:1)

How i solve this?
Thanks

RMcGirr83 · Post by **RMcGirr83** » Tue Jan 27, 2009 10:53 am

You need to edit that file with a strict text editor that does not insert a BOM (Byte Order Mark). Download notepad++ and use that to modify the files (specifically en/common.php).

thecrewstyle · Post by **thecrewstyle** » Tue Jan 27, 2009 5:49 pm

Thanks, i will try.

potku · Post by **potku** » Sun Feb 22, 2009 5:57 pm

One question: How are both, warnings and notes, hidden from everyone but moderators?

RMcGirr83 · Post by **RMcGirr83** » Sun Feb 22, 2009 10:44 pm

potku wrote:One question: How are both, warnings and notes, hidden from everyone but moderators?

notes should already be hidden and viewable only by mods due to this code that this mod adds

Code: Select all

<!-- IF postrow.U_NOTES -->

U_NOTES is only set if moderator per the code in viewtopic.php

potku · Post by **potku** » Mon Feb 23, 2009 4:13 am

Thanks!

spacefish · Post by **spacefish** » Mon Mar 09, 2009 9:23 pm

Cool mod thanks - but I've got a small problem with the number of usernotes not being updated/shown correctly (user has 1 note, viewtopic profile shows 3). I ran the updater again but there's no change.

RMcGirr83 · Post by **RMcGirr83** » Tue Mar 10, 2009 5:01 pm

The updater will scan the log table for notes that belong to a specific user. If you run it multiple times, you will probably get a false reading as the updater does not reset all users note counts.

I suppose I could make it so that it resets every users note count and then recounts and updates the database based on the Log Table.

To fix the issue in the mean time, access your database via phpmyadmin, go to the users table (usually phpbb_users), find the affected user in the list and edit the number held in the user_notes column.

[EDIT]I have attached a new update_note_count.php file...unzip it, upload into the root of your forum, login to your forum as board founder and browse to it. It will reset all the note counts to zero and then run through the log table and update the note count for each user it finds[/EDIT]

[The extension zip has been deactivated and can no longer be displayed.]

[EDIT#2]The orginal update_note_count posted in this post had a slight bug. The new one fixes that issue.[/EDIT#2]

advertisements