Page 3 of 23

Re: AJAX Quick Edit

Posted: Mon Jun 08, 2009 2:02 pm
by EidolonHades
I find myself using the standard editor more and more on my site just now, when I edit topics there it's usually to submit an update to an attachment, this mod doesn't pull in the attachments. Is there any hope of this mod pulling in the attachments in the quick edit?

Re: AJAX Quick Edit

Posted: Mon Jun 08, 2009 4:08 pm
by Marc
http://www.m-a-styles.de/tracker.php?p=11&t=33

I'll take a look at it for the next version. ;)

Re: AJAX Quick Edit

Posted: Mon Jun 08, 2009 4:18 pm
by Ahri89
I need a spanish buttons, please help u.u

Re: AJAX Quick Edit

Posted: Mon Jun 08, 2009 4:54 pm
by Xplorer4x4
^find the psd files for your style(s) and edit them to your liking then over write the old image.

I dont really like the idea of attachments in the quick edit. Look at IPB and vB. Neither have attachments in quick edit, and personally i think its for the best. Keeps it nice and lean.

Re: AJAX Quick Edit

Posted: Mon Jun 08, 2009 5:01 pm
by Saint_hh
Xplorer4x4 wrote:I dont really like the idea of attachments in the quick edit. Look at IPB and vB. Neither have attachments in quick edit, and personally i think its for the best. Keeps it nice and lean.
I think so too.
It should be a quick edit, in the sense of the name. Manipulating more than text should be done with the standard editor.

Re: AJAX Quick Edit

Posted: Tue Jun 09, 2009 2:17 am
by iamshoaibi
I have it installed. I have 3 themes prosilver, subsilver2 and revolution (based on prosilver).
Problem is it doesn't show up on revolution, but on others it does. Why?
I had this same problem when i install "JavaScript Log out confirmation", and the only solution i found was to manually copy the .js file and the code from prosilver/templates/overall_header to revolution/template/overall_header.html , seems like template inheritance isn't working.

[No, this is not spam, i just faced the exact same issue so paste the text from earlier post]

Re: AJAX Quick Edit

Posted: Tue Jun 09, 2009 4:48 am
by alienbabeltech
not working for me on Aeroblue. I designed my own imageset image using the PSD the theme author provided me.

Here is the image I used Image

And this is what i get

Image

2 edit buttons.

My forum here http://alienbabeltech.com/abt. Refreshed the template in ACP

Clicking the lower edit button does nothing, while the upper takes me to the full edit

Re: AJAX Quick Edit

Posted: Tue Jun 09, 2009 5:33 am
by kida7
This mod still has a bug. When you enter symbol as '+', this return ' ' (space). Example:
You enter in quick edit textarea box

Code: Select all

for(i=0;i<n;i++)
{
...
}
Alfter submit, you'll receive:

Code: Select all

for(i=0;i<n;i  )
{
...
}
'++' => ' ';

Fix: open quickedit.html
FIND:

Code: Select all

contents = contents.replace(/[&]/g,"%26"); 
ADD AFTER:

Code: Select all

contents = contents.replace(/[+]/g,"%2B"); 

Re: AJAX Quick Edit

Posted: Tue Jun 09, 2009 1:14 pm
by Marc
Thanks for the bug report. It will be fixed in the next version.

@alienbabeltech: I don't know how the buttons work in the Aero-styles. I think jrolson mixed subsilver2 with prosilver, so it's probably good if you ask him how to do that.

Re: AJAX Quick Edit

Posted: Tue Jun 09, 2009 4:35 pm
by EidolonHades
marc1706 wrote:http://www.m-a-styles.de/tracker.php?p=11&t=33

I'll take a look at it for the next version. ;)
Great stuff, thank you for looking into it.

Re: AJAX Quick Edit

Posted: Wed Jun 10, 2009 4:03 am
by alienbabeltech
marc1706 wrote: @alienbabeltech: I don't know how the buttons work in the Aero-styles. I think jrolson mixed subsilver2 with prosilver, so it's probably good if you ask him how to do that.
He suggested me to do this
jrolson wrote:In viewtopic_body.html
Find,

Code: Select all

<!-- IF postrow.U_EDIT --><div class="edit-icon"><a href="{postrow.U_EDIT}" title="{L_EDIT_POST}"><span>{L_EDIT_POST}</span></a></div><!-- ENDIF -->
Replace with,

Code: Select all

<!-- IF postrow.U_EDIT --><div class="edit-icon"><a href="{postrow.U_EDIT}" title="{L_EDIT_POST}"><span>{L_EDIT_POST}</span></a></div> <div class="quickedit-icon"><a href="#" id="quick_edit{postrow.POST_ID}" onclick="quick_edit({postrow.POST_ID}); return false;">{QUICKEDIT_IMG}</a></div><!-- ENDIF -->
In stylesheet.css
Find,

Code: Select all

.edit-icon, .edit-icon a			{ background-image: url("{T_IMAGESET_LANG_PATH}/icon_post_edit.png"); }
After add,

Code: Select all

.quickedit-icon, .quickedit-icon a			{ background-image: url("{T_IMAGESET_LANG_PATH}/icon_post_quickedit.png"); }
Find,

Code: Select all

.quote-icon, .quote-icon a, .report-icon, .report-icon a, .warn-icon, .warn-icon a, .edit-icon, .edit-icon a, .delete-icon, .delete-icon a, .info-icon, .info-icon a
In-line after add,

Code: Select all

, .quickedit-icon a
Find,

Code: Select all

.profile-icons div.edit-icon, .review-icons div.edit-icon	{ width: 34px; height: 18px; }
After add,

Code: Select all

.profile-icons div.quickedit-icon, .review-icons div.quickedit-icon	{ width: 74px; height: 18px; }
which I did.

Now, I used a png button as he said
Image

Now the buttons show up correctly
Image

But on clicking the button, it turns to blue but doesn't do anything
Image

Re: AJAX Quick Edit

Posted: Wed Jun 10, 2009 6:20 am
by kida7
New bug: when you enter number after symbol "%",
fix:in quickedit.html add

Code: Select all

contents = contents.replace(/[%]/g,"%25"); 
before

Code: Select all

contents = contents.replace(/[&]/g,"%26"); 

Re: AJAX Quick Edit

Posted: Wed Jun 10, 2009 4:03 pm
by god0fgod
This is very good and I like the bb-code buttons as well. I didn't expect that. But why does the bold bb-code say cancel?
screenshot.png
screenshot.png (105.64 KiB) Viewed 716 times
Smilies would be nice, as well, on the side.

Re: AJAX Quick Edit

Posted: Wed Jun 10, 2009 4:13 pm
by Marc
Good question, I've never seen that. Could you post your quickedit.html?
And no, there won't be smilies. If you want to edit your post and add 500 smilies, you will have to use the normal edit.

Re: AJAX Quick Edit

Posted: Wed Jun 10, 2009 4:35 pm
by god0fgod
Why would that file be any different? And the file on the server is the same as the original.


Edit: It doesn't matter, the problem hasn't re-occurred now I've rechecked. It may have been some odd caching problem? Or maybe a problem with my browser?