mtotheikle wrote:The patch file contained multiple edits to unnecessary files at first, however now I see you have re-uploaded the files. While it contains a few unnecessary files for people such as posting.php which if someone modified and then uploaded this version, it could cause problems on their board.
I am too lazy and maybe too busy, because I posted here complete code, not just information what you should change in my opinion. I am programmer and I use some tools like SVN, Eclipse, DIFF, PATCH and other, but many people on this forum may don't.
So if I find some time (I cannot promise it) I will try to describe what should be changed in which line, because it will be easier for many people.
In mentioned file: 'posting.php' I have made one big difference, added FORM_ID, which is used to fix bug with problems with captcha when you were trying to post new topic on add new post. The problem was that in the captcha code, there was literally written form id 'register', which was valid on register subpage but absolutely wrong on subpage allowing user to add new post. There should be used id 'postform'. I agree that there could be some files, which are not needed, for example:
but these files were not present in proFormell style, which is used in our forum, so I added it to the ZIP for this style. You will not find these files in prosilver style, which we don't use at all (but I also didn't fix files for this style - they are unchanged).
My changes shouldn't cause any problems unless
- you are not using phpbb 3.0.6 (which I am using)
- or you modified these files yourself because of something (ucp_register.php, posting.php, posting_layout.html, login_body.html)
mtotheikle is right that there are some extra files:
which were added but they shouldn't. I remove them from the ZIP file (reuploaded). I am not sure if there are any differences between these files in ZIP and these same files from version 3.0.6 (probably not).
I hope now it will be more clear.