Page 35 of 77

Re: SEO MOD

Posted: Sat Jun 07, 2008 11:18 am
by rwap01
enesbil wrote:hello
i get the following eroor when i want to write an answer:

Code: Select all

Parse error: syntax error, unexpected ')' in /users/xxxx/www/xxxx/posting.php on line 85

Code: Select all

	{
		$redirect = append_sid($phpbb_root_path);
	} 'f=' . $forum_id) : append_sid("{$phpbb_root_path}index.$phpEx")));
	redirect($redirect);
}
line 85:

Code: Select all

	} 'f=' . $forum_id) : append_sid("{$phpbb_root_path}index.$phpEx")));
Alas the problem here is down to your entry of the SEO MOD

- delete

Code: Select all

 'f=' . $forum_id) : append_sid("{$phpbb_root_path}index.$phpEx")));
The line should just have an end curly bracket.
enesbil wrote: and when i wants to see the memberlist:

Code: Select all

Parse error: syntax error, unexpected ']' in /users/xxx/www/xxxxx/memberlist.php on line 844

Code: Select all

				meta_refresh(3, append_sid("{$phpbb_root_path}index.$phpEx"));
				$message = ($user_id) ? sprintf($user->lang['RETURN_INDEX'], '<a href="' . append_sid($phpbb_root_path) . '">', '</a>') : sprintf($user->lang['RETURN_TOPIC'], '<a href="' . format_url($row['topic_title'], "t$topic_id") . '">', '</a>');}&t=$topic_id" . '">', '</a>';
				trigger_error($user->lang['EMAIL_SENT'] . '<br /><br />' . $message);
line 844:

Code: Select all

				$message = ($user_id) ? sprintf($user->lang['RETURN_INDEX'], '<a href="' . append_sid($phpbb_root_path) . '">', '</a>') : sprintf($user->lang['RETURN_TOPIC'], '<a href="' . format_url($row['topic_title'], "t$topic_id") . '">', '</a>');}&t=$topic_id" . '">', '</a>';
please help me
I get line 844:

Code: Select all

                       $message = ($user_id) ? sprintf($user->lang['RETURN_INDEX'], '<a href="' . append_sid($phpbb_root_path) . '">', '</a>') : sprintf($user->lang['RETURN_TOPIC'], '<a href="' . format_url($row['topic_title'], "t$topic_id") . '">', '</a>');
You have some additional characters!

Re: SEO MOD

Posted: Sat Jun 07, 2008 11:19 am
by rwap01
Damien Boyle wrote:Anyone got the print fix? still cant get this sorted.
Having seen your viewtopic.php, this is not a print bug, but how you have implemented the SEO MOD code - I have pm'd you with some errors I have spotted in your code.

Re: SEO MOD

Posted: Sat Jun 07, 2008 1:29 pm
by rwap01
Aexo wrote:
Bawls wrote:Hey all,
I finished up installing this mod. It's working great, however I have one issue. When a topic notification email is received, the link to the topic reply (i.e.: http://specv.net/forum/11may08-updates- ... 1823#p1823) runs into a 404.

Any ideas?
soved? I have this problem and I was waiting for you
The problem here relates to the following lines in viewtopic.php:

Code: Select all

// Redirect to login or to the correct post upon emailed notification links
if (isset($_GET['e']))
{
	$jump_to = request_var('e', 0);

    $redirect_url = format_url($topic_title, "t$topic_id");

	if ($user->data['user_id'] == ANONYMOUS)
	{
		login_box($redirect_url . "&p=$post_id&e=$jump_to",  user->lang['LOGIN_NOTIFY_TOPIC']);
	}

	if ($jump_to > 0)
	{
		// We direct the already logged in user to the correct post...
		redirect($redirect_url . ((!$post_id) ? "&p=$jump_to" : "&p=$post_id") . "#p$jump_to");
	}
}
I wonder if it should read simply:

Code: Select all

// Redirect to login or to the correct post upon emailed notification links
if (isset($_GET['e']))
{
	$jump_to = request_var('e', 0);

    $redirect_url = format_url($topic_title, "t$topic_id");

	if ($user->data['user_id'] == ANONYMOUS)
	{
		login_box($redirect_url . "#p$jump_to", $user->lang['LOGIN_NOTIFY_TOPIC']);
	}

	if ($jump_to > 0)
	{
		// We direct the already logged in user to the correct post...
		redirect($redirect_url . "#p$jump_to");
	}
}
That certainly works here - but is it always the case?

Re: SEO MOD

Posted: Sat Jun 07, 2008 3:44 pm
by Tob76
I am wondering if someone now could help me, I am still waiting for some support on my problems, see http://www.phpbb.com/community/viewtopi ... 5#p5706085

Re: SEO MOD

Posted: Sat Jun 07, 2008 9:02 pm
by XToF.be
I installed a MOD that allows me to implement BBCode into the wordcensor. When a word is censored in a topic title, the SEO MOD takes the HTML code of the BBCode litterally:
A topic with topic title:

Test topic title becomes:

Code: Select all

http://www.mydomain.com/%3Cspan-style=%CA%B9%CA%B9font-style-italic%CA%B9%CA%B9%3Etest-topic-title%3C-span%3E-t448.html#p1651
This also affects my quick reply and topic reply notification via email.

Raimon helped me sorting this out and the cause of the issue would be due to the replacement in includes/functions_seo.php that takes over the HTML code:

Code: Select all

function clean_url($url)
{
    $url = trim(str_replace(array('Re:', 're:'), '', $url));
    $find = array('?', '#', '%', '?', '^', '.', '/', ' ', '_', ')', '(', '[', ']', ':', '.');
    $url = str_replace($find, '-', censor_text($url));
    $url = str_replace(array('---', '--'), '-', $url);

    return utf8_clean_string($url);
} 
Does somebody know how to fix this issue?

Re: SEO MOD

Posted: Sun Jun 08, 2008 1:36 am
by zenskd
Hello,

For some reason when I try to search in the topic it displays unrelated things (showing other topics) =/ so here is my question

I'm having a silly problem: the pagination when there is more than one page extension is showing .php when it should be .html, this is driving me a bit crazy since the forum is active. I revised viewforum.php and made sure everything was as it should but no luck.

Any possible file canditates to check?

Example:
http://www.phpbb.com/community/viewtopi ... 3&start=15
expected to be
http://www.phpbb.com/community/topicbla ... 53s15.html
but it gives me
http://www.phpbb.com/community/topicbla ... 153s15.php

Re: SEO MOD

Posted: Sun Jun 08, 2008 11:27 am
by kissp
I need this thread !

Re: SEO MOD

Posted: Sun Jun 08, 2008 12:55 pm
by alexisfr
flipper242 wrote:my solution for the pagination bug in rc4:

viewforum.php near line 640
find:
'U_LAST_POST' => $view_topic_url . '&p=' . $row['topic_last_post_id'] . '#p' . $row['topic_last_post_id'],

Replace:
'U_LAST_POST' => $view_topic_url . '#p' . $row['topic_last_post_id'],

functions_seo.php near line 290
find:
$append = '.' . $phpEx;



replace
$append = '.html';

my Mark all forums read bug solution
http://www.phpbb.com/community/viewtopi ... 0#p3251600


if there are major bugs in my solution please let me know about

I do not think this is an appropriate solution. This just sends a post id, which triggers a fallback strategy that points the user to the first post of a topic, not the actual post.

In viewtopic.php, you will find this fallback strategy after this comment

Code: Select all

// If post_id was submitted, we try at least to display the topic as a last resort...
Anyone with a better solution?

Re: SEO MOD

Posted: Sun Jun 08, 2008 8:43 pm
by rwap01
alexisfr wrote: I do not think this is an appropriate solution. This just sends a post id, which triggers a fallback strategy that points the user to the first post of a topic, not the actual post.

In viewtopic.php, you will find this fallback strategy after this comment

Code: Select all

// If post_id was submitted, we try at least to display the topic as a last resort...
Anyone with a better solution?
Do you mean the pageination bug listed in my overview essential fixes or is this a different one?
http://www.phpbb.com/community/viewtopi ... 5#p5716395

This forum is so hard to follow because :
a) view people include links to their earlier posts about the same issue
b) many people list the same issue, even when a fix has already been listed.
c) the "search this forum" does not stick to this topic!!

Re: SEO MOD

Posted: Sun Jun 08, 2008 8:45 pm
by rwap01
tobsnyder wrote:I am wondering if someone now could help me, I am still waiting for some support on my problems, see http://www.phpbb.com/community/viewtopi ... 5#p5706085
Well I have fixed the link on the email notification (although it needs others to test it).
See the essential fixes:

http://www.phpbb.com/community/viewtopi ... 5#p5716395

I think the issue about redirection when you log in having been watching as a guest equally applies here, but I don't have time to look at this at the moment.

Where is the MOD author when you need him and how do we get these essential fixes implemented in the actual release?

Re: SEO MOD

Posted: Sun Jun 08, 2008 11:47 pm
by alexisfr
rwap01 wrote: Do you mean the pageination bug listed in my overview essential fixes or is this a different one?
http://www.phpbb.com/community/viewtopi ... 5#p5716395
It is a different one as I already have your correction in my code. On the page listing the topics of one of your forums, when a topic contains several pages of messages, does the quick link to the last message of the topic actually point to the last message or not?

By the way, for your bug fixes round up, I had a fixes to a pagination issue when vieving a topic:
http://www.phpbb.com/community/viewtopi ... 5#p5274095

Thanks for your contribution! This MOD has so many issues and no continued improvement that it is a real pain to use. I just do not understand why it is not sent back to the sandbox.

Re: SEO MOD

Posted: Sun Jun 08, 2008 11:54 pm
by Johnmcl7
Hey folks, I seem to have fallen at the first hurdle - a few people have mentioned this issue but I've not seen how to resolve or I'm possibly missing something obvious.

I've made all the changes but I get a 'board does not exist' when I try to open any forum section, the main list of forums does come up ok. I did the test at the start for the mod_rewrite and I did get a specific topic does not exist error rather than an error 404 or error 500 which as far as I can tell means the mod rewrite is working. I don't get any of these errors (404,500), just the error within the forum and two other mod_rewrite tests also point to it working.

My apologies if someone has posted a solution, I've crawled through 35 pages and have tried to find a solution.

Thanks,
John

Re: SEO MOD

Posted: Mon Jun 09, 2008 7:05 am
by Tob76
rwap01 wrote:
tobsnyder wrote:I am wondering if someone now could help me, I am still waiting for some support on my problems, see http://www.phpbb.com/community/viewtopi ... 5#p5706085
Well I have fixed the link on the email notification (although it needs others to test it).
See the essential fixes:

http://www.phpbb.com/community/viewtopi ... 5#p5716395

I think the issue about redirection when you log in having been watching as a guest equally applies here, but I don't have time to look at this at the moment.

Where is the MOD author when you need him and how do we get these essential fixes implemented in the actual release?
Thanks for your help, but unfortunately this did not work for me. In the E-Mail Notifications there I get a link like http://www.miniero.com/viewtopic.php?f= ... 12&e=38412 and this is being redirected to http://www.miniero.com/news-via-legt-mi ... t6901.html - so I am wondering that your fix does not take effect..probably there is also an error somewhere else..

What we can do, if the author is not going to answer anyway, is to take to mo and implement the bugfixxes ourselves and post this as SEO Mod *updated* hoping some Moderators will add it to the official MOD Database instead of the original one...I mean, there are at least 4-5 Bugs we have fixxed here in this thread, so it would definitly make sense to implement that stuff...


EDIT: Concerning the E-Mail Notification, for me it seems the viewtopic.php does not take effect, because I ca nedit whatever I want in there (what is related to redirects), but nothing takes effect...its everytime the same problem..

Re: SEO MOD

Posted: Mon Jun 09, 2008 7:30 am
by rwap01
tobsnyder wrote: Thanks for your help, but unfortunately this did not work for me. In the E-Mail Notifications there I get a link like http://www.miniero.com/viewtopic.php?f= ... 12&e=38412 and this is being redirected to http://www.miniero.com/news-via-legt-mi ... t6901.html - so I am wondering that your fix does not take effect..probably there is also an error somewhere else..

What we can do, if the author is not going to answer anyway, is to take to mo and implement the bugfixxes ourselves and post this as SEO Mod *updated* hoping some Moderators will add it to the official MOD Database instead of the original one...I mean, there are at least 4-5 Bugs we have fixxed here in this thread, so it would definitly make sense to implement that stuff...


EDIT: Concerning the E-Mail Notification, for me it seems the viewtopic.php does not take effect, because I ca nedit whatever I want in there (what is related to redirects), but nothing takes effect...its everytime the same problem..
It sounds as though there is an issue with yout viewtopic.php somehow - if you don't have any other mods installed and are using v3.0.1 of phpBB, I can email you a copy of my file and you can see if this resolves the issue

Re: SEO MOD

Posted: Mon Jun 09, 2008 8:17 am
by Tob76
this would be great, probably it would be the best if you can send me all needed files for the seo mod, because I guess the error is somewhere else instead of the viewtopic.php