Page 10 of 12

Re: Manage attachments ACP module for phpBB3

Posted: Thu Dec 11, 2008 2:17 am
by rocko2
I am running 3.0.3 and it works and its awesome :D
Good work!

Re: Manage attachments ACP module for phpBB3

Posted: Fri Jan 09, 2009 7:08 am
by ximpdbydefault
This is a great mod, very resourceful however I have a glitch somewhere. When managing attachments and sorting through post ID and ascending it works flawless on the first 4 pages but when I get to the 5th page it gives this error:

Code: Select all

General Error
SQL ERROR [ mysql4 ]

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 3 [1064]

SQL

SELECT forum_id, auth_option_id, auth_role_id, auth_setting FROM phpbb_acl_users WHERE user_id = 

BACKTRACE


FILE: includes/db/mysql.php
LINE: 174
CALL: dbal_mysql->sql_error()

FILE: includes/auth.php
LINE: 810
CALL: dbal_mysql->sql_query()

FILE: includes/auth.php
LINE: 382
CALL: auth->acl_raw_data_single_user()

FILE: includes/auth.php
LINE: 71
CALL: auth->acl_cache()

FILE: includes/functions_content.php
LINE: 1209
CALL: auth->acl()

FILE: includes/acp/acp_manage_attachments.php
LINE: 318
CALL: get_username_string()

FILE: includes/functions_module.php
LINE: 507
CALL: acp_manage_attachments->main()

FILE: adm/index.php
LINE: 74
CALL: p_master->load_active()
if you skip over page 5 and go to 6&7 no errors 8&9 have this error, so do 11, 12, 15, 18, 19, 20 This is all I could get before the dodded lines as I have close to 1000 attachments.

Any ideas I can try to get this going?

Re: Manage attachments ACP module for phpBB3

Posted: Sat Jan 10, 2009 3:45 am
by ximpdbydefault
anyone?

Re: Manage attachments ACP module for phpBB3

Posted: Sat Jan 10, 2009 4:19 am
by rxu
As per the error's backtrace, the problem is in get_username_string() call.
What version of phpBB3 do you have with this error? Does this error appear in any other attachments sorting mode?

Re: Manage attachments ACP module for phpBB3

Posted: Sat Jan 10, 2009 4:34 am
by ximpdbydefault
rxu wrote:As per the error's backtrace, the problem is in get_username_string() call.
What version of phpBB3 do you have with this error? Does this error appear in any other attachments sorting mode?
3.0.4

Yes Extensions> assending= all pages except for the first
Yes File Date> Decending= pg 14 (Maybe more)
Yes Filename> Decending= very first page after submission of sorting.

Need more?
I have 114 pages and 26 other modules installed

Re: Manage attachments ACP module for phpBB3

Posted: Sat Jan 10, 2009 6:20 am
by rxu
Could you try the last version of includes/functions_content.php from SVN (http://code.phpbb.com/repositories/entr ... format=raw)? But backup your current version first, if you do. Thanks.

Re: Manage attachments ACP module for phpBB3

Posted: Sat Jan 10, 2009 7:52 am
by ximpdbydefault
Ok, I cannot reproduce any errors now. I have tried different methods/assortments and the origional error will not duplicate, with that, THANKS.
One at I time I will look through my modules xml and find what needs to me modified for that paticular file and check back to the acp to see if it duplicates. Is this the true 3.0.4 file?

Thanks

Re: Manage attachments ACP module for phpBB3

Posted: Sat Jan 10, 2009 7:58 am
by rxu
Fine.
Nope. That version of the file is 3.0.5-dev, and there were some changes/bugfixes in function get_username_string. You can try just to replace the code of get_username_string function in your file (that was causing errors) with the corresponding code of get_username_string function from the file you've downloaded for testing.

Re: Manage attachments ACP module for phpBB3

Posted: Sat Jan 10, 2009 8:24 am
by ximpdbydefault
Well, I started remodding the new and this mod is conflicting with the IGN Style Username Color Mod.

Here is the context of the origional functions_content.php-
http://www.interfacehosting.com/phpbb3.htm

here are the edits for the IGN Style Username Color Mod-
http://www.interfacehosting.com/edits.htm

Would you mind too teribly to see if you see anything out of alignment?

Re: Manage attachments ACP module for phpBB3

Posted: Sat Jan 10, 2009 8:39 am
by rxu
I've took a look on this, and I still think this problem is related with the get_username_string function is being used in 3.0.4. Manage attachments ACP module for phpBB3 MOD uses standard call of get_username_string, nothing unusual (like viewtopic.php does, etc.). Hence, if the IGN Style Username Color Mod doesn't corrupt the function, Manage attachments ACP module for phpBB3 MOD has to be workable with it.
So I'd better try to use 3.0.5-dev version modified in according to the installation instructions of the MODs you're using (particular the IGN Style Username Color Mod) if any.

Re: Manage attachments ACP module for phpBB3

Posted: Sat Jan 10, 2009 8:47 am
by ximpdbydefault
Thats what I did to the 3.0.5 dev was modifying it with the IGN Style Username Color Mod. After saving it, I went back to the ACP and ran your mod and thats when it started giving me the errors again. Unedited the changes and it worked just fine...

Re: Manage attachments ACP module for phpBB3

Posted: Sat Jan 10, 2009 9:03 am
by rxu
Hmm... ok. Can you give me your v.3.0.4 MODded functions_content.php file (for testing)?

Re: Manage attachments ACP module for phpBB3

Posted: Sat Jan 10, 2009 9:14 am
by ximpdbydefault
it was in text format at the above link, but here is a .rar of it:
http://www.InterfaceHosting.com/functions_content.rar

Re: Manage attachments ACP module for phpBB3

Posted: Sat Jan 10, 2009 10:39 am
by rxu
That's weird. I've just installed both of the MODs on my local test board and performed some tests with Manage attachments ACP module sorting options, but couldn't reproduce the bug. The test board has only a couple tens of attachments though.

Re: Manage attachments ACP module for phpBB3

Posted: Sat Jan 10, 2009 10:45 am
by ximpdbydefault
Ok, I will mirror my board later today and creat you a admin for it as well as ftp access and send you the logins for it through pm here.
You dont have that many attachments to get the error..... did you do Filename> Decending>submit?
I will pm you later today....