View or mark unread posts

All new MODs released in our MOD Database will be announced in here. All support for released MODs needs to take place in the Customisations Database.
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

NOTICE: This forum is only for the announcement of new releases and/or updates of MODs. Any MOD support should be obtained through the Customisations Database in the support area designated for each MOD.

A direct link to support for each MOD is in the first post of the respective topic.
v8power
Registered User
Posts: 8
Joined: Fri Feb 22, 2008 2:49 am

Re: View or mark unread posts

Post by v8power » Wed Feb 27, 2008 5:01 pm

Alan,

I just installed and had a bad function call in common.php:

Code: Select all

$s_exists_unreads = check_unread_posts();
Removing the code will still let me see the index page, and the template add that I manually did to my own templates work just fine. Of course the link now reads "You have no unread posts" because I removed the code in common.php to view the index page. But, when I click it I then get another function undefined unread_list_sql() in search.php

Any problems with this code with anyone else so far? Did I happen to miss something? All caches have been reloaded.

asinshesq
Registered User
Posts: 6266
Joined: Sun Feb 22, 2004 9:34 pm
Location: NYC
Name: Alan

Re: View or mark unread posts

Post by asinshesq » Wed Feb 27, 2008 5:27 pm

v8power wrote:Alan,

I just installed and had a bad function call in common.php:

Code: Select all

$s_exists_unreads = check_unread_posts();
Removing the code will still let me see the index page, and the template add that I manually did to my own templates work just fine. Of course the link now reads "You have no unread posts" because I removed the code in common.php to view the index page. But, when I click it I then get another function undefined unread_list_sql() in search.php

Any problems with this code with anyone else so far? Did I happen to miss something? All caches have been reloaded.
Sounds like maybe you didn't make the change the mod calls for in common.php (the one that requires inclusion of that file)?
Last edited by asinshesq on Wed Feb 27, 2008 5:54 pm, edited 1 time in total.

v8power
Registered User
Posts: 8
Joined: Fri Feb 22, 2008 2:49 am

Re: View or mark unread posts

Post by v8power » Wed Feb 27, 2008 5:49 pm

Alan, thanks for a great script. I uploaded the commom.php, re-edited functions.php and uploaded again and all is well. I am not quite sure where the mistake was. I think I did not re-upload the common.php file. Just some cosmetic changes for me and all is well. Thanks! :P

Forke
Registered User
Posts: 102
Joined: Fri Feb 08, 2008 6:03 am

Re: View or mark unread posts

Post by Forke » Wed Feb 27, 2008 8:04 pm

asinshesq wrote: Thanks for letting me know you like it (that feedback is much appreciated). I'm curious, though, about why this mod turns out to be so useful for your board (since to me it seem somewhat useful but not earthshattering):

- Is it mostly the ability to get a simple list of unreads? Or do you also find the ability to mark a post unread useful? (The list was easy to code but the part allowing you to mark posts unread was pretty tough.)

- Does the part that allows you to see unread pms in their own folder (and mark pms unread) matter much to you?
Well, this mod is very useful for my board because 90% of my users use it. I've changed from a 2.0 phpbb to a 3.0, and everyone asked for this functionality from the start. It makes my users happy! :lol:

The ability they appreciate the most is the simple list of unreads. I don't really know if the use the mark unread feature, but it think it is still very useful.

The PM part doesn't really matter for me.

Thanks again!
My first validated mod!
Adaptive Quick Search

asinshesq
Registered User
Posts: 6266
Joined: Sun Feb 22, 2004 9:34 pm
Location: NYC
Name: Alan

Re: View or mark unread posts

Post by asinshesq » Wed Feb 27, 2008 8:15 pm

Forke wrote:The ability they appreciate the most is the simple list of unreads.
Did you end up getting rid of the regular "View new posts" link (as discussed in paragraph (4) of the author's notses)? Or do you find it is useful to have both links and not too confusing for your users?

ostkamp
Registered User
Posts: 1
Joined: Wed Feb 27, 2008 9:43 pm

Re: View or mark unread posts

Post by ostkamp » Wed Feb 27, 2008 9:58 pm

Hi,

I think I've found a typo in this mod: In install.xml there is a line

Code: Select all

IN-LINE ERPLACE WITH
I believe this should read REPLACE shouldn't it?

Best regards

Guido

asinshesq
Registered User
Posts: 6266
Joined: Sun Feb 22, 2004 9:34 pm
Location: NYC
Name: Alan

Re: View or mark unread posts

Post by asinshesq » Wed Feb 27, 2008 10:04 pm

ostkamp wrote:I think I've found a typo in this mod: In install.xml there is a line

Code: Select all

IN-LINE ERPLACE WITH
I believe this should read REPLACE shouldn't it?
Yes, you are correct. That is not in the mod itself - it wouldn't have passed validation if it were. But it is in the author's notes comments (author note (4)), and you are right that it is a typo. Thanks for pointing it out...I'll fix that if and when I do another version.

Forke
Registered User
Posts: 102
Joined: Fri Feb 08, 2008 6:03 am

Re: View or mark unread posts

Post by Forke » Thu Feb 28, 2008 3:01 am

asinshesq wrote:
Forke wrote:The ability they appreciate the most is the simple list of unreads.
Did you end up getting rid of the regular "View new posts" link (as discussed in paragraph (4) of the author's notses)? Or do you find it is useful to have both links and not too confusing for your users?
Yes, I did. In fact, I deleted many of other links. I just left your mod, "view your posts" and "Mark all forums read".

Having both links would have been definitely confusing for my users. Hell, it would have been confusing for me! :lol:
My first validated mod!
Adaptive Quick Search

Forke
Registered User
Posts: 102
Joined: Fri Feb 08, 2008 6:03 am

Re: View or mark unread posts

Post by Forke » Thu Feb 28, 2008 5:11 pm

I have a feature request. If its possible, I'd be great.

Is there a way to indicate the number of unread posts in the unread post link? I mean, something like "View unread posts (14)", in which 14 is the number of unread posts the user has.

I'd love that!
My first validated mod!
Adaptive Quick Search

asinshesq
Registered User
Posts: 6266
Joined: Sun Feb 22, 2004 9:34 pm
Location: NYC
Name: Alan

Re: View or mark unread posts

Post by asinshesq » Thu Feb 28, 2008 5:26 pm

Forke wrote:Is there a way to indicate the number of unread posts in the unread post link? I mean, something like "View unread posts (14)", in which 14 is the number of unread posts the user has.
That would involve a re-write of the function check_unread_posts() that appears in functions_view_or_mark_unread_posts.php
The current code is from phpbb3's core code in functions_display(). It is quite efficient and will not weigh down a board. If you change the code to count topics that have unread posts in them, that will begin to weigh down large boards (and may confuse people because the number of topics with unread posts is different from the number of unread posts). And if you change the code to count unread posts (rather than just topics that have unread posts), I suspect that will substantially weigh down boards (perhaps enough to be noticeable on boards that aren't that big). I don't think the overhead is worth it, and as a result I don't plan to add that feature.

However, anyone who wants to write the code is free to do that and post it here for people to try (I don't think it would be that hard if you know your way around php and mysql).

Forke
Registered User
Posts: 102
Joined: Fri Feb 08, 2008 6:03 am

Re: View or mark unread posts

Post by Forke » Thu Feb 28, 2008 5:45 pm

Oh! Ok, i see your point.

Thanks for the response.
My first validated mod!
Adaptive Quick Search

User avatar
Renodil
Registered User
Posts: 668
Joined: Mon Nov 14, 2005 8:48 am
Contact:

Re: View or mark unread posts

Post by Renodil » Thu Feb 28, 2008 7:33 pm

asinshesq wrote:
Renodil wrote:Would the New post count on index by christian be interfering?
No idea. What's the post count on index mod and where is it? There is no user named 'christian' on phpbb.com.

[edit: I just found the mod you are talking about. There is no conflict, but they both change the same line in index_body.html so I am guessing you made those changes wrong. Please check your edits again. Also, please consider whether your users will be totally confused by a link for new posts with a number and another link for unread posts...see paragraph (4) of the author's notes for details.]
Never mind. I'll just stick with the one I got.

sovietpop
Registered User
Posts: 14
Joined: Fri Nov 16, 2007 5:15 pm

Re: View or mark unread posts

Post by sovietpop » Sat Mar 01, 2008 5:36 pm

Hello, I am getting an error message when I try and check pms
"
Parse error: syntax error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home/.mykah/aaocarroll/misspeltCAT/includes/ucp/ucp_pm_viewfolder.php on line 216"

I've checked the viewfolder.php file and I can't see what I might have done wrong; could it be that I've a mistake in one of the other files? and if you think that might bet the case, where would I look for the error first.

HySpeed
Registered User
Posts: 9
Joined: Mon Dec 08, 2003 9:25 pm

Re: View or mark unread posts

Post by HySpeed » Sat Mar 01, 2008 7:15 pm

I have had several of my members ask about this feature, so I plan to install your mod.
However, I don't have a need for the 'mark unread', and we use a modified / custom style, so I'll have to make the visual edits myself.

Do you have a collection of just the 'unread posts' changes so I can focus on those?

Thanks

User avatar
manchumahara
Registered User
Posts: 65
Joined: Sun Jul 15, 2007 2:07 pm
Location: Bangladesh
Contact:

Re: View or mark unread posts

Post by manchumahara » Sat Mar 01, 2008 7:43 pm

sovietpop wrote:Hello, I am getting an error message when I try and check pms
"
Parse error: syntax error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home/.mykah/aaocarroll/misspeltCAT/includes/ucp/ucp_pm_viewfolder.php on line 216"

I've checked the viewfolder.php file and I can't see what I might have done wrong; could it be that I've a mistake in one of the other files? and if you think that might bet the case, where would I look for the error first.
Find this line

Code: Select all

	'FOLDER_ID'			=> $folder_id,
Now replace with this line

Code: Select all

	'FOLDER_ID'			=> $row['folder_id'] ,
In mod this line is as

Code: Select all

" . $row['folder_id'] . "
but I think the double qoute and concate sign is not needed here.

Locked

Return to “[3.0.x] MOD Database Releases”