[RC] Prime Notify - Put the message in notification emails

A place for MOD Authors to post and receive feedback on MODs still in development. No MODs within this forum should be used within a live environment!
Ideas Centre
User avatar
primehalo
Former Team Member
Posts: 2833
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [RC] Prime Notify - Put the message in notification emails

Post by primehalo » Thu Aug 28, 2008 1:19 am

Yep, you're right.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

User avatar
DragonMaster1
Registered User
Posts: 994
Joined: Tue Aug 17, 2004 11:04 am
Name: Terry
Contact:

Re: [RC] Prime Notify - Put the message in notification emails

Post by DragonMaster1 » Thu Aug 28, 2008 12:14 pm

I add that and then I started getting this whenever a topic was opened:

Parse error: syntax error, unexpected T_VARIABLE in /home/ronnieja/public_html/RJD/includes/functions_posting.php on line 1211

I had to revert back and it worked fine then

User avatar
primehalo
Former Team Member
Posts: 2833
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [RC] Prime Notify - Put the message in notification emails

Post by primehalo » Thu Aug 28, 2008 8:22 pm

Then you're probably not using the latest version. For version 1.0.3, the setup_post_template() function takes two parameters.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

mtrs
Registered User
Posts: 2049
Joined: Sat Sep 22, 2007 2:39 pm

Re: [RC] Prime Notify - Put the message in notification emails

Post by mtrs » Thu Aug 28, 2008 8:31 pm

primehalo wrote:Note: This MOD combines the functionality of two of my other MODs, Prime Notify Topic and Prime Notify PM, so if you have those installed, please remove them before installing this one. Those two MODs will be discontinued in favor of this one.
As I notice from Londonvasion videos, the next phpbb3.x.0 version will have option of pm message add to notify mails. As far as I guess, in long term, your combined your two mods in one mod as here, might be separated again. I just wanted to comment on..
I abandoned all of my mods.

User avatar
DragonMaster1
Registered User
Posts: 994
Joined: Tue Aug 17, 2004 11:04 am
Name: Terry
Contact:

Re: [RC] Prime Notify - Put the message in notification emails

Post by DragonMaster1 » Thu Aug 28, 2008 9:47 pm

DragonMaster1 wrote:I add that and then I started getting this whenever a topic was opened:

Parse error: syntax error, unexpected T_VARIABLE in /home/ronnieja/public_html/RJD/includes/functions_posting.php on line 1211

I had to revert back and it worked fine then

No....this my install test:


Title:
Prime Notify

Description:
Inserts the content of a post or private messages into the notification e-mail.

Version:
1.0.3

User avatar
primehalo
Former Team Member
Posts: 2833
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [RC] Prime Notify - Put the message in notification emails

Post by primehalo » Thu Aug 28, 2008 10:23 pm

mtrs wrote:
primehalo wrote:Note: This MOD combines the functionality of two of my other MODs, Prime Notify Topic and Prime Notify PM, so if you have those installed, please remove them before installing this one. Those two MODs will be discontinued in favor of this one.
As I notice from Londonvasion videos, the next phpbb3.x.0 version will have option of pm message add to notify mails. As far as I guess, in long term, your combined your two mods in one mod as here, might be separated again. I just wanted to comment on..
I'm looking forward to the new features, but I wouldn't really consider this circumstance as splitting, more like either deleting or altering. If the added functionality is the way I like it, then I'll just remove the PM notification code from the MOD. Otherwise, I'll modify the code to give the options that I want for PM notifications.
DragonMaster1 wrote:
DragonMaster1 wrote:I add that and then I started getting this whenever a topic was opened:

Parse error: syntax error, unexpected T_VARIABLE in /home/ronnieja/public_html/RJD/includes/functions_posting.php on line 1211

I had to revert back and it worked fine then

No....this my install test:


Title:
Prime Notify

Description:
Inserts the content of a post or private messages into the notification e-mail.

Version:
1.0.3
For version 1.0.3, if you look inside includes/prime_notify.php on line 159 you'll see the setup_post_template() function requires two parameters:

Code: Select all

        function setup_post_template(&$notify_row, &$row) 
Thus, all calls to this function in includes/functions_posting.php must have two parameters passed in:

Code: Select all

$prime_notify->setup_post_template($notify_rows[$row['user_id']], $row); 
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

ktcox67
Registered User
Posts: 11
Joined: Fri Aug 29, 2008 8:48 pm

Re: [RC] Prime Notify - Put the message in notification emails

Post by ktcox67 » Fri Aug 29, 2008 8:58 pm

Hello,

I have implemented the code outlined in the install file and I changed the option 'PRIME_NOTIFY_ALWAYS' to true in the prime_notify.php. When I went to post I noticed the following error for each reply in the message:

192.168.53.132] [File posting.php?mode=reply&f=5&t=69] PHP Notice: in file /export/apache/www/phpBB3/includes/prime_notify.php on line 159 : Missing argument 2 for prime_notify::setup_post_template(), called in /includes/functions_posting.php on line 1212 and defined

Any thoughts would be appreciated.

Thanks!

User avatar
primehalo
Former Team Member
Posts: 2833
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [RC] Prime Notify - Put the message in notification emails

Post by primehalo » Fri Aug 29, 2008 9:49 pm

Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

ktcox67
Registered User
Posts: 11
Joined: Fri Aug 29, 2008 8:48 pm

Re: [RC] Prime Notify - Put the message in notification emails

Post by ktcox67 » Fri Aug 29, 2008 10:38 pm

Thanks for the reply,

I actually followed that post and was able to fix it. I now have the problem that no one is receiving emails. it started yesterday. This email system seems to work when it feels like it. Do you have any thoughts on that can of worms?

User avatar
primehalo
Former Team Member
Posts: 2833
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [RC] Prime Notify - Put the message in notification emails

Post by primehalo » Fri Aug 29, 2008 10:54 pm

I'm not sure what would cause that.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

ktcox67
Registered User
Posts: 11
Joined: Fri Aug 29, 2008 8:48 pm

Re: [RC] Prime Notify - Put the message in notification emails

Post by ktcox67 » Sun Aug 31, 2008 2:09 am

The notify started working today and when I received a notification with the hack installed the output wasn't quite right:

Topic: another increase to file size max on caGrid wiki
Author:
Message:

The Author and the message are missing from the email. I am double checking the modified files.

Thanks, Todd

ktcox67
Registered User
Posts: 11
Joined: Fri Aug 29, 2008 8:48 pm

Re: [RC] Prime Notify - Put the message in notification emails

Post by ktcox67 » Thu Sep 04, 2008 4:23 pm

I have been receiving odd results with using prime_notify. About 50% of the time the author and message is not included in the email. It will just contain the title. Here is an example email from this morning:

BEGIN:

Hello tcox, the forum "General Discussions" at "caBIG-KC.nci.nih.gov - caGrid" has received a new reply since your last visit. You can view the forum by clicking on the following link:
https://cabig-kc.nci.nih.gov/CaGrid/for ... um.php?f=9
_____________________________________________________________________

Topic: Email notification feature testing
Author:
Message:
_____________________________________________________________________

If you no longer wish to watch this forum, either click the "Unsubscribe forum" link found in the forum above, or click the following link:
https://cabig-kc.nci.nih.gov/CaGrid/for ... atch=forum
--
Thanks, The Management

END

Has anyone experienced this issue and if so what should I look for?

Thanks,

TCox

User avatar
IPB_Refugee
Registered User
Posts: 1290
Joined: Fri Jul 07, 2006 2:25 pm
Location: Austria
Name: Wolfgang Weber

Re: [RC] Prime Notify - Put the message in notification emails

Post by IPB_Refugee » Thu Sep 04, 2008 5:14 pm

Yes, I have experienced the issue once but unfortunately I can't remember the circumstances. Sorry. I'll keep my eyes open.

ktcox67
Registered User
Posts: 11
Joined: Fri Aug 29, 2008 8:48 pm

Prime_Notify Not Emailing all of the information

Post by ktcox67 » Tue Sep 09, 2008 3:14 pm

I am currently using prime_notify to include the posts in the email message. The notification is sent but about 50% of the time the author and message are not included, only the title. I am looking for any troubleshooting tips or experiences of other users of this MOD. The version of the MOD 1.0.3.

Thanks in advance,

T. Cox
Last edited by thecoalman on Tue Sep 09, 2008 4:00 pm, edited 1 time in total.
Reason: Merged from single post, pleas post all support requests for a mod to the original topic.

User avatar
primehalo
Former Team Member
Posts: 2833
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [RC] Prime Notify - Put the message in notification emails

Post by primehalo » Tue Sep 09, 2008 5:59 pm

I know this has been reported, but I have not been able to reproduce it. If someone could find the conditions for which this happens, it would go a long way to helping me find the root cause. Do you all have other MODs installed that might be conflicting in some way?
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

Locked

Return to “[3.0.x] MODs in Development”