[RC] Thanks for post by Палыч

A place for MOD Authors to post and receive feedback on MODs still in development. No MODs within this forum should be used within a live environment!
Ideas Centre
User avatar
knmt
Registered User
Posts: 110
Joined: Fri Aug 29, 2008 10:13 am
Contact:

Re: [RC] Thanks for post by Палыч

Post by knmt » Sun May 24, 2009 3:16 am

Hi! This mod is great, however there are some serious bugs that need fixing immediately!

Firstly, I can still thank myself easily if I copy a "thanks" URL and change the to_id to my user id.
Secondly, even if a "thanks" fails, you still allow it to send PM to notify users.
Thirdly, if I thank a user, then copy the URL and apply that URL again ( or refresh - F5 ), the script will throw a duplicate SQL error.
Fourthly, I can also make a "thanks" URL and apply it to an unthankable forum and it will still work.
Well, the last one I found is in thanklist.php, it is not a bug but I think we should make it work the way search.php works, bbcode parsing, etc.

There are some grammatical error in your language files also.

Anyway, hope this helps!

User avatar
Палыч
Translator
Posts: 1543
Joined: Sun Jul 01, 2007 7:59 pm
Location: St. Petersburg
Name: Сергей
Contact:

Re: [RC] Thanks for post by Палыч

Post by Палыч » Sun May 24, 2009 12:58 pm

Thank you! These errors are already corrected. Validation runs version 1.2.2
thanks_mod_v122.zip
Sorry for my bad english

zach'
Registered User
Posts: 44
Joined: Sat Nov 01, 2008 2:07 pm

Re: [RC] Thanks for post by Палыч

Post by zach' » Mon May 25, 2009 5:13 pm

Палыч wrote:Thank you! These errors are already corrected. Validation runs version 1.2.2
thanks_mod_v122.zip
Hi

Thanks for this great mod Палыч, it works fine :D

Here this is my French Translation for language files :

root/language/fr/mods/thanks_mod.php

Code: Select all

<?php
/**
*
* thanks_mod[English]
*
* @package language
* @version $Id: thanks.php,v 122 2009-04-19 10:02:51Палыч $
* @copyright (c) 2008 phpBB Group
* @license http://opensource.org/licenses/gpl-license.php GNU Public License
*
*/

/**
* DO NOT CHANGE
*/
if (!defined('IN_PHPBB'))
{
   exit;
}

if (empty($lang) || !is_array($lang))
{
	$lang = array();
}

// DEVELOPERS PLEASE NOTE
//
// All language files should use UTF-8 as their encoding and the files must not contain a BOM.
//
// Placeholders can now contain order information, e.g. instead of
// 'Page %s of %s' you can (and should) write 'Page %1$s of %2$s', this allows
// translators to re-order the output of data while ensuring it remains correct
//
// You do not need this where single placeholders are used, e.g. 'Message %d' is fine
// equally where a string contains only two placeholders which are used to wrap text
// in a url you again do not need to specify an order e.g., 'Click %sHERE%s' is fine
//
// Some characters you may want to copy&paste:
// ’ » “ ” …
//

$lang = array_merge($lang, array(
	'REMOVE_THANKS'				=> 'Supprimer le remerciement reçu par ',
	'THANK_POST'				=> 'Envoyer un remerciement à ',
	'THANK_FROM'				=> 'de',
	'THANK_TEXT_1'				=> 'Pour ce message ',
	'THANK_TEXT_2'				=> ' a reçu les remerciements de ',
	'THANK_TEXT_2pl'			=> ' a reçu plusieurs remerciements - ',
	'RECEIVED'					=> 'Remerciements reçus',
	'THANKS'					=> 'fois',
	'GIVEN'					=> 'Remerciements envoyés',
	'GRATITUDES'				=> 'Liste des remerciements',
	'FOR_MESSAGE'				=> ' pour le message',
	'THANKS_LIST'				=> 'Voir/Fermer la liste',
	'THANKS_PM_SUBJECT_GIVE'	=> 'Remerciement reçu',
	'THANKS_PM_SUBJECT_REMOVE'	=> 'Remerciement perdu',
	'THANKS_PM_MES_GIVE'		=> 'Merci pour ce message',
	'THANKS_PM_MES_REMOVE'		=> 'Le remerciement envoyé a été retiré',
	'THANKS_INFO_GIVE'			=> 'Le remerciement a été envoyé ',
	'THANKS_INFO_REMOVE'		=> 'Le remerciement a été supprimé',
	'RETURN_POST'				=> 'Retour',
	'THANKS_USER'				=> 'Liste des remerciements',
	'THANKS_BACK'				=> 'Retour',
	'JUMP_TO_FORUM'				=> 'Aller au forum',
	'JUMP_TO_TOPIC'				=> 'Aller au sujet',
	'INCORRECT_THANKS'			=> 'Erreur',
	'REMOVE_THANKS_CONFIRM'		=> 'Veuillez confirmer la suppression du remerciement',
));
?>
root/language/fr/mods/info_ucp_thanks.php

Code: Select all

<?php
/**
*
* mod_thanks [English]
*
* @package language
* @version $Id: info_ucp_thanks.php 122 2009-04-19 10:02:51Палыч $
* @copyright (c) 2008 phpBB Group
* @license http://opensource.org/licenses/gpl-license.php GNU Public License
*
*/

/**
* DO NOT CHANGE
*/
if (!defined('IN_PHPBB'))
{
   exit;
}

if (empty($lang) || !is_array($lang))
{
	$lang = array();
}

// DEVELOPERS PLEASE NOTE
//
// All language files should use UTF-8 as their encoding and the files must not contain a BOM.
//
// Placeholders can now contain order information, e.g. instead of
// 'Page %s of %s' you can (and should) write 'Page %1$s of %2$s', this allows
// translators to re-order the output of data while ensuring it remains correct
//
// You do not need this where single placeholders are used, e.g. 'Message %d' is fine
// equally where a string contains only two placeholders which are used to wrap text
// in a url you again do not need to specify an order e.g., 'Click %sHERE%s' is fine

$lang = array_merge($lang, array(
	'ALLOW_THANKS_PM'			=> 'Recevoir les notifications de remerciements',
	'ALLOW_THANKS_PM_EXPLAIN'	=> 'Vous recevez un message privé à chaque changement de la liste des remerciements pour vos messages',
));
?>
root/language/fr/mods/info_acp_thanks.php

Code: Select all

<?php
/**
*
* mod_thanks [English]
*
* @package language
* @version $Id: info_acp_thanks.php 122 2009-04-19 10:02:51Палыч $
* @copyright (c) 2008 phpBB Group
* @license http://opensource.org/licenses/gpl-license.php GNU Public License
*
*/

/**
* DO NOT CHANGE
*/
if (!defined('IN_PHPBB'))
{
   exit;
}

if (empty($lang) || !is_array($lang))
{
	$lang = array();
}

// DEVELOPERS PLEASE NOTE
//
// All language files should use UTF-8 as their encoding and the files must not contain a BOM.
//
// Placeholders can now contain order information, e.g. instead of
// 'Page %s of %s' you can (and should) write 'Page %1$s of %2$s', this allows
// translators to re-order the output of data while ensuring it remains correct
//
// You do not need this where single placeholders are used, e.g. 'Message %d' is fine
// equally where a string contains only two placeholders which are used to wrap text
// in a url you again do not need to specify an order e.g., 'Click %sHERE%s' is fine

$lang = array_merge($lang, array(
	'acl_f_thanks' 						=> array('lang' => 'Peut remercier les membres pour leurs messages', 'cat' => 'misc'),
	'acl_u_viewthanks' 					=> array('lang' => 'Peut voir la liste des remerciements', 'cat' => 'misc'),
	'IMG_THANKPOSTS'					=> 'Laisser un remerciement',
	'IMG_REMOVETHANKS'					=> 'Supprimer le remerciement',
	'THANKS_POSTLIST_VIEW'				=> 'Afficher la liste des remerciements dans les messages',
	'THANKS_PROFILELIST_VIEW'			=> 'Afficher la liste des remerciements dans le profil',
	'THANKS_NUMBER'						=> 'Affichage de la liste des remerciements',
	'THANKS_POSTLIST_VIEW_EXPLAIN'		=> 'Si activé la liste des membres qui ont donné un remerciement sera affichée dans chaque messages. <br/> Concerne uniquement les forums ou la permission de remercier est autorisée.',
	'THANKS_PROFILELIST_VIEW_EXPLAIN'	=> 'Si activé la liste des remerciements donnés et reçus un sera affichée dans chaque profil membre.',
	'THANKS_NUMBER_EXPLAIN'				=> 'Le nombre maximum de remerciements affichés dans la liste. <br /> <strong> Attention! Une valeur supérieure à 250 peut ralentir le forum. </strong>',
	'ACP_THANKS'						=> 'Remerciements',
	'ACP_THANKS_SETTINGS'				=> 'Paramètres des remerciements',
	'ACP_THANKS_SETTINGS_EXPLAIN'		=> 'Ici vous pouvez personnalisez les options des remerciements',
	'THANKS_REFRESH_MSG'				=> 'L’actualisation peut prendre un court instant',
	'THANKS_REFRESH'					=> 'Mise à jour du compteur des remerciements',
	'REFRESH'							=> 'Actualiser',
	'MCP_THANKS_REFRESHED'				=> 'Compteurs mis à jour',
	'ACP_POST'							=> 'Tous les messages',
'ACP_THANKSPOST'					=> 'Messages ayant été remerciés',
	'ACP_DELPOST'						=> 'Dont messages remerciés supprimés',
	'REMOVE_THANKS'						=> 'Autoriser la suppresion des remerciement',
	'REMOVE_THANKS_EXPLAIN'				=> 'Si activé les membres peuvent supprimer les remerciements envoyés',
));
?>
Thanks
Last edited by zach' on Thu May 28, 2009 1:13 pm, edited 6 times in total.

User avatar
Палыч
Translator
Posts: 1543
Joined: Sun Jul 01, 2007 7:59 pm
Location: St. Petersburg
Name: Сергей
Contact:

Re: [RC] Thanks for post by Палыч

Post by Палыч » Mon May 25, 2009 7:09 pm

Merci! :D

Selon russe:

Code: Select all

'THANK_TEXT_2'				=> ' поблагодарил',
C'est au cas où l'un MERCI

Code: Select all

'THANK_TEXT_2pl'			=> ' поблагодарили - %d',
Ceci, dans plusieurs cas, beaucoup de choses, où %d - le nombre MERCI

Peut-être:

Code: Select all

'ACP_THANKSPOST'					=> 'Il enregistre sur les communications avec grâce',
'ACP_DELPOST'						=> 'Supprimé documents de communication',
C'est: 100 entrées ont été, dont 5 ont été supprimées (à gauche 95)
Sorry for my bad english

zach'
Registered User
Posts: 44
Joined: Sat Nov 01, 2008 2:07 pm

Re: [RC] Thanks for post by Палыч

Post by zach' » Tue May 26, 2009 2:27 pm

Палыч wrote:Merci! :D

Selon russe:

Code: Select all

'THANK_TEXT_2'				=> ' поблагодарил',
C'est au cas où l'un MERCI

Code: Select all

'THANK_TEXT_2pl'			=> ' поблагодарили - %d',
Ceci, dans plusieurs cas, beaucoup de choses, où %d - le nombre MERCI

Peut-être:

Code: Select all

'ACP_THANKSPOST'					=> 'Il enregistre sur les communications avec grâce',
'ACP_DELPOST'						=> 'Supprimé documents de communication',
C'est: 100 entrées ont été, dont 5 ont été supprimées (à gauche 95)
Спасибо Палыч, :D

i have edited my last message to add the appropriate translation for this

You can use it in additional language "fr" package of the mod if you want,
i have tested all language entries, i think all is fine,

Do you think i can make another image buttons in french (for thankposts.gif and removethanks.gif) ,
(i don't know if there is spécial software to make same type of buttons) ?

Thanks a lot one more time - great mod :D

User avatar
Палыч
Translator
Posts: 1543
Joined: Sun Jul 01, 2007 7:59 pm
Location: St. Petersburg
Name: Сергей
Contact:

Re: [RC] Thanks for post by Палыч

Post by Палыч » Tue May 26, 2009 3:36 pm

zach' wrote:You can use it in additional language "fr" package of the mod if you want,
i have tested all language entries, i think all is fine,
Thank you!
zach' wrote:Do you think i can make another image buttons in french (for thankposts.gif and removethanks.gif) ,
(i don't know if there is spécial software to make same type of buttons) ?
Yes, I think.
Sorry for my bad english

zach'
Registered User
Posts: 44
Joined: Sat Nov 01, 2008 2:07 pm

Re: [RC] Thanks for post by Палыч

Post by zach' » Tue May 26, 2009 9:40 pm

Палыч wrote:Yes, I think.
So i add this :

Style 1 :
root/styles/prosilver/imageset/fr/thankposts.gif
Image

root/styles/prosilver/imageset/fr/removethanks.gif
Image

Style 2 :
root/styles/prosilver/imageset/fr/thankposts.gif
Image

root/styles/prosilver/imageset/fr/removethanks.gif
Image

:D

User avatar
IPB_Refugee
Registered User
Posts: 1290
Joined: Fri Jul 07, 2006 2:25 pm
Location: Austria
Name: Wolfgang Weber

Re: [RC] Thanks for post by Палыч

Post by IPB_Refugee » Wed May 27, 2009 6:10 am

Thank you for developing this MOD, Палыч! :)

How many additional queries does your MOD need when you view a topic with posts that have been heavily thanked?

E.g.: you view a topic with 20 posts. Post nr. 2 has been thanked by 10 members, post nr. 5 by 6 members, post 6 by 12 members and so on.

When I remember correctly, Mahoney's Thank post MOD needs 2 additional queries per post, which is a bit much.

Regards
Wolfgang

User avatar
knmt
Registered User
Posts: 110
Joined: Fri Aug 29, 2008 10:13 am
Contact:

Re: [RC] Thanks for post by Палыч

Post by knmt » Wed May 27, 2009 7:51 am

Well, 4 or 3 queries for everything I guess...that's low :)

Yes some problems have been fixed whereas some remain. I think that you should reduce the use of GET variables. Some variables like post_id or even to_id have already been fetched by phpbb itself, so well...

User avatar
Палыч
Translator
Posts: 1543
Joined: Sun Jul 01, 2007 7:59 pm
Location: St. Petersburg
Name: Сергей
Contact:

Re: [RC] Thanks for post by Палыч

Post by Палыч » Wed May 27, 2009 7:39 pm

IPB_Refugee wrote:How many additional queries
Tested at a forum phpbb 3.0.4
45000 posts, 1000 users, 10000 thanks.
Time for viewtopic 0.2 - 0.5c (+1 / 2 query's to the standard)
memberlist (profile) 0.4 - 0.6c (+1 query to the standard)
thankslist 0.1 - 0.3c 9 queries = standard memberlist
Slow down when viewing a profile, if the listing is included in the profile, and the total number of acknowledgments (received + distributed) over 1000
If you read Russian, can read the topic of MODS on the link from the first post :)
knmt wrote:There are some grammatical error in your language files also.
Could you help make the correct terms for the English language? Sorry for my bad english :oops:
Sorry for my bad english

User avatar
Палыч
Translator
Posts: 1543
Joined: Sun Jul 01, 2007 7:59 pm
Location: St. Petersburg
Name: Сергей
Contact:

Re: [RC] Thanks for post by Палыч

Post by Палыч » Wed May 27, 2009 7:41 pm

zach' wrote:So i add this :
Excellent! I can include them in the archives?
Sorry for my bad english

User avatar
IPB_Refugee
Registered User
Posts: 1290
Joined: Fri Jul 07, 2006 2:25 pm
Location: Austria
Name: Wolfgang Weber

Re: [RC] Thanks for post by Палыч

Post by IPB_Refugee » Wed May 27, 2009 8:19 pm

Thanks for the infos, Палыч & knmt!

That sounds really nice. :) At the moment I am not able to install any further MODs as I have to fix some bugs before, but I will surely try your MOD!

Regarding:
CREATE TABLE phpbb_thanks (
post_id mediumint(8) NOT NULL default '0',
poster_id mediumint(8) NOT NULL default '0',
user_id mediumint(8) NOT NULL default '0',
PRIMARY KEY (post_id , user_id));
Do you think it would improve the MySQL performance of your MOD to set another index on poster_id?

Greetings from Austria!
Wolfgang

User avatar
Палыч
Translator
Posts: 1543
Joined: Sun Jul 01, 2007 7:59 pm
Location: St. Petersburg
Name: Сергей
Contact:

Re: [RC] Thanks for post by Палыч

Post by Палыч » Wed May 27, 2009 8:24 pm

IPB_Refugee
May be...
Sorry for my bad english

User avatar
Палыч
Translator
Posts: 1543
Joined: Sun Jul 01, 2007 7:59 pm
Location: St. Petersburg
Name: Сергей
Contact:

Re: [RC] Thanks for post by Палыч

Post by Палыч » Wed May 27, 2009 8:25 pm

But little ...
Sorry for my bad english

zach'
Registered User
Posts: 44
Joined: Sat Nov 01, 2008 2:07 pm

Re: [RC] Thanks for post by Палыч

Post by zach' » Thu May 28, 2009 1:08 pm

Палыч wrote:Excellent! I can include them in the archives?
Of course Палыч i have post it in this way, :D

So you have the full French additional pack ( Language files + images files )

Your mod is very impressfull, it's a pleasure for me ;)

The mod is fine on my forum, but i just see a minor issue with bbcode in the messages from thanks_results.html, all bbcode are modify so they cant't be see, for examples :

Code: Select all

[quote="molotov":1rbs1tj4] ..... [/quote:1rbs1tj4]
[u:2alp7jag] ..... [/u:2alp7jag]
[img:2alp7jag] ....[/img:2alp7jag]
I think the install is fine, so i dont see what can do that, perhaps it came from {searchresults.MESSAGE}

could you help me about this minor issue, please

Thanks a lot

Locked

Return to “[3.0.x] MODs in Development”