phpBB.com

Paulo França Lacerda wrote:should have the column name double-quoted...

Paulo França Lacerda wrote:The PRIMARY KEY should also include the field "POST_ID"

PRIMARY KEY (post_id , user_id)

Палыч wrote:I can add your language files in the archive?

Палыч wrote:

Paulo França Lacerda wrote:should have the column name double-quoted...

Perhaps, I did not work with Firebird as Dabatase

Палыч wrote:

Paulo França Lacerda wrote:The PRIMARY KEY should also include the field "POST_ID"

Hmmm... This field is already included...

Code: Select all

PRIMARY KEY (post_id , user_id)

PRIMARY KEY (post_id , POSTER_ID, user_id)

Paulo França Lacerda wrote:Of Course! I'd be glad.

Paulo França Lacerda wrote:For sure it's true: I do work with FB exclusively.

Paulo França Lacerda wrote:I meant all 3 fields should go in the Primary Key

Палыч wrote:

Paulo França Lacerda wrote:I meant all 3 fields should go in the Primary Key

Strange. The combination of fields post_id and user_id is enough for the unique identification of records (because the post_id has only one author - poster_id)

Now I understand what happened...
It happens that I used EMS SEL Manager in order to create the THANK table directly into Firebird Database and, when creating the Primary Key, I must have (mistakenly) selected the field POSTER_ID instead of POST_ID. That must have caused the PK SQL Error when the reader tried to thank a second post of the same author.

Infact, just the 2 fields (POST_ID and USER_ID) are enough in the PK.
Sorry for the confusion.

So the SQL Sentence for preparing the Firebird Database can be:

CREATE TABLE ATS_THANKS (
  POST_ID   INTEGER DEFAULT 0 NOT NULL,
  POSTER_ID INTEGER DEFAULT 0 NOT NULL,
  USER_ID   INTEGER DEFAULT 0 NOT NULL);

ALTER TABLE ATS_THANKS 
  ADD CONSTRAINT CPK_THANKS PRIMARY KEY (USER_ID,POST_ID);

ALTER TABLE phpbb_users 
  ADD user_allow_thanks_pm SmallInt DEFAULT '0' NOT NULL;

Paulo França Lacerda wrote:Infact, just the 2 fields (POST_ID and USER_ID) are enough in the PK.

Paulo França Lacerda wrote:When using prosilver style (dunno about others), the thank list that appears on user's profile are wider than its parent box

• Fix minor bags and optimized code (thanks tumba25).
• Аdjusted BBCODE parsing in the thanklist search.
• Аdjusted thankslist.php is viewable if "Can view list of thanks" is set to NO.
• Updated files for English language (thanks knmt).
• Added files for French (thanks zach').
• Added files for Brazilian Portuguese (thanks Paulo França Lacerda).

Палыч wrote:

Paulo França Lacerda wrote:When using prosilver style (dunno about others), the thank list that appears on user's profile are wider than its parent box

And as it looks at this memberlist?

Bang! Hehehe... yes, tue bug seems to lie in phpBB code, as the usual memberlist too is wider than its parent. Sorry for the false-alarm.

Now, taking the oportunity, I have uploaded 3rd edition of the PTBR pack, with these changes:
1) Changed translated texts used as hints for the "Do Thank" and "Remove Thank" buttons.
2) Explained the confusion I did with the 3-key PK.
3) Included the image in the "subsilver2" style and its own folder, but didn't change the "hand" picture in these images (it's universal).

Thank4Post.v122.PTBR-3aEd.zip

Paulo França Lacerda wrote:Sorry for the false-alarm.

Paulo França Lacerda wrote:Changed translated texts used as hints for the "Do Thank" and "Remove Thank" buttons.

Paulo França Lacerda wrote:) Included the image in the "subsilver2" style and its own folder

Палыч wrote:Your files in WIN-format (must be in UNIX) and have a tag BOM (this is not acceptable).

Paulo França Lacerda wrote:Is there any tool for that?

Paulo França Lacerda wrote:This would be very handy when user wants to see who is "best thanked" and who is "best grateful".

Paulo França Lacerda wrote:1) Well, files must be UTF8 without BOM, but I cannot save in UTF8 without BOM in Windows. Is there any tool for that?

Ok, found Notgepad++ (ops... I posted right before reading your advice. THanks.)

The CRLF issue I'll see if Notepad++ is able to save (I'm still downloading it).