Page 3 of 4

Re: [BETA] Automatic Daylight Savings Time (DST) 1.1.4

Posted: Thu Mar 19, 2009 11:04 pm
by papaFX
MartectX wrote:What is the "safety" difference between public_html and the other folder where it didn't work?
Maybe I didn't expressed it correctly.
Anyway the thing I wanted to avoid was for the link www.mypage.com/folder to work so I transferred the files out of public_html and set a subdomain to "point" to that dir. :?
Had no problems with the forum operation so far.

8-)

Re: [BETA] Automatic Daylight Savings Time (DST) 1.1.4

Posted: Fri Mar 20, 2009 12:09 am
by MartectX
That would not explain the error that occurred IMO. But if it works now - all is well.

Re: [BETA] Automatic Daylight Savings Time (DST) 1.1.4

Posted: Thu Mar 26, 2009 9:29 pm
by Muad''Dib
Have you made any progress with this?

Re: [BETA] Automatic Daylight Savings Time (DST) 1.1.4

Posted: Thu Mar 26, 2009 9:48 pm
by MartectX
Muad''Dib wrote:Have you made any progress with this?
I'm waiting for one last beta tester to read the private message I sent to him. If and when he logs on and has a go at this version - and approves of it - I will put it in RC stage.

Re: [BETA] Automatic Daylight Savings Time (DST) 1.1.4

Posted: Thu Mar 26, 2009 10:13 pm
by Muad''Dib
Sounds great..

By chance from this point forward can you provide your latest release with "upgrade" instructions?

So that say if i installed this on a live board (i know .. i know not a good idea to do with a beta mod) i can easily upgrade to reflect your latest changes?

Re: [BETA] Automatic Daylight Savings Time (DST) 1.1.4

Posted: Thu Mar 26, 2009 10:19 pm
by MartectX
Muad''Dib wrote:By chance from this point forward can you provide your latest release with "upgrade" instructions?
Beginning with RC2 (update to RC1) I will provide such instructions.

Re: [BETA] Automatic Daylight Savings Time (DST) 1.1.4

Posted: Thu Mar 26, 2009 10:20 pm
by Muad''Dib
Ok, Sounds fair enough.

Re: [BETA] Automatic Daylight Savings Time (DST) 1.1.5

Posted: Sat Mar 28, 2009 3:38 pm
by MartectX
Version 1.1.5
  • Bugfix for boards in a state before time zone conversion

Re: [BETA] Automatic Daylight Savings Time (DST) 1.1.6

Posted: Mon Mar 30, 2009 5:16 pm
by MartectX
Version 1.1.6
  • Bugfix for avatars
To update from 1.1.5 do the changes to download/file.php.

Re: [BETA] Automatic Daylight Savings Time (DST) 1.1.6

Posted: Mon Mar 30, 2009 7:43 pm
by Muad''Dib
Did another clean install and then did 1.1.6. Everything went smoothly as before.

btw didnt ever install 1.1.5 been busy.

This time i did notice that after i ran convert_timezones.php, both my timezone and the anonymous account had "Europe/London" selected as the timezone. I'm not sure if that was suppose to happen or not. (Assumed Not).

Here were my steps:
  • Install \ Configure phpbb3.

    Set board timezone and enabled DST.

    Configured my user account to have the proper timezone with DST enabled. (UTC -8 FWIW).

    Checked to make sure the time and date were correct.

    Installed your mod.

    Purged Cache.

    Configured the board settings to have the proper timezone (America/Los_Angeles was actually already selected like it should have been)

    Ran convert_timezones.php.

    Checked the anonymous account. London was selected. Changed it.

    Viewed the homepage. My account showed london also.

    Went into ACP and changed my timezone.

    Everything seemed great.
I didnt check to see what the timezones were for my account and for the anonymous account before i ran "convert_timezones.php".... sorry for that.

Re: [BETA] Automatic Daylight Savings Time (DST) 1.1.6

Posted: Tue Mar 31, 2009 8:26 am
by MartectX
First: Thank you for your very detailed report, exactly what I need for bugfinding! I followed your guide up to this point:
Muad''Dib wrote:Checked the anonymous account. London was selected. Changed it.

Viewed the homepage. My account showed london also.

Went into ACP and changed my timezone.

Everything seemed great.
The anonymous account is not supposed to reflect the board settings immediately. The first time a visitor or bot will browse your board the time zone of ANONYMOUS will be changed to the board time setting (seems only logical to me, don't know why they are kept separate in the first place) - as you were browsing the board as an admin, the script never had the chance to change it. So this is not a bug.

Then I did as you did, I checked the setting for both my account and the board and both were at "America/Los_Angeles", not London. So I do not quite know what went wrong in your case... but seeing that it works fine now, I don't think it's severe.

If you really wanted to help me you could repeat all those steps from above and check if the same error happens again. :)

Re: [BETA] Automatic Daylight Savings Time (DST) 1.1.6

Posted: Tue Mar 31, 2009 11:46 pm
by Muad''Dib
Another Install:
  • Installed phpbb
    Configured Board timezone and my own timezone to be UTC -8 with DST enabled.
    Checked to make sure all times appeared correct.
    Installed your mod and cleared cache.
    Looked at "Board Settings", and it was correct (America/Los_Angeles)
    Viewed the Board Index and the time was correct.
    Logged Out and viewed forum as guest .. time was correct.
    Logged in again, and time was still correct.
    Ran "convert_timezones.php"
    Viewed Board Index, and time was correct.
    Checked "Board Settings" in ACP, and time was correct.
    Checked Anonymous accounts preferences within ACP, Timezone was set to the board setting.
    Checked my own UCP, and confirmed that the timezone was set correctly
I think the problem before was me never going to the board index before i ran "convert_timezones.php"... but im not sure.

Anyway, it worked just fine this time.

Re: [BETA] Automatic Daylight Savings Time (DST) 1.1.6

Posted: Wed Apr 01, 2009 10:07 am
by MartectX
Thank you very much for your efforts!

Re: [BETA] Automatic Daylight Savings Time (DST) 1.1.6

Posted: Mon Apr 13, 2009 10:44 am
by Morun
Hi MartectX,

I just installed your mod on a test board and got the following error:

Code: Select all

Fatal error: Class 'DateTime' not found in /hp/ac/ad/pp/www/test-forum/includes/automatic_dst.php on line 103
I'm using: PHP Version 5.1.4-Debian-0.1~sarge1 (Debian GNU/Linux)
(date/time support enabled
Timezone Database Version 2006.1
Timezone Database internal
Default timezone Europe/Berlin)

If you can help me get the mod running, I can send you the respective fields in phpbb_users before and after installation of about 300 users to check whether the conversion went right.


Cheers,
Tarun

Re: [BETA] Automatic Daylight Savings Time (DST) 1.1.6

Posted: Tue Apr 14, 2009 11:05 am
by MartectX
Morun wrote:

Code: Select all

Fatal error: Class 'DateTime' not found in /hp/ac/ad/pp/www/test-forum/includes/automatic_dst.php on line 103
I'm using: PHP Version 5.1.4-Debian-0.1~sarge1 (Debian GNU/Linux)
Hmmm... it seems that the DateTime object is only supported from 5.2.0 on - it is in PHP >= 5.1.0, but you need to explicitly enable it when you compile PHP versions < 5.2.... did you do that?

I'll have a new version that addresses older PHP versions ready today.