[MODDB] Topic Multi-Moderation & Topic Prefixes

A place for MOD Authors to post and receive feedback on MODs still in development. No MODs within this forum should be used within a live environment!
Ideas Centre
Locked
User avatar
imkingdavid
Former Team Member
Posts: 2673
Joined: Sun Jul 26, 2009 7:59 pm
Location: EST
Name: David King

Re: [1.0.0 - RC5] Topic Multi-Moderation & Topic Prefixes

Post by imkingdavid »

nexum wrote:Is it possible to search for all topics tagged with a specific prefix ?
Not currently, but it is planned eventually, although not for version one unless I can figure out the best way to implement it.
Also, is it possible to force the user to select a prefix while posting a thread ?
Not yet, but I may see about adding this feature.
And can you enable the mod only for one specific forum ?
Yes, it can be enabled per forum, per user, and per multi-mod or per prefix.
thanks !
you're welcome.
Don't forget to smile today. :)
Please do NOT contact for support via PM or email.
User avatar
mao43
Registered User
Posts: 80
Joined: Thu Jul 23, 2009 5:08 am
Location: Santa Rosa Laguna
Contact:

Re: [1.0.0 - RC5] Topic Multi-Moderation & Topic Prefixes

Post by mao43 »

when will the bug may be fixed?
im still waiting for it
User avatar
imkingdavid
Former Team Member
Posts: 2673
Joined: Sun Jul 26, 2009 7:59 pm
Location: EST
Name: David King

Re: [1.0.0 - RC5] Topic Multi-Moderation & Topic Prefixes

Post by imkingdavid »

mao43 wrote:when will the bug may be fixed?
im still waiting for it
Sorry to keep you waiting. School just ended but the past few weeks have been pretty hectic. I don't know when I can promise a fix for you, sorry. I will try and work on it when I get a chance though.
Don't forget to smile today. :)
Please do NOT contact for support via PM or email.
User avatar
Ashley.S.
Registered User
Posts: 469
Joined: Mon Aug 04, 2008 6:01 pm
Location: Falmouth, Cornwall, UK
Name: Ashley .S.
Contact:

Re: [1.0.0 - RC5] Topic Multi-Moderation & Topic Prefixes

Post by Ashley.S. »

ok, this mod is incompatible with the Ultimate Points System for some bizarre reason, the following edit made to viewtopic.php when installing UPS:

Code: Select all

// Start Ultimate Points
$user->setup('mods/points');
// End Ultimate Points
will cause TMM to break:

Code: Select all

Fatal error: Cannot redeclare class tmm_cache in /home/******/public_html/includes/mods/functions_tmm_cache.php  on line 115
removing that piece of code will happily restore TMM, but causes some extremely nice debug messages related to UPS at the top if you have debug enabled. I'm unsure of what it will do to UPS with the edit missing.

Any advice will be greatly appreciated
Last edited by Ashley.S. on Mon Jun 28, 2010 2:11 pm, edited 1 time in total.
Regards,
-Ashley.S. [ PurephpBB Founder ]
User avatar
Dakin Quelia
Registered User
Posts: 300
Joined: Thu Feb 14, 2008 10:07 pm
Location: Belgium
Name: Daniel Chalsèche
Contact:

Re: [1.0.0 - RC5] Topic Multi-Moderation & Topic Prefixes

Post by Dakin Quelia »

Hello imkingdavid,

There is a problem with accent. To fix problem I made:

Open includes/acp/acp_tmm.php.

Find:

Code: Select all

                        'autoresponse'        => request_var('autoresponse', ''),    
Replace with:

Code: Select all

                        'autoresponse'        => utf8_normalize_nfc(request_var('autoresponse', '', true)),    
Find:

Code: Select all

                    $prefix_title = utf8_normalize_nfc(request_var('prefix_title', ''));  
Replace with:

Code: Select all

                    $prefix_title = utf8_normalize_nfc(request_var('prefix_title', '', true));  
Find:

Code: Select all

                    $prefix_name = utf8_normalize_nfc(request_var('prefix_name', ''));  
Replace with:

Code: Select all

                    $prefix_name = utf8_normalize_nfc(request_var('prefix_name', '', true));  


;)

See you soon,
User avatar
imkingdavid
Former Team Member
Posts: 2673
Joined: Sun Jul 26, 2009 7:59 pm
Location: EST
Name: David King

Re: [1.0.0 - RC5] Topic Multi-Moderation & Topic Prefixes

Post by imkingdavid »

Thank you both for the bug reports. I won't have much time to work on this this week, but next week I should.
Don't forget to smile today. :)
Please do NOT contact for support via PM or email.
User avatar
imkingdavid
Former Team Member
Posts: 2673
Joined: Sun Jul 26, 2009 7:59 pm
Location: EST
Name: David King

Re: [1.0.0 - RC5] Topic Multi-Moderation & Topic Prefixes

Post by imkingdavid »

As an update, I have fixed the moderator issue (now normal users can use multi-mods when given permission via the ACP). In order to do so, I had to remove the MCP module and just use a custom page (tmm.php) as I had done in the original version of the MOD. However, when you update, the files will be removed automatically if you use autoMOD, but you will need to manually remove the module from the database. I have included instructions for that in the DIY section.

I have also fixed the stuff pointed out by Dakin Quelia above.

As for the redeclaring the class, that's probably an issue with UPS more than an issue with my MOD. But I'll try and look for a way to make them compatible. For now, just try and live without the little code you removed. All it does really is adds that language file in. You can get around that for now by adding the contents of that language file into the common.php language file.

Anyway...thanks for the bug reports and I might get RC6 out tomorrow (but no promises; I still need to test since I made some major changes, and I need to test the update instructions, although I'm pretty sure the normal install instructions work fine).
Don't forget to smile today. :)
Please do NOT contact for support via PM or email.
User avatar
imkingdavid
Former Team Member
Posts: 2673
Joined: Sun Jul 26, 2009 7:59 pm
Location: EST
Name: David King

Re: [1.0.0 - RC5] Topic Multi-Moderation & Topic Prefixes

Post by imkingdavid »

MOD Updated to 1.0.0 RC6

Changes from RC5 to RC6:
[fix] errors pointed out during MOD validation
[fix] non-moderators cannot apply multi-mods

Update instructions in contrib/ folder. In short, simply overwrite all files and follow the file edits. Run the sql installer and then delete it. You'll have to manually remove the MCP module since I replaced it with a normal custom file to allow non-moderators to apply multi-mods.

Important information, and download/repository links in first post.

Please report any bugs or suggestions either here or on the Official Support Forum.
Don't forget to smile today. :)
Please do NOT contact for support via PM or email.
User avatar
Ratmaster
Registered User
Posts: 163
Joined: Sun Feb 12, 2006 3:14 pm
Location: New Jersey, USA

Re: [1.0.0 - RC6] Topic Multi-Moderation & Topic Prefixes

Post by Ratmaster »

Did you look into the code idea I mentioned? http://www.phpbb.com/community/viewtopi ... #p12808480
I still need to know where the MCP template file shows up, as I have finished all of the subsilver2 template changes except that one...I may have not activated something, I just can't find it for my life.
User avatar
imkingdavid
Former Team Member
Posts: 2673
Joined: Sun Jul 26, 2009 7:59 pm
Location: EST
Name: David King

Re: [1.0.0 - RC6] Topic Multi-Moderation & Topic Prefixes

Post by imkingdavid »

Ratmaster wrote:Did you look into the code idea I mentioned? http://www.phpbb.com/community/viewtopi ... #p12808480
I still need to know where the MCP template file shows up, as I have finished all of the subsilver2 template changes except that one...I may have not activated something, I just can't find it for my life.
I didn't think to implement that idea. I will consider doing so once the MOD gets validated or denied in the MOD DB.

As for the MCP template, I have removed the MCP module in the latest RC because it was preventing non-moderator users from performing multi-mods. Now that is handled by a custom page using trigger_error() so there is no template file to worry about.
Don't forget to smile today. :)
Please do NOT contact for support via PM or email.
User avatar
mao43
Registered User
Posts: 80
Joined: Thu Jul 23, 2009 5:08 am
Location: Santa Rosa Laguna
Contact:

Re: [1.0.0 - RC6] Topic Multi-Moderation & Topic Prefixes

Post by mao43 »

wah?~
Image

how can i fix this
what files? or file to be edit?
User avatar
imkingdavid
Former Team Member
Posts: 2673
Joined: Sun Jul 26, 2009 7:59 pm
Location: EST
Name: David King

Re: [1.0.0 - RC6] Topic Multi-Moderation & Topic Prefixes

Post by imkingdavid »

mao43 wrote:wah?~
Image

how can i fix this
what files? or file to be edit?
Looks like you applied the viewtopic_body.html edit twice.

Open: viewtopic_body.html
Find:

Code: Select all

<!-- IF TMM_SELECT -->
	<br clear="right" />
	<form method="post" action="{S_TMM_ACTION}">
    <fieldset class="quickmod">
    	<label for="tmm-mod-select">{L_MULTI_MODS}:</label> {TMM_SELECT} <input type="submit" value="{L_GO}" class="button2" />
    </fieldset>
    </form>
<!-- ENDIF -->
There should be two of those. Remove one of them.
Don't forget to smile today. :)
Please do NOT contact for support via PM or email.
User avatar
mao43
Registered User
Posts: 80
Joined: Thu Jul 23, 2009 5:08 am
Location: Santa Rosa Laguna
Contact:

Re: [1.0.0 - RC6] Topic Multi-Moderation & Topic Prefixes

Post by mao43 »

Wooot I think its a BUG.

When Applying the Multi Topic. You will be questioned Yes or No.
when i press no,it will go to blank page.

another one.

i made my first topic prefix and 2nd topic prefix.
then i made 2 multi mods
first: Solved Multi Mod
second: Archive Multi Mod

i tried to use the Solved Multi Topic on a Topic. and after i pressed "Go".
this message appears

Code: Select all

No multi-mod specified.
after that i tried to use the Archive Multi Topic. and after i pressed "Go".

Code: Select all

The following actions will be performed:
Topic Locked
Topic Moved
Reply posted to topic
this is what i really expect cause this is what i configure @ ACP

Then "Yes or No"
the Archive Multi Topic Works.

why does the first multi mods dont work but the 2nd works?

i tried another one. i removed them both.
now i made this
first: Archive Multi Mod
second: Solved Multi Mod

its like the first but i made first the archive multi Mod and 2nd the Solve Multi Mod
like this first one

when i tried the Archive Multi Mod it doesn't work
but when i tried the Solved Multi Mod it works.

why does the first multi mod don't work?


can you check about this?
User avatar
imkingdavid
Former Team Member
Posts: 2673
Joined: Sun Jul 26, 2009 7:59 pm
Location: EST
Name: David King

Re: [1.0.0 - RC6] Topic Multi-Moderation & Topic Prefixes

Post by imkingdavid »

mao43 wrote:Wooot I think its a BUG.

When Applying the Multi Topic. You will be questioned Yes or No.
when i press no,it will go to blank page.

another one.

i made my first topic prefix and 2nd topic prefix.
then i made 2 multi mods
first: Solved Multi Mod
second: Archive Multi Mod

i tried to use the Solved Multi Topic on a Topic. and after i pressed "Go".
this message appears

Code: Select all

No multi-mod specified.
after that i tried to use the Archive Multi Topic. and after i pressed "Go".

Code: Select all

The following actions will be performed:
Topic Locked
Topic Moved
Reply posted to topic
this is what i really expect cause this is what i configure @ ACP

Then "Yes or No"
the Archive Multi Topic Works.

why does the first multi mods dont work but the 2nd works?

i tried another one. i removed them both.
now i made this
first: Archive Multi Mod
second: Solved Multi Mod

its like the first but i made first the archive multi Mod and 2nd the Solve Multi Mod
like this first one

when i tried the Archive Multi Mod it doesn't work
but when i tried the Solved Multi Mod it works.

why does the first multi mod don't work?


can you check about this?
Thank you for the bug reports. I'll take a look at both of those and post fixes when I can. However, I will not actually release another full version until the MOD is accepted or denied into the MOD DB.
Don't forget to smile today. :)
Please do NOT contact for support via PM or email.
User avatar
imkingdavid
Former Team Member
Posts: 2673
Joined: Sun Jul 26, 2009 7:59 pm
Location: EST
Name: David King

Re: [1.0.0 - RC6] Topic Multi-Moderation & Topic Prefixes

Post by imkingdavid »

Well that was quick.

For the second bug, here is the fix:
Open: tmm.php
Find:

Code: Select all

    $tmm_options['id'] = $tmm_id; 
Replace With:

Code: Select all

    $tmm_options[] = $tmm_id; 
I'm still looking into the first bug.
Don't forget to smile today. :)
Please do NOT contact for support via PM or email.
Locked

Return to “[3.0.x] MODs in Development”