[MODDB] ACP Announcement Centre 1.0.1

[lefty74]

Others had no problem installing it on gold, I would think that you did not install correctly and when you uninstalled you deleted more then just the bits from the mod.

just upload your backup and you should be fine i would say.

[raZorX]

Didnt delete the statement from the code as I fear this would happen, I just added // in front.

Can you please post a working index.php soo I have a look at the code please?

[WheelGuy]

General Error
SQL ERROR [ mysql4 ]

Table 'xxxxxx_phpb1.ATTACHMENTS_TABLE' doesn't exist [1146]

SQL

SELECT COUNT(attach_id) AS total_orphan FROM ATTACHMENTS_TABLE WHERE is_orphan = 1 AND filetime < 1199528334

BACKTRACE

FILE: includes/db/mysql.php
LINE: 158
CALL: dbal->sql_error()

FILE: includes/acp/acp_main.php
LINE: 365
CALL: dbal_mysql->sql_query()

FILE: includes/functions_module.php
LINE: 471
CALL: acp_main->main()

FILE: adm/index.php
LINE: 74
CALL: p_master->load_active()

Correct me if I am wrong, but that error has to do with the built in phpBB3 "attachment" feature. I personally don't remember editing the adm/index.php which the backtrace is referring to.

[lefty74]

have a look in includes/constants.php

Code: Select all

define('ACL_USERS_TABLE',			$table_prefix . 'acl_users');
define('ANNOUNCEMENTS_CENTRE_TABLE',$table_prefix . 'announcement_centre');
define('ATTACHMENTS_TABLE',			$table_prefix . 'attachments');
 

you may have commented out or deleted the attachments table bit and possibly missed to add the announcement centre bit in the first place.

[raZorX]

Restored index.php, still cant access the ACP.

Seems some other file is corrupted.

Im going through these once again:
includes/constants.php,
includes/functions_display.php,
language/en/acp/common.php,
language/en/common.php,
index.php,
styles/prosilver/template/index_body.html,
styles/subsilver2/template/overall_header.html

Hope I can test your script.

[raZorX]

Nop, getting this error:

General Error
SQL ERROR [ mysql4 ]

Table 'user_phpb1.phpbb3_announcement_centre' doesn't exist [1146]

SQL

SELECT * FROM phpbb3_announcement_centre

BACKTRACE

FILE: includes/db/mysql.php
LINE: 158
CALL: dbal->sql_error()

FILE: index.php
LINE: 85
CALL: dbal_mysql->sql_query()

I have PhP 4.4.4, is this mod having any version requirements?

[lefty74]

you do not seem to be using the default prefix, did you change phpbb_ to phpbb3_ before you executed the SQL?

the includes/constants edit is made?

[raZorX]

have a look in includes/constants.php

Code: Select all

define('ACL_USERS_TABLE',			$table_prefix . 'acl_users');
define('ANNOUNCEMENTS_CENTRE_TABLE',$table_prefix . 'announcement_centre');
define('ATTACHMENTS_TABLE',			$table_prefix . 'attachments');
 

you may have commented out or deleted the attachments table bit and possibly missed to add the announcement centre bit in the first place.

You were right.
It was missing. define('ATTACHMENTS_TABLE', $table_prefix . 'attachments');

But you fail to provide this info in the instalation instructions. Download the file and look.
ACP_Announcement_Centre.xml <-- misses this IMPORTANT info .

[lefty74]

have a look in includes/constants.php

Code: Select all

define('ACL_USERS_TABLE',			$table_prefix . 'acl_users');
define('ANNOUNCEMENTS_CENTRE_TABLE',$table_prefix . 'announcement_centre');
define('ATTACHMENTS_TABLE',			$table_prefix . 'attachments');
 

you may have commented out or deleted the attachments table bit and possibly missed to add the announcement centre bit in the first place.

You were right.
It was missing. define('ATTACHMENTS_TABLE', $table_prefix . 'attachments');

But you fail to provide this info in the instalation instructions. Download the file and look.
ACP_Announcement_Centre.xml <-- misses this IMPORTANT info .

if it was not in the install instructions, noone would be able to install this mod without errors. Have you looked at the first edit to be made???

the ATTACHMENTS_TABLE one is in the vanilla version, my mod does nothing to it/with it so you must have overwritten it/deleted it by accident, it is certainly not in the instructions to delete it!

[raZorX]

I downloaded the zip file again, extracted it and opened instructions xml file with IE. Still the required modification is not present.

Instructions say:
#
#-----[ OPEN ]------------------------------------------
#
includes/constants.php
#
#-----[ FIND ]------------------------------------------
#
define('ACL_USERS_TABLE', $table_prefix . 'acl_users');

#
#-----[ AFTER, ADD ]------------------------------------------
#
define('ANNOUNCEMENTS_CENTRE_TABLE',$table_prefix . 'announcement_centre');


-------------------------------
What did you mean by vanilla version. I downloaded the file on the first post and followed its instructions to the letter.

OK I added the mod in the ACP, enabled it, and I see nothing on my page.
Yes cache has been cleared etc,..

[lefty74]

whats the first edit you have to do according to the install instructions.

did you copy all the files over and make also the edits in the html files?

when you change data in the ACP, does it save it correctly?

[raZorX]

Modify the database, copy the provided files then start modifying.
Files are there, I looked.

Yes added the line in index_body.html.

Code: Select all

<!-- INCLUDE overall_header.html -->
<!-- INCLUDE announcement_centre.html -->
<p class="{S_CONTENT_FLOW_END}<!-- IF S_USER_LOGGED_IN --> rightside<!-- ENDIF -->"><!-- IF S_USER_LOGGED_IN -->{LAST_VISIT_DATE}<!-- ELSE -->{CURRENT_TIME}<!-- ENDIF --></p>
<!-- IF U_MCP --><p>{CURRENT_TIME} <br />[&nbsp;<a href="{U_MCP}">{L_MCP}</a>&nbsp;]</p><!-- ELSEIF S_USER_LOGGED_IN --><p>{CURRENT_TIME}</p><!-- ENDIF -->

[raZorX]

when you change data in the ACP, does it save it correctly?

What do you mean with that? Sure it saves, else the ACP would say it cant,.. the message would be red. Its all green.

Ill try the modiffications other users have suggested so it can be seen on all pages.

[crazygandalf]

i am currently busy with my announcement centre mod

Is there any date you want to release new version of your mod?

[*Christian*]

Will this [MOD] still work if you don't perform the [SQL] steps at the beginning?