[MODDB] Prime Trash Bin - Keep deleted topics & posts

A place for MOD Authors to post and receive feedback on MODs still in development. No MODs within this forum should be used within a live environment!
Anti-Spam Guide
azzurri
Registered User
Posts: 887
Joined: Fri Jul 21, 2006 7:48 pm

Re: [BETA] Prime Recycle Bin (0.1.1) - Delete Threads To a Forum

Postby azzurri » Wed Aug 15, 2007 8:27 am

Alright, I'll try it out.

azzurri
Registered User
Posts: 887
Joined: Fri Jul 21, 2006 7:48 pm

Re: [BETA] Prime Recycle Bin (0.1.1) - Delete Threads To a Forum

Postby azzurri » Wed Aug 15, 2007 11:30 am

Code: Select all

//-- mod: Prime Recycle Bin -------------------------------------------------//
// If this admin cannot see the recycle bin forum, then don't show the recycle bin option
            if (!empty($config['recycle_bin_forum']) && !($auth->acl_get('f_list', $config['recycle_bin_forum'])))
            {
               unset($display_vars['vars']['recycle_bin_forum']);
            }
//-- end: Prime Recycle Bin -------------------------------------------------//


This code prevents me as the board admin to see the recycle bin option in the forum settings. When I remove this code I can see the option.

*EDIT*
Okay so I guess you have to add this code AFTER you have choosen the recycle bin forum? Cause then it worked. I guess it is a good thing for security reasons but you should explain it better, or maybe I just missed this information...or third option, Im stupid.

*EDIT2*

As a user I still get the message: (translated from swedish) You do not have acess to this part of the forum (or 'NOT_AUTHORISED' in language file common.php) when I try to delete a topic (deleting posts work though).
Last edited by azzurri on Wed Aug 15, 2007 4:55 pm, edited 1 time in total.

azzurri
Registered User
Posts: 887
Joined: Fri Jul 21, 2006 7:48 pm

Re: [BETA] Prime Recycle Bin (0.1.1) - Delete Threads To a Forum

Postby azzurri » Wed Aug 15, 2007 4:45 pm

*Nevermind*

User avatar
primehalo
Former Team Member
Posts: 2649
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [BETA] Prime Recycle Bin (0.1.1) - Delete Threads To a Forum

Postby primehalo » Wed Aug 15, 2007 5:43 pm

azzurri wrote:*Nevermind*

Nevermind about which one?

That code snippet should only prevent the recycle bin option from displaying if (1)There is a recycle bin selected and (2)the admin does not have permission to view the recycle bin forum.
Ken F. Innes IV
My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

azzurri
Registered User
Posts: 887
Joined: Fri Jul 21, 2006 7:48 pm

Re: [BETA] Prime Recycle Bin (0.1.1) - Delete Threads To a Forum

Postby azzurri » Wed Aug 15, 2007 5:52 pm

I wrote nevermind to myself. It was a wrong posting.

Yes, as I wrote in the post I understood but it wasn't explained in the install instructions.

Still I have a big problem as you can see my users cant erase their own topics...

azzurri wrote:As a user I still get the message: (translated from swedish) You do not have acess to this part of the forum (or 'NOT_AUTHORISED' in language file common.php) when I try to delete a topic (deleting posts work though).


This is my personal theory. Only who the admin chooses may have access to the bin and so only these people can erase threads. When a regular user without this permission creates a thread he has the option to delete it also and so the hack thinks this user is trying to get access to the bin which he doesnt have. Right?

User avatar
primehalo
Former Team Member
Posts: 2649
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [BETA] Prime Recycle Bin (0.1.1) - Delete Threads To a Forum

Postby primehalo » Wed Aug 15, 2007 9:15 pm

azzurri wrote:I wrote nevermind to myself. It was a wrong posting.

Yes, as I wrote in the post I understood but it wasn't explained in the install instructions.

Still I have a big problem as you can see my users cant erase their own topics...

azzurri wrote:As a user I still get the message: (translated from swedish) You do not have acess to this part of the forum (or 'NOT_AUTHORISED' in language file common.php) when I try to delete a topic (deleting posts work though).


This is my personal theory. Only who the admin chooses may have access to the bin and so only these people can erase threads. When a regular user without this permission creates a thread he has the option to delete it also and so the hack thinks this user is trying to get access to the bin which he doesnt have. Right?

This happened when their post was the only post in the topic. It has been fixed in version 0.1.2 (update instructions are provided in the "contrib" directory).
Ken F. Innes IV
My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

User avatar
Stitch625
Registered User
Posts: 683
Joined: Wed Jun 20, 2007 3:38 pm
Location: Michigan
Contact:

Re: [BETA] Prime Recycle Bin (0.1.2) - Delete Threads To a Forum

Postby Stitch625 » Thu Aug 16, 2007 3:43 am

Question...

When you delete a post it isn't really being deleted but actually sent to another forum untill you actually delete it correct? So am I correct in saying that just deleting a post to the specified forum will NOT affect the total post count or the total topic count?

User avatar
primehalo
Former Team Member
Posts: 2649
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [BETA] Prime Recycle Bin (0.1.2) - Delete Threads To a Forum

Postby primehalo » Thu Aug 16, 2007 3:54 am

Stitch625 wrote:Question...

When you delete a post it isn't really being deleted but actually sent to another forum untill you actually delete it correct? So am I correct in saying that just deleting a post to the specified forum will NOT affect the total post count or the total topic count?

Deleting a thread sends the thread to another forum while deleting a post just marks it as deleted and keeps it where it is. But you are correct that neither of these actions will affect the counts. The counts will only be affected when the topic or post is permanently deleted.
Ken F. Innes IV
My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

User avatar
Stitch625
Registered User
Posts: 683
Joined: Wed Jun 20, 2007 3:38 pm
Location: Michigan
Contact:

Re: [BETA] Prime Recycle Bin (0.1.2) - Delete Threads To a Forum

Postby Stitch625 » Thu Aug 16, 2007 5:10 am

Sweet! Sounds like a great mod. i think i may try it. Thanks for your reply and mod.

User avatar
RedTrinity
Registered User
Posts: 1327
Joined: Sat May 06, 2006 3:32 am

Re: [BETA] Prime Recycle Bin (0.1.2) - Delete Threads To a Forum

Postby RedTrinity » Thu Aug 16, 2007 5:25 am

What a brilliant idea for a mod, have been wanting something like this for a while! :) Well done, its fantastic!

I have a suggestion for future versions... maybe there is a way that you can also choose that if a thread is deleted or moved off the forum to the "Recycle" section, then a ghost topic can be left in its place (within viewforum) to explain the reason for the move?

Here is an example of what I mean with a different type of forum software: http://forums.whirlpool.net.au/forum-threads.cfm?f=35

See how there is grey ghost threads with reasons for the deletion? (or its a redirection for duplicate topics etc) And it also suggests to the user that they contact a moderator to discuss the decision.

Just a suggestion anyway, don't know how hard it would be to implement but its something I have always thought was a great idea on the above forum, and your thread is definately on the right track to similar proceedures iykwim.

Cheers,

RT.

azzurri
Registered User
Posts: 887
Joined: Fri Jul 21, 2006 7:48 pm

Re: [BETA] Prime Recycle Bin (0.1.2) - Delete Threads To a Forum

Postby azzurri » Thu Aug 16, 2007 7:45 am

Works perfectly now. Well done primehalo.

User avatar
playerfr
Registered User
Posts: 851
Joined: Fri Jul 18, 2003 9:50 am
Location: France - Paris
Contact:

Re: [BETA] Prime Recycle Bin (0.1.2) - Delete Threads To a Forum

Postby playerfr » Thu Aug 16, 2007 11:18 am

RedTrinity wrote:What a brilliant idea for a mod, have been wanting something like this for a while! :) Well done, its fantastic!

I have a suggestion for future versions... maybe there is a way that you can also choose that if a thread is deleted or moved off the forum to the "Recycle" section, then a ghost topic can be left in its place (within viewforum) to explain the reason for the move?

Here is an example of what I mean with a different type of forum software: http://forums.whirlpool.net.au/forum-threads.cfm?f=35

See how there is grey ghost threads with reasons for the deletion? (or its a redirection for duplicate topics etc) And it also suggests to the user that they contact a moderator to discuss the decision.

Just a suggestion anyway, don't know how hard it would be to implement but its something I have always thought was a great idea on the above forum, and your thread is definately on the right track to similar proceedures iykwim.

Cheers,

RT.


Brilliant idea of leaving the shadow with reason of deletation. It must be an Option as some time you really need to delete it as it is spam message.
All kind of help for your Forums / Sites. Installing for you the forum, the Mods, creating Custom Mods : for small fee http://www.phpbbhelpers.com

User avatar
primehalo
Former Team Member
Posts: 2649
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [BETA] Prime Recycle Bin (0.1.2a) - Delete Threads To a Foru

Postby primehalo » Fri Aug 17, 2007 8:12 am

A reason for the deleting would definitely be useful, and I'm currently working on a MOD that will allow a user to enter a reason for moving a post, so since deleting a thread with the Recycle Bin MOD is really just a shortcut to moving it to a forum I suspect it will be easy to integrate the two.

As for leaving a shadow behind, I suppose I could add that option to allow that. Shouldn't be too hard.

I've updated the MOD to version 0.1.2a to fix a W3C validation issue. No functionality was affected, and updating is easy. Just download the new version and copy
root/styles/prosilver/template/prime_recycle_bin_confirm.html
to
styles/prosilver/template/prime_recycle_bin_confirm.html

Then do the same with subsilver2.
Ken F. Innes IV
My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

User avatar
IPB_Refugee
Registered User
Posts: 1290
Joined: Fri Jul 07, 2006 2:25 pm
Location: Austria
Name: Wolfgang Weber

Re: [BETA] Prime Recycle Bin (0.1.2a) - Delete Threads To a Foru

Postby IPB_Refugee » Fri Aug 17, 2007 1:36 pm

primehalo wrote:As for leaving a shadow behind, I suppose I could add that option to allow that. Shouldn't be too hard.


I think it would be a nice feature. But if it creates too many new queries it should not be implanted IMHO.

Have a nice weekend!
Wolfgang

User avatar
iyeru42
Registered User
Posts: 1120
Joined: Wed Feb 01, 2006 7:22 pm
Location: Madison, WI
Contact:

Re: [BETA] Prime Recycle Bin (0.1.2a) - Delete Threads To a Foru

Postby iyeru42 » Fri Aug 17, 2007 3:03 pm

IPB_Refugee wrote:
primehalo wrote:As for leaving a shadow behind, I suppose I could add that option to allow that. Shouldn't be too hard.


I think it would be a nice feature. But if it creates too many new queries it should not be implanted IMHO.

Have a nice weekend!
Wolfgang


Shadow posts would leave behind too many queries IMO. Shadow topics should utilize the current topic shadow system.
My Website | My MOD Requests | Foreign Key Docs (some topics are not requests)
"It's easy to rebel, but it's hard to be recognized."


Return to “[3.0.x] MODs in Development”

Who is online

Users browsing this forum: No registered users and 33 guests