[MODDB] Prime Trash Bin - Keep deleted topics & posts

A place for MOD Authors to post and receive feedback on MODs still in development. No MODs within this forum should be used within a live environment!
Ideas Centre
Locked
User avatar
primehalo
Former Team Member
Posts: 2850
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Post by primehalo »

spaceace wrote:i've been trying to figure out how to have it set that only founders can permanently delete posts/topics and not other admins. i've been all over the permissions and other admins can still delete posts :x
You'd have to change the m_delete_forever column of the phpbb_acl_options table so that it is for founders only.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!


User avatar
IPB_Refugee
Registered User
Posts: 1290
Joined: Fri Jul 07, 2006 2:25 pm
Location: Austria
Name: Wolfgang Weber

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Post by IPB_Refugee »

Hi Ken,

today I got a debug notice caused by your MOD. What did I do?

- I duplicated a topic which has two pages into another forum
- I went into the topic and from there into the MCP: mode=topic_view
- From the second page of the topic I deleted all posts except two. This deletion was a deletion forever, not a "soft" deletion.
- I went on the first page of the topic in MCP, selected ALL posts there and "soft deleted" them by using your MOD.

It has worked, but I got the following debug notice:
[phpBB Debug] PHP Notice: in file /viewtopic.php on line 1873: Undefined variable: last_post
I also get this notice when I look at the topic at the viewtopic page.

These are the lines 1870-1874 in my viewtopic.php:

Code: Select all

//-- mod: Prime Quick Reply -------------------------------------------------//
include($phpbb_root_path . 'includes/prime_quick_reply.' . $phpEx);
$prime_quick_reply = new prime_quick_reply();
$prime_quick_reply->display_form($topic_id, $forum_id, $topic_data, $last_post);
//-- end: Prime Quick Reply -------------------------------------------------//
Yes, that's the piece of code which includes your Quick Reply MOD but I guess the debug notice is caused by your Trash Bin MOD. (Or it's a bug in Olympus itself.)

Regards
Wolfgang

EDIT: I restored the 4th post on page 1 of the topic now, and the debug notice disappeared.

User avatar
primehalo
Former Team Member
Posts: 2850
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Post by primehalo »

Try changing $last_post to:

Code: Select all

($last_post = $last_post ? $last_post : null)
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

User avatar
IPB_Refugee
Registered User
Posts: 1290
Joined: Fri Jul 07, 2006 2:25 pm
Location: Austria
Name: Wolfgang Weber

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Post by IPB_Refugee »

Hi Ken,

no more debug notice in MCP but unfortunately still in viewtopic. I changed line 1873 to

Code: Select all

$prime_quick_reply->display_form($topic_id, $forum_id, $topic_data, ($last_post = $last_post ? $last_post : null));
and after doing (nearly) the same as yesterday, I got
[phpBB Debug] PHP Notice: in file /viewtopic.php on line 1873: Undefined variable: last_post
again.

Regards
Wolfgang

EDIT:
From the second page of the topic I deleted all posts except two. This deletion was a deletion forever, not a "soft" deletion.
Maybe I should mention that I also "hard" deleted the last post on page two and therefore the last post of the topic.

User avatar
primehalo
Former Team Member
Posts: 2850
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Post by primehalo »

Okay, try this instead:

Code: Select all

($last_post = isset($last_post) ? $last_post : null) 
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

User avatar
IPB_Refugee
Registered User
Posts: 1290
Joined: Fri Jul 07, 2006 2:25 pm
Location: Austria
Name: Wolfgang Weber

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Post by IPB_Refugee »

Fine, Ken - that fixed the bug! :)

Thank you!
Wolfgang

DJ Skitzo
Registered User
Posts: 596
Joined: Sun Aug 12, 2007 7:25 pm

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Post by DJ Skitzo »

Hi,

I'm not sure whether this is the best place to post this, but Primehalo would it be possible for you to add the feature to this MOD so that it would be compatible with Handyman's MOD Version Check which can be found here: http://www.phpbb.com/mods/db/index.php? ... ib_id=3177

Thanks

User avatar
primehalo
Former Team Member
Posts: 2850
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Post by primehalo »

This has been asked by people for some of my other MODs as well, but unfortunately it's not going to happen until something like this is implemented: http://www.phpbb.com/community/viewtopi ... 5#p3979355
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

DJ Skitzo
Registered User
Posts: 596
Joined: Sun Aug 12, 2007 7:25 pm

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Post by DJ Skitzo »

primehalo wrote:This has been asked by people for some of my other MODs as well, but unfortunately it's not going to happen until something like this is implemented: http://www.phpbb.com/community/viewtopi ... 5#p3979355
Ahh, ok then.

I just read through that topic and it seems that Handyman likes your idea and he is going to update his MOD.

Bv202
Registered User
Posts: 109
Joined: Tue Jun 24, 2008 12:32 pm

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Post by Bv202 »

I'm getting this error when perm deleting a post in some forums:

Code: Select all

SQL ERROR [ mysqli ]

[0]

SQL

No values specified for SQL IN comparison

BACKTRACE

FILE: includes/db/dbal.php
LINE: 385
CALL: dbal->sql_error()

FILE: includes/functions_autogroup.php
LINE: 49
CALL: dbal->sql_in_set()

FILE: includes/functions_admin.php
LINE: 724
CALL: auto_group()

FILE: includes/functions_posting.php
LINE: 1399
CALL: delete_posts()

FILE: posting.php
LINE: 1458
CALL: delete_post()

FILE: posting.php
LINE: 282
CALL: handle_post_delete()
Any way to solve this?
EDIT:
I only get this in forums where postcount = disabled. :?

User avatar
primehalo
Former Team Member
Posts: 2850
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Post by primehalo »

For that error message you provided, I don't see any reference to any function used in this MOD. Perhaps the error is coming from the Auto Groups MOD?
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

mtrs
Registered User
Posts: 2049
Joined: Sat Sep 22, 2007 2:39 pm

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Post by mtrs »

I didn't read the posts, sorry if that is asked before.
if I delete a user with messages, after installing this mod, will the messages be deleted softly or permanently? Thanks..
I abandoned all of my mods.

User avatar
primehalo
Former Team Member
Posts: 2850
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Post by primehalo »

You get to choose.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

User avatar
IPB_Refugee
Registered User
Posts: 1290
Joined: Fri Jul 07, 2006 2:25 pm
Location: Austria
Name: Wolfgang Weber

Re: [BETA] Prime Recycle Bin (0.1.6) - Delete Threads To a Forum

Post by IPB_Refugee »

Hi Ken!
primehalo wrote:Moderators are not supposed to be able to permanently delete posts unless they have the ability to permanently delete threads from the recycle bin forum. Is that still not working right?
I have a problem: My moderators are able to permanently delete posts. Both moderators are global moderators but without the right to permanently delete posts. And both have some admin privileges (one is a User & Group admin, the other one is a User & Group & Forums admin.)

Now I made my testuser a User & Group admin, too. He wasn't able to delete other user's posts. Then I made him also a forum moderator in one of the forums (not in the recycle bin forum). The testuser doesn't have the right to permanently delete posts in the forum which he is able to moderate. And he still is not a moderator in the recycle bin forum. But now he is able to permanently delete posts...

Is this a bug or what should I do that he cannot "hard" delete posts anymore?

Regards
Wolfgang

Locked

Return to “[3.0.x] MODs in Development”