Page 28 of 51

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Posted: Fri Aug 22, 2008 12:02 am
by primehalo
Open includes/prime_trash_bin.php and find this:

Code: Select all

                // Permanent Deletion
                case 'delete':
                    $permission = $auth->acl_get('a_', $forum_id);
 
That gives admins the right to delete. Try changing it to:

Code: Select all

                // Permanent Deletion
                case 'delete':
                    //$permission = $auth->acl_get('a_', $forum_id);
 
This should allow only those users with the permanent delete permission.

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Posted: Fri Aug 22, 2008 4:51 pm
by IPB_Refugee
Thank you, Ken!

I followed your suggestion and also changed the next line to

Code: Select all

					$permission = $auth->acl_get('m_delete_forever', $forum_id);
Now it works as I expected.

Have a nice weekend!
Wolfgang

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Posted: Sat Aug 23, 2008 6:13 am
by eman80
Hi primehalo

Thank u for this great mod

I just installed v 1.0.3 and it works fine, but I found a small problem:

When I choose more than one topic to delelet, the mod works fine

But

when I choose only one topic to delete .. the options of mod do not appear to me
just said : Are you sure you want to delete this topic? .. Just like the original mode for the forum


any way to solve this?

thanks and sorry for my humble english.

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Posted: Sat Aug 23, 2008 6:38 am
by primehalo
Sorry about that. Just got it fixed. Version 1.0.4. Update by copying over the new includes/prime_trash_bin_2.php file.

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Posted: Sat Aug 23, 2008 2:17 pm
by eman80
primehalo wrote:Sorry about that. Just got it fixed. Version 1.0.4. Update by copying over the new includes/prime_trash_bin_2.php file.
Thank you Ken .. everything is working perfect now :)

Regards

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Posted: Sat Aug 23, 2008 9:01 pm
by Sunka
Hi Primehalo...again...LOL
How to update from v1.0.2 to v1.0.4
I have to ask because there is not update instructions in ZIP

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Posted: Sat Aug 23, 2008 9:44 pm
by cprgolds
Great MOD. Appreciate all the great work on this.

I have run into a couple of minor issues related to posts that are "soft deleted" from forums that are subsequently deleted.
  1. If the phpbb_topics.topic_deleted_from value is for a forum that no longer exists, the deleter's name is displayed as 'guest'.
  2. If the phpbb_topics.topic_deleted_from value is for a forum that no longer exists, and someone tries to undelete the topic, it is restored to the no longer displayed forum and can no longer be found without going directly into the sql database.

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Posted: Sun Aug 24, 2008 12:18 am
by primehalo
Version 1.0.5
  • Fixed a bug where deleting topics to the Trash Bin forum, then deleting the forum from which they were deleted, then undeleting the topics would cause them to be moved to the forum which no longer exists, thus making them inaccessible except through directly accessing the database.
  • Fixed a string in the language file which referenced the Trash Bin forum as the Recycle Bin forum (the name change happened a while back; I'm stunned it took me this long to notice the mistake).
Update instructions are in the contrib folder. Unfortunately, the bug fix will not correct topics that were already deleted before the fix was applied.

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Posted: Sun Aug 24, 2008 12:45 am
by mcdanielnc89
Upon instlaling this MOD when it's released, will it tell us to create a new forum category?

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Posted: Sun Aug 24, 2008 1:27 am
by cprgolds
primehalo wrote:Unfortunately, the bug fix will not correct topics that were already deleted before the fix was applied.
However, it is not THAT difficult to go into the database and edit any hosed topics to fix this.

Thanks for the quick fix!

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Posted: Sun Aug 24, 2008 6:22 am
by primehalo
mcdanielnc89 wrote:Upon instlaling this MOD when it's released, will it tell us to create a new forum category?
Nope.

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Posted: Sun Aug 24, 2008 2:47 pm
by iyeru42
primehalo wrote:
mcdanielnc89 wrote:Upon instlaling this MOD when it's released, will it tell us to create a new forum category?
Nope.
Will it auto-create a forum?

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Posted: Sun Aug 24, 2008 3:23 pm
by Bv202
Hi,

I'm still running version 1.0.2 on my board and I want to update it to 1.0.5. Are there any instructions for that? The contrib folder only contains 1.0.4->1.0.5, not the older 1.0.2->1.0.3 and 1.0.3->1.0.4.

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Posted: Sun Aug 24, 2008 4:16 pm
by IPB_Refugee
iyeru42 wrote:
primehalo wrote:
mcdanielnc89 wrote:Upon instlaling this MOD when it's released, will it tell us to create a new forum category?
Nope.
Will it auto-create a forum?
No, but you can use an existing forum as recycle bin forum. Or you create a new one. It's completely up to you.

Regards
Wolfgang

Re: [BETA] Prime Trash Bin - Keep deleted topics & posts

Posted: Sun Aug 24, 2008 6:08 pm
by primehalo
Bv202 wrote:Hi,

I'm still running version 1.0.2 on my board and I want to update it to 1.0.5. Are there any instructions for that? The contrib folder only contains 1.0.4->1.0.5, not the older 1.0.2->1.0.3 and 1.0.3->1.0.4.
When there are no upgrade instructions, it usually means you only need to copy over the new versions of the files.