[RC] Prime Post Revisions - View all edits to posts

[primehalo]

MOD Title: Prime Post Revisions
MOD Description: This MOD will store each revision of a post every time a post is edited. It will only make these past revisions viewable to those users that have permissions allowing them to view the post information (basically, moderators and administrators).
MOD Version: (view the Installation Instructions for latest version number).
MOD Download: Main Download Site
Demo Board: http://www.absoluteanime.com/forum/viewforum.php?f=95
Demo Username: tester
Demo Password: tester

For the release history, please view the Installation Instructions.

Screenshots
On the active post:


On the post revision history page:

[nuclearw]

I've been using bb3 for a few months now, I love this module. One bug i noticed was when moving or deleting posts I get the following error:


SQL ERROR [ mysqli ]

Unknown column 'topic_id' in 'where clause' [1054]

SQL

UPDATE phpbb_post_revisions SET forum_id = 2 WHERE topic_id = '1467'

BACKTRACE

does post_id = topic_id ?

[playerfr]

nice feature

[primehalo]

I've been using bb3 for a few months now, I love this module. One bug i noticed was when moving or deleting posts I get the following error:


SQL ERROR [ mysqli ]

Unknown column 'topic_id' in 'where clause' [1054]

SQL

UPDATE phpbb_post_revisions SET forum_id = 2 WHERE topic_id = '1467'

BACKTRACE

does post_id = topic_id ?

I don't even recognize that SQL statement. I searched through all the PHP and I never see the POST_REVISIONS_TABLE in an SQL statement that contains an UPDATE or a SET forum_id.

Can you provide more information? I have not been able to get this bug to happen, no matter how many times I edit then move or delete posts and/or topics. Do you have other MODs installed that changed some SQL statements? The code that handles deletion is in "includes/functions_admin.php":

Code: Select all

	$table_ary = array(POSTS_TABLE, REPORTS_TABLE);
//-- mod: Prime Post Revisions ----------------------------------------------//
	$table_ary[] = POST_REVISIONS_TABLE; // To delete the post's edit history
//-- end: Prime Post Revisions ----------------------------------------------//

	foreach ($table_ary as $table)
	{
		$sql = "DELETE FROM $table 
			WHERE " . $db->sql_in_set('post_id', $post_ids);
		$db->sql_query($sql);
	}
	unset($table_ary);

Check and see if anything has been modified near that point.

[playerfr]

Prime do you plan to progress on this Mod ? or it will stay like this ?

Thanks

[IPB_Refugee]

Another great MOD, primehalo! Thank you!

How many additional queries does your MOD add to the viewtopic pages?

Let's say there are 15 posts on a viewtopic page, one post has been edited 10 times and another post 3 times. What's the impact on the number of queries?

Kind regards
Wolfgang

[Omarvelous]

Prime... you make some mighty fine Mods!!

Nice work!

[primehalo]

Prime do you plan to progress on this Mod ? or it will stay like this ?

There didn't appear to be much interest in it. What suggestions would you have?

How many additional queries does your MOD add to the viewtopic pages?

With version 0.0.2, there is only one extra query for determining which posts have revisions.

Prime... you make some mighty fine Mods!!

Nice work!

Thanks!

[IPB_Refugee]

Just one additional query? Great!

Prime do you plan to progress on this Mod ? or it will stay like this ?

There didn't appear to be much interest in it.

Oh, there are surely people who are interested in your MOD:

http://www.phpbb.com/community/viewtopi ... 2&t=577072
http://www.phpbb.com/community/viewtopi ... 0&t=572129

Although I am nearly every day here at phpBB.com I have complete overlooked this MOD. I don't know why. But I'm glad I found it now.

Regards
Wolfgang

[LRdM]

Thanks for the mod! I've just installed this as well as Prime Recycle Bin as IPB_Refugee was kind enough to let me know about both of them. I have encountered this Unknown column 'topic_id' in 'where clause' [1054] error as well.

I get the following error when I try to first delete a post, just after I submit the form asking for reasons why the post is being deleted. The post does still arrive in the recycling bin. The query is

posting.php?mode=delete&f=5&p=1807&_f_=5x&confirm_key=3BGI4MWMV3

Code: Select all

General Error
SQL ERROR [ mysql4 ]

Unknown column 'topic_id' in 'where clause' [1054]

SQL

UPDATE phpbb3_post_revisions SET forum_id = 38 WHERE topic_id = 297

BACKTRACE

FILE: includes/db/mysql.php
LINE: 133
CALL: dbal->sql_error()

FILE: includes/functions_admin.php
LINE: 444
CALL: dbal_mysql->sql_query()

FILE: includes/prime_recycle_bin.php
LINE: 334
CALL: move_topics()

FILE: includes/functions_posting.php
LINE: 1347
CALL: recycle_topic()

FILE: posting.php
LINE: 1481
CALL: delete_post()

FILE: posting.php
LINE: 299
CALL: handle_post_delete()

[primehalo]

Sorry, it is an error in the installation instructions. The part that tells you to open "functions_posting.php" and find "$table_ary = array" should be
find

Code: Select all

	$table_ary = array(POSTS_TABLE, REPORTS_TABLE);

[LRdM]

functions_admin.php or functions_posting.php? So...

Code: Select all

Open: includes/functions_admin.php
Find

Tip: This may be a partial find and not the whole line.
Code: Select All

	$table_ary = array

Add after

Tip: Add these lines on a new blank line after the preceding line(s) to find.
Code: Select All

//-- mod: Prime Post Revisions ----------------------------------------------//
	$table_ary[] = POST_REVISIONS_TABLE; // To delete the post's edit history
//-- end: Prime Post Revisions ----------------------------------------------//

should read...

Code: Select all

Open: includes/functions_admin.php
Find

Tip: This may be a partial find and not the whole line.
Code: Select All

	$table_ary = array(POSTS_TABLE, REPORTS_TABLE);

Add after

Tip: Add these lines on a new blank line after the preceding line(s) to find.
Code: Select All

//-- mod: Prime Post Revisions ----------------------------------------------//
	$table_ary[] = POST_REVISIONS_TABLE; // To delete the post's edit history
//-- end: Prime Post Revisions ----------------------------------------------//

?

[primehalo]

Oops, screwed up again, you're right it's functions_admin.php

[playerfr]

Thats why I asked if there was a new version. It was for bug corrections New function I dont as it has already what is needed

[Amezis]

Nice feature!! I will add this to my board whenever this isn't beta anymore (the boards are heavily modded already, so I want only stable mods from now on to avoid possible errors). Also, your Prime recycle bin mod looks great! Keep up the work on both