Page 9 of 21

Re: [RC] Prime Post Revisions - View all edits to posts

Posted: Mon Sep 22, 2008 2:37 pm
by Acorn
This is a fantastic mod - thanks very much.

I gather that you can restrict the ability to view post history to just admins rather than admins and moderators, but I can't see how to change this. Apologies if this is obvious to others - I'm only just getting used to phpBB3.

Thanks.

Re: [RC] Prime Post Revisions - View all edits to posts

Posted: Mon Sep 22, 2008 2:54 pm
by demon327
Acorn wrote:This is a fantastic mod - thanks very much.

I gather that you can restrict the ability to view post history to just admins rather than admins and moderators, but I can't see how to change this. Apologies if this is obvious to others - I'm only just getting used to phpBB3.

Thanks.
the settings are in the included fucntions file :)

Re: [RC] Prime Post Revisions - View all edits to posts

Posted: Mon Sep 22, 2008 3:27 pm
by Acorn
Aah - I've got it. It's in /includes/prime_post_revisions.php - beautifully clear. Thanks. 8-)

Re: [RC] Prime Post Revisions - View all edits to posts

Posted: Mon Sep 22, 2008 3:40 pm
by Acorn
I've changed
define('APPROVE_REMOVAL_MODERATOR', true); // Can moderators (with the ability to delete posts) remove revisions?
in /includes/prime_post_revisions.php to
define('APPROVE_REMOVAL_MODERATOR', false); // Can moderators (with the ability to delete posts) remove revisions?
but my global moderator can still view post history.

Is there something else I need to do? :?

Re: [RC] Prime Post Revisions - View all edits to posts

Posted: Mon Sep 22, 2008 8:55 pm
by primehalo
As the comment next to that define indicates, changing it will only affect whether or not moderators have the ability to delete the post history. It has no effect on whether they can see it or not. The way it is currently set up, moderators that can view the post's information can also view the history.

Re: [RC] Prime Post Revisions - View all edits to posts

Posted: Mon Sep 22, 2008 9:41 pm
by Acorn
Can I prevent moderators from seeing the post history?

Re: [RC] Prime Post Revisions - View all edits to posts

Posted: Mon Sep 22, 2008 9:53 pm
by primehalo
You would need to change this line to something else:

Code: Select all

            if (($this->approve_viewing = $auth->acl_get('m_info', $forum_id)) || APPROVE_VIEWING_POSTER) 

Re: [RC] Prime Post Revisions - View all edits to posts

Posted: Tue Sep 23, 2008 7:37 am
by Acorn
Brilliant - that seems to have sorted it.

For anyone else wanting to do the same thing, I changed

Code: Select all

if (($this->approve_viewing = $auth->acl_get('m_info', $forum_id)) || APPROVE_VIEWING_POSTER) 

in /includes/prime_post_revisions.php to

Code: Select all

if (($this->approve_viewing = $auth->acl_get('a_')) || APPROVE_VIEWING_POSTER) 

Re: [RC] Prime Post Revisions - View all edits to posts

Posted: Wed Sep 24, 2008 9:45 am
by IPB_Refugee
Hi Ken,

I think this setting doesn't work as it should:

Code: Select all

define('SUBJECT_CHANGE_REVISION', false);		// Store a revision when only the subject has been changed?
I changed only the title of an old topic a few minutes ago and the revision has been stored. (Or has something else also changed automatically and I didn't notice it? The board is upgraded from phpBB 2.0.23.)

Regards
Wolfgang

Re: [RC] Prime Post Revisions - View all edits to posts

Posted: Fri Sep 26, 2008 1:20 am
by primehalo
Got it fixed in version 1.2.3.

Re: [RC] Prime Post Revisions - View all edits to posts

Posted: Fri Sep 26, 2008 9:09 am
by IPB_Refugee
Hi Ken,

thank you! It's much better now but unfortunately still not perfect.

Example: I changed the title of an old topic and no revision has been stored. A minute later I changed the title back to the original one and this time the revision has been stored. Both times I just changed the topic's title.

Regards
Wolfgang

Re: [RC] Prime Post Revisions - View all edits to posts

Posted: Sat Sep 27, 2008 8:22 pm
by Daan1992
Is it possible to compare the the original and the most recent post en making the differents in another color?

Re: [RC] Prime Post Revisions - View all edits to posts

Posted: Mon Oct 06, 2008 6:28 pm
by primehalo
Daan1992 wrote:Is it possible to compare the the original and the most recent post en making the differents in another color?
Not for me. I don't have the time to write that kind of algorithm.

Re: [RC] Prime Post Revisions - View all edits to posts

Posted: Wed Oct 08, 2008 7:09 pm
by DoYouSpeakWak
Hey primehalo (and everybody else)

We have used this mod for the past month or so and it works great. But i was wondering if you could have a button besides the Edit button that only showed if the post had a history to read. Just like the text link now, but without the text in front of it and as a image. The move should be to hard.

DYSW

Re: [RC] Prime Post Revisions - View all edits to posts

Posted: Thu Oct 09, 2008 6:42 am
by primehalo
I don't think I would do that personally, as I hate having to create images for each separate style. But it shouldn't be too hard to implement if you want to attempt it yourself.