
I hate to mention it, but I don't see these. I've checked Admin and Global Mod permissions for new fields, and even started a new test topic with multiple revisions. But my Admin user account still just sees the "Delete" button on each post. I also checked the quick mod tools, and didn't see an entry for either feature.primehalo wrote:Version 1.2.0:
- Added an option to delete all revisions (will not delete the actual post).
- Added an option to undo the most recent revision to the post.
The REVISION_PAGE_HEADER must be set to true in order for you to see the Delete All Revisions link, because it appears within that block.Jaga wrote:I hate to mention it, but I don't see these. I've checked Admin and Global Mod permissions for new fields, and even started a new test topic with multiple revisions. But my Admin user account still just sees the "Delete" button on each post. I also checked the quick mod tools, and didn't see an entry for either feature.primehalo wrote:Version 1.2.0:
- Added an option to delete all revisions (will not delete the actual post).
- Added an option to undo the most recent revision to the post.
Note: I followed the upgrade routine from 1.0.0
Here is my german translation for folder language/de/mods:[phpBB Debug] PHP Notice: in file /viewtopic.php on line 1397: Undefined index: 2
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 3694: Cannot modify header information - headers already sent by (output started at /includes/functions.php:3014)
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 3696: Cannot modify header information - headers already sent by (output started at /includes/functions.php:3014)
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 3697: Cannot modify header information - headers already sent by (output started at /includes/functions.php:3014)
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 3698: Cannot modify header information - headers already sent by (output started at /includes/functions.php:3014)
Code: Select all
<?php
/**
*
* prime_post_revisions [English]
*
* @package language
* @version $Id: prime_post_revisions.php,v 1.2.0 2008/07/21 13:45:00 primehalo Exp $
* @copyright (c) 2007-2008 Ken F. Innes IV
* @license http://opensource.org/licenses/gpl-license.php GNU Public License
*
*/
/**
* DO NOT CHANGE
*/
if (!defined('IN_PHPBB'))
{
exit;
}
if (empty($lang) || !is_array($lang))
{
$lang = array();
}
// DEVELOPERS PLEASE NOTE
//
// All language files should use UTF-8 as their encoding and the files must not contain a BOM.
//
// Placeholders can now contain order information, e.g. instead of
// 'Page %s of %s' you can (and should) write 'Page %1$s of %2$s', this allows
// translators to re-order the output of data while ensuring it remains correct
//
// You do not need this where single placeholders are used, e.g. 'Message %d' is fine
// equally where a string contains only two placeholders which are used to wrap text
// in a url you again do not need to specify an order e.g., 'Click %sHERE%s' is fine
//
// Some characters you may want to copy&paste:
// ’ » “ ” …
//
$lang = array_merge($lang, array(
// Viewing posts
'PRIME_POST_REVISIONS_VIEW' => 'Zeige Beitragsversionen', // Text for the link to view the revision history
// Viewing revisions
'PRIME_POST_REVISIONS_VIEWING' => 'Betrachtet Beitragsversionen',
'PRIME_POST_REVISIONS_VIEWING_EXPLAIN' => 'Diese Seite zeigt alle Versionen des Beitrags, beginnend mit der aktuellsten Version.',
'PRIME_POST_REVISIONS_TITLE' => 'Überblick der Beitragsversionen: %s', // The %s is the post title
'PRIME_POST_REVISIONS_FIRST' => 'Ursprünglicher Beitrag: %s', // The %s is the post title
'PRIME_POST_REVISIONS_FINAL' => 'Aktueller Beitrag: %s', // The %s is the post title
'PRIME_POST_REVISIONS_COUNT' => 'Version %d: %s', // The %s is the post title
'PRIME_POST_REVISIONS_INFO' => 'Editiert von %1$s am %2$s.',
'PRIME_POST_REVISIONS_NO_SUBJECT' => '[kein Titel]',
// Delete a revision
'PRIME_POST_REVISIONS_DELETE' => 'Lösche Version',
'PRIME_POST_REVISIONS_DELETE_CONFIRM' => 'Bist du sicher, dass du diese Beitragsversion löschen willst?',
'PRIME_POST_REVISIONS_DELETE_DENIED' => 'Du besitzt nicht die erforderlichen Rechte zur Löschung dieser Beitragsversion.',
'PRIME_POST_REVISIONS_DELETE_FAILED' => 'Ein Fehler ist beim Versuch, die Beitragsversion zu löschen, aufgetreten.',
'PRIME_POST_REVISIONS_DELETE_SUCCESS' => 'Die Beitragsversion wurde erfolgreich gelöscht.',
'PRIME_POST_REVISIONS_DELETE_INVALID' => 'Es wurde keine Beitragsversion für die Löschung ausgewählt.',
// Delete all revisions
'PRIME_POST_REVISIONS_DELETES' => 'Lösche alle Versionen',
'PRIME_POST_REVISIONS_DELETES_CONFIRM' => 'Bist du sicher, dass du diese Beitragsversionen löschen willst?',
'PRIME_POST_REVISIONS_DELETES_DENIED' => 'Du besitzt nicht die erforderlichen Rechte zur Löschung dieser Beitragsversionen.',
'PRIME_POST_REVISIONS_DELETES_FAILED' => 'Ein Fehler ist beim Versuch, diese Beitragsversionen zu löschen, aufgetreten.',
'PRIME_POST_REVISIONS_DELETES_SUCCESS' => 'Die Beitragsversionen wurden erfolgreich gelöscht.',
'PRIME_POST_REVISIONS_DELETES_INVALID' => 'Es wurden keine Beitragsversionen für die Löschung ausgewählt.',
));
?>
Code: Select all
$user_cache[$row['post_edit_user']] = $post_edit_list[$row['post_edit_user']];
Code: Select all
trigger_error(str_replace("\n", '<br />', print_r($post_edit_list, true)));
It's also strange, that the edit text on the viewtopic page before I edited the post told:Array
(
[18] => Array
(
[user_id] => 18
[username] => Mister X
[user_colour] => F87500
)
)
And now, after my edition it tells:Last changed by Mister X on 11.09.2007, 14:03, edited 1 time.
But I had a similiar MOD like Prime Post Editions installed on my phpBB-2 board. Maybe that causes the problems I have and that fortunately only occur in special cases (when the post had already been edited in the phpBB-2 board.)Last changed by IPB_Refugee on 23.07.200, 01:10, edited 1 time.
Try this for me...IPB_Refugee wrote:This is what I got:
Array
(
[18] => Array
(
[user_id] => 18
[username] => Mister X
[user_colour] => F87500
)
)
Code: Select all
else if ($this->approve_viewing || APPROVE_VIEWING_POSTER)
Code: Select all
if ($this->approve_viewing || APPROVE_VIEWING_POSTER)
Code: Select all
}
/**
* Inject user data into the $post_edit_list and $user_cache tables if it does not already exist.
*/
Code: Select all
else if ($this->viewing_history)
{
$row['post_edit_count'] = 0;
$row['post_edit_reason'] = ''
}
Well, I don't know why it would be cutting off the last digit of the year, but the number of edits makes sense to me. The board keeps track of how many edits were made, but only sometimes, under the right circumstances. This number is stored in the POSTS table. My MOD keeps track of all edits for a post, assuming an edit was actually made (which isn't always the case, as the edit might just be changing it from normal to global, or just adding a reason for editing without actually changing anything). So my edit count comes from how many edits are stored in the POST_REVISIONS table. If that value is greater than the one stored in the POSTS table, then it is displayed, otherwise I display the number stored in the POSTS table.IPB_Refugee wrote:It's also strange, that the edit text on the viewtopic page before I edited the post told:And now, after my edition it tells:Last changed by Mister X on 11.09.2007, 14:03, edited 1 time.But I had a similiar MOD like Prime Post Editions installed on my phpBB-2 board. Maybe that causes the problems I have and that fortunately only occur in special cases (when the post had already been edited in the phpBB-2 board.)Last changed by IPB_Refugee on 23.07.200, 01:10, edited 1 time.
Regards
Wolfgang
Hi Ken,primehalo wrote:Open prime_post_revisions.php
Find:Replace with:Code: Select all
else if ($this->approve_viewing || APPROVE_VIEWING_POSTER)
Code: Select all
if ($this->approve_viewing || APPROVE_VIEWING_POSTER)
My mistake, when I translated the sentence.primehalo wrote:Well, I don't know why it would be cutting off the last digit of the year ...
The numer of edits is still not correct when I edit a post that had already been edited back in the days of phpBB-2. Let's say the previous number of edits was 2, and after editing the post again now, the number is still 2. In fact, I had to edit this post three times today before it showed that number (3 edits). I guess, your MOD always adds 1 after an edit only to POST_REVISIONS table and not to POSTS table, too. But that's a minor problem.primehalo wrote:So my edit count comes from how many edits are stored in the POST_REVISIONS table. If that value is greater than the one stored in the POSTS table, then it is displayed, otherwise I display the number stored in the POSTS table.
My MOD doesn't add or alter anything to the POSTS table (except when deleting post revisions). I choose to do it like this because I didn't want to overrule the board's settings. For instance, if a user edits their post shortly after they post it, often the board won't keep track of the edit and thus won't display the message that it has been edited. I think most people like this, as they won't constantly have to see that message whenever someone quickly corrects a spelling error or whatever. However, my MOD stores the edit, so if you're allowed to view the revisions then my MOD takes over and you'll see the message that the post was edited.IPB_Refugee wrote:The numer of edits is still not correct when I edit a post that had already been edited back in the days of phpBB-2. Let's say the previous number of edits was 2, and after editing the post again now, the number is still 2. In fact, I had to edit this post three times today before it showed that number (3 edits). I guess, your MOD always adds 1 after an edit only to POST_REVISIONS table and not to POSTS table, too. But that's a minor problem.primehalo wrote:So my edit count comes from how many edits are stored in the POST_REVISIONS table. If that value is greater than the one stored in the POSTS table, then it is displayed, otherwise I display the number stored in the POSTS table.
Thanks again!
Wolfgang
Code: Select all
SQL ERROR [ mysql4 ]
Incorrect string value: '\xD7\x9E\xD7\x96\xD7\x9C...' for column 'post_subject' at row 1 [1366]
I wonder why those were added as latin1_swedish_ci.... what method did you use for installing the database portions? Did you use the file or manually execute the sql from the instructions file?ibelphegor wrote:Install and have errorFor fix:Code: Select all
SQL ERROR [ mysql4 ] Incorrect string value: '\xD7\x9E\xD7\x96\xD7\x9C...' for column 'post_subject' at row 1 [1366]
Open phpadmin and click on "phpbb_post_revisions"
change:
post_subject, bbcode_uid And post_edit_reason from "latin1_swedish_ci" to "utf8_bin"
Regards,
uzi
manually execute the sql from the instructions file,primehalo wrote: I wonder why those were added as latin1_swedish_ci.... what method did you use for installing the database portions? Did you use the file or manually execute the sql from the instructions file?