[RC] Prime Topic Move - add a reason & link to move it back

A place for MOD Authors to post and receive feedback on MODs still in development. No MODs within this forum should be used within a live environment!
Anti-Spam Guide
Locked
User avatar
primehalo
Former Team Member
Posts: 2833
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

[RC] Prime Topic Move - add a reason & link to move it back

Post by primehalo » Fri Aug 17, 2007 11:10 pm

MOD Title: Prime Topic Moved
MOD Description: Provides the ability to enter a reason for moving a topic, the ability to display information about the move, and the ability to undo the move.
MOD Version: view the Installation Instructions for the latest version number
MOD Download: Main Download Site

Demo Board: http://www.AbsoluteAnime.com/forum/
Demo Username: tester
Demo Password: tester

For the release history, please view the Installation Instructions.

Topic Moved Info Form (ver. 0.1.5):
Image

Topic Moved Info Admin Options (ver. 0.1.5):
Image
Last edited by primehalo on Sat Apr 26, 2008 9:37 am, edited 9 times in total.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

RedTrinity
Registered User
Posts: 1327
Joined: Sat May 06, 2006 3:32 am

Re: [BETA] Prime Topic Moved Info (0.0.0)

Post by RedTrinity » Sat Aug 18, 2007 4:33 am

Oh awesome :D Will this MOD work ok alongside your Recycle Bin MOD? Or should I wait for it to be integrated as a later feature?

Thanks again, and great work :D

User avatar
primehalo
Former Team Member
Posts: 2833
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [BETA] Prime Topic Moved Info (0.0.0)

Post by primehalo » Sat Aug 18, 2007 4:43 am

Actually I just noticed a bug, so I'd recommend waiting at least until I get 0.0.1 uploaded which should be some time tonight. It is not yet integrated with the Recycle Bin MOD, but that's the next thing I'll work on after getting this fixed.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

RedTrinity
Registered User
Posts: 1327
Joined: Sat May 06, 2006 3:32 am

Re: [BETA] Prime Topic Moved Info (0.0.0)

Post by RedTrinity » Sat Aug 18, 2007 5:11 am

No worries Primehalo, look forward to it :)

User avatar
primehalo
Former Team Member
Posts: 2833
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [BETA] Prime Topic Moved Info (0.1.0)

Post by primehalo » Sat Aug 18, 2007 6:15 am

Okay, the version 0.1.0 is posted. Unfortunately, if you installed the previous version the easiest way to update is to just uninstall it and install the new version. Sorry about that, but most of the code got moved.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

User avatar
primehalo
Former Team Member
Posts: 2833
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [BETA] Prime Topic Moved Info (0.1.0)

Post by primehalo » Sat Aug 18, 2007 8:46 pm

Version 0.1.1 is now available, and is compatible with Prime Recycle Bin. You'll need to update Prime Recycle Bin as well. Update instructions are included in the "contrib" folder.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

RedTrinity
Registered User
Posts: 1327
Joined: Sat May 06, 2006 3:32 am

Re: [BETA] Prime Topic Moved Info (0.1.1)

Post by RedTrinity » Sun Aug 19, 2007 4:43 am

Ok I have upgraded Prime Recycle Bin to 0.1.4 and installed this MOD as well for the first time this afternoon, however am getting the following message when submitting the command to delete a topic...

Code: Select all

Fatal error: Call to undefined function: is_recycle_bin() in /home/****/public_html/phpbb3/includes/mcp/mcp_main.php on line 866
Where did I go wrong? :lol:

I think I also may have found a mistake in the instructions with the following line...

Code: Select all

Find
						'allow_birthdays'		=> array(
I couldn't find this line within my acp_board.php but I did find the following instead...

Code: Select all

						'load_birthdays'		=> array('lang' => 'YES_BIRTHDAYS',			'validate' => 'bool',	'type' => 'radio:yes_no', 'explain' => false),
Going by the fact the code to be added is very similar to the above, I am assuming that it may be a mistake?

Thanks in advance for your support :)

User avatar
primehalo
Former Team Member
Posts: 2833
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [BETA] Prime Topic Moved Info (0.1.1)

Post by primehalo » Sun Aug 19, 2007 6:17 am

The full line is

Code: Select all

						'allow_birthdays'		=> array('lang' => 'ALLOW_BIRTHDAYS',		'validate' => 'bool',	'type' => 'radio:yes_no', 'explain' => true),
and is found on line #76 of "includes/acp/acp_board.php" in a pure, un-modded phpBB3 RC4 release.

This "is_recycle_bin()" function is located in the included file "root/includes/prime_recycle_bin.php" which should have been copied to "includes/prime_recycle_bin.php". The following line is what includes that file, and should have been added above the function "function mcp_move_topic($topic_ids)" (which on an unmodded board you should find at line #523).

Code: Select all

//-- mod: Prime Recycle Bin -------------------------------------------------//
include($phpbb_root_path . 'includes/prime_recycle_bin.' . $phpEx);
//-- end: Prime Recycle Bin -------------------------------------------------//
Note that "includes/prime_recycle_bin.php" and "languages/en/mods/prime_recycle_bin.php" are different; they do have the same name so that could cause accidents if you copy one file into the other's directory.

Anyway, confirm that all those are correct and we can go from there.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

User avatar
nickvergessen
Former Team Member
Posts: 4397
Joined: Mon Apr 30, 2007 5:33 pm
Location: Stuttgart, Germany
Name: Joas Schilling
Contact:

Re: [BETA] Prime Topic Moved Info (0.1.1)

Post by nickvergessen » Sun Aug 19, 2007 6:55 am

Do you have a Link to a Moved topic,
Your Board is not very small and because of that i can't find one ^^
No Support via PM

User avatar
primehalo
Former Team Member
Posts: 2833
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [BETA] Prime Topic Moved Info (0.1.1)

Post by primehalo » Sun Aug 19, 2007 7:08 am

nickvergessen wrote:Do you have a Link to a Moved topic,
Your Board is not very small and because of that i can't find one ^^
The board at http://www.absoluteanime.com/forum.php is still phpbb2. My live phpbb3 board isn't working yet, some kind of problem with a server setting or something.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

RedTrinity
Registered User
Posts: 1327
Joined: Sat May 06, 2006 3:32 am

Re: [BETA] Prime Topic Moved Info (0.1.1)

Post by RedTrinity » Sun Aug 19, 2007 8:30 am

primehalo wrote:The following line is what includes that file, and should have been added above the function "function mcp_move_topic($topic_ids)" (which on an unmodded board you should find at line #523).
I got it working :) I managed to leave out the above line for some reason, no idea how I managed that!

This is a great idea as it will help to keep track of who moved what from where :)

I do have one final suggestion/request, can anything be done to the default shadow topic option to integrate with this mod at all?

So after say a topic is moved from forum A to forum B, there is a shadow topic left in viewforum.php for A with a custom reason (added by a moderator/admin) for the move?

Here is an example of what I mean going by another forum's software that does it - you may have to view the picture in full size to see the whole thing. The examples are the light grey threads which are ones that have been moved or deleted...

Image

To the right of the original topic subject it has the reason for deletion/being moved along with a link to the new location if necessary, and then on the far right it lists whether the thread was deleted or just relocated and the reason for it again.

Just might come in handy for those threads which are moved off the board into the recycle bin or what not, as members won't be able to access the thread anymore to view the reason as to why it was moved iykwim :) That way they can just visit the existing forum where the topic used to be posted and find out there and then what happened to it.

As I said its just a suggestion, anyway :D I don't know how difficult it would be to design something like this but its just a feature I have always seen to be very effective on the forum above and would love to see it implemented into PHPBB3 :)

Let me know what you think!

DJ Skitzo
Registered User
Posts: 596
Joined: Sun Aug 12, 2007 7:25 pm

Re: [BETA] Prime Topic Moved Info (0.1.1)

Post by DJ Skitzo » Sun Aug 19, 2007 6:20 pm

Hi,

I seem to have a problem but judging from those existing posts this has only happened to me so far.

When I select to move a thread to another location it allows me to leave a reason and does not display any errors, but I can not see the reason anywhere on any of my pages as to why the thread had been moved.

Any ideas? I have tried refreshing both the cache and the template cache and still no joy

I couldn't seem to see any code in the template edits which would include prime_topic_moved_msg.html

DJ Skitzo
Registered User
Posts: 596
Joined: Sun Aug 12, 2007 7:25 pm

Re: [BETA] Prime Topic Moved Info (0.1.1)

Post by DJ Skitzo » Sun Aug 19, 2007 6:57 pm

Sorry about that, I Re-read the installation file and spotted the author notes

User avatar
primehalo
Former Team Member
Posts: 2833
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [BETA] Prime Topic Moved Info (0.1.2)

Post by primehalo » Thu Aug 23, 2007 12:28 am

Version 0.1.2 now has the ability to display the moved information on the topic list near the shadow link. This only works if a shadow was left behind when the topic was moved. Also, phpbb3 only shows shadow topics if the user viewing the topic list has permission to view the forum that the topic was moved to.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

RedTrinity
Registered User
Posts: 1327
Joined: Sat May 06, 2006 3:32 am

Re: [BETA] Prime Topic Moved Info (0.1.2)

Post by RedTrinity » Thu Aug 23, 2007 2:43 am

Ooohhhh awesome! Have just updated to latest version and LOVE the new feature, its exactly what I was after!!

Just a note for everybody upgrading - remember to turn the "show shadow topic reason" option on in the board features section of ACP first, as I initially thought it wasn't working due to not doing this :P

Fantastic work, thanks so much Primehalo :D Now I just have to get this installed on our other forum too :)

Locked

Return to “[3.0.x] MODs in Development”