[ABD] Hide Poll Results

[Litos]

MOD Title: Hide Poll Results
MOD Description: Hides the results of polls with a time limit until the poll has ended.
MOD Version: 0.1.2

MOD Download: http://home.arcor.de/schredder7/HidePol ... _0.1.2.zip

This mod hides the results of a poll with a time limit, so that users aren't influenced by previous votes.

New in 0.1.2: Some people encountered a bug that prevented them from starting new threads without a poll. This should be fixed now.

It includes support for English and German language and for the proSilver and subsilver2 styles.

That's what it looks like:
with proSilver
with subsilver2

I'd be glad about any feedback.

Note: Do not use Windows Notepad to edit PHP files!
This isn't specific to this mod, but since many people make that mistake, I'll explain it here to avoid any confusion. Notepad adds a Byte Order Mark (BOM) at the beginning of every utf-8 encoded file. These are three bytes which are supposed to tell the application reading the file that it encoded in utf-8 and not ASCII or some other encoding.
While this isn't strictly wrong, it's not necessary either and most editors don't do it or at least have an option for turning it off. In normal text files, it is not harmful, but it has quite devastating effects when put in a php file: PHP considers this as normal text, and since it comes before the initial <?php tag, it will be sent as out as output as it is. If this happens in a php file that was included by some other file, the BOM will appear somewhere in the middle of the created document. Most browser get confused by that (afaik only Opera can handle this). Even worse, you can no longer set custom html header information once output has been sent (which phpBB needs to do).
Long story short: BOM in php files is very, very bad. Use a different editor, like Notepad++ and make sure that you save the file as utf-8 without BOM.

[RedTrinity]

Sounds great!

I will install it tomorrow morning and let you know how I go

Cheers,

Nikki.

[ChriZathens]

Hi there...
Nice and useful idea !!
I seem to have a prob, though...
I installed it, but it does not seem to work
When I enter a poll with 5 option and submit the post I get this result:

Click Image to Enlarge

And after voting for option1 I get this result:

Click Image to Enlarge

You also have a small error in your xml file. It writes:

Code: Select all

Code: Select All
		$template->assign_block_vars('poll_option', array(
			'POLL_OPTION_ID' 		=> $poll_option['poll_option_id'],
			'POLL_OPTION_CAPTION' 	=> $poll_option['poll_option_text'],
			'POLL_OPTION_RESULT' 	=> $poll_option['poll_option_total'],
			'POLL_OPTION_PERCENT' 	=> $option_pct_txt,
			'POLL_OPTION_PCT'		=> round($option_pct * 100),
			'POLL_OPTION_IMG' 		=> $user->img('poll_center', $option_pct_txt, round($option_pct * 250)),
			'POLL_OPTION_VOTED'		=> (in_array($poll_option['poll_option_id'], $cur_voted_id)) ? true : false)
		);

And right after that :

Code: Select all

Code: Select All
		if($s_hide_results)
		{
			$template->assign_block_vars('poll_option', array(
				'POLL_OPTION_ID' 		=> $poll_option['poll_option_id'],
				'POLL_OPTION_CAPTION' 	=> $poll_option['poll_option_text'],
				'POLL_OPTION_RESULT' 	=> '?',
				'POLL_OPTION_PERCENT' 	=> '?',
				'POLL_OPTION_PCT'		=> round($option_pct * 0),
				'POLL_OPTION_IMG' 		=> $user->img('poll_center', '?', round($option_pct * 0)),
				'POLL_OPTION_VOTED'		=> (in_array($poll_option['poll_option_id'], $cur_voted_id)) ? true : false)
			);
		}
		else
		{
			$template->assign_block_vars('poll_option', array(
				'POLL_OPTION_ID' 		=> $poll_option['poll_option_id'],
				'POLL_OPTION_CAPTION' 	=> $poll_option['poll_option_text'],
				'POLL_OPTION_RESULT' 	=> $poll_option['poll_option_total'],
				'POLL_OPTION_PERCENT' 	=> $option_pct_txt,
				'POLL_OPTION_PCT'		=> round($option_pct * 100),
				'POLL_OPTION_IMG' 		=> $user->img('poll_center', $option_pct_txt, round($option_pct * 250)),
				'POLL_OPTION_VOTED'		=> (in_array($poll_option['poll_option_id'], $cur_voted_id)) ? true : false)
			);
		}

(It doesn't say whether to add before or after)

Also:
I thought that there should be an option in poll creation to hide the results but there isn't..
As far as I understand it hides every poll with a time limit option. If you could make it so that you can select whether you want the results to be hidden or not, then it would be much better
(Just my opinion)

[Litos]

Oh, I'm sorry, there was an error in the xml file. You should replace the first code segment with the second. I just fixed that in the xml file.

[ChriZathens]

Ok, then I assume that's why I was getting this strange result...
I tried adding after, adding before, but not replacing..
I'll try it again and post the results !!!
Nice work!!!

EDIT: OK, it works fine !!!
Will you consider adding a switch to make the hide result function optional?
It's more handy this way, since you don't need all the polls results to be hidden...

[RedTrinity]

Will you consider adding a switch to make the hide result function optional?
It's more handy this way, since you don't need all the polls results to be hidden...

I agree with this suggestion

Otherwise I have also installed it now and it works perfectly, nice work Litos!

[Litos]

Thank you, I'm glad it works!

I'll see what I can do about the switch.

[Litos]

I've just uploaded a new version. Now, a checkbox should appear when creating a new poll (or editing an existing one) where you can choose whether the results should be hidden or not.

[ChriZathens]

Nice !!!
Just tested it and seems to work just fine !!!
Nice work, Litos, congrats again !!!!
A must-have mod !!!!

[CrimsonThunder]

Sounds great, I was just looking for this too. >_> Got it from a google search.

Just wondering if theres a possibility to make it so only Admins can create these polls?

[ChriZathens]

Sounds great, I was just looking for this too. >_> Got it from a google search.

Just wondering if theres a possibility to make it so only Admins can create these polls?

Try this:
Open styles/prosilver/template/posting_poll_body.html
Find:

Code: Select all

		<hr class="dashed" />

		<dl>
			<dt><label for="poll_hide_results">{L_POLL_HIDE_RESULTS}:</label></dt>
			<dd><label for="poll_hide_results"><input type="checkbox" id="poll_hide_results" name="poll_hide_results"{HIDE_RESULTS_CHECKED} /> {L_POLL_HIDE_RESULTS_EXPLAIN}</label></dd>
		</dl>
			

Replace with:

Code: Select all

<!-- IF U_ACP -->
		<hr class="dashed" />

		<dl>
			<dt><label for="poll_hide_results">{L_POLL_HIDE_RESULTS}:</label></dt>
			<dd><label for="poll_hide_results"><input type="checkbox" id="poll_hide_results" name="poll_hide_results"{HIDE_RESULTS_CHECKED} /> {L_POLL_HIDE_RESULTS_EXPLAIN}</label></dd>
		</dl>
<!-- ENDIF -->

Open: styles/subsilver2/template/posting_poll_body.html
Find

Code: Select all

<tr>
	<td class="row1"><b class="genmed">{L_POLL_HIDE_RESULTS}:</b><br /><span class="gensmall">{L_POLL_HIDE_RESULTS_EXPLAIN}</span></td>
	<td class="row2"><input type="checkbox" class="radio" name="poll_hide_results"{HIDE_RESULTS_CHECKED} /></td>
</tr>

Replace with

Code: Select all

<!-- IF U_ACP -->
<tr>
	<td class="row1"><b class="genmed">{L_POLL_HIDE_RESULTS}:</b><br /><span class="gensmall">{L_POLL_HIDE_RESULTS_EXPLAIN}</span></td>
	<td class="row2"><input type="checkbox" class="radio" name="poll_hide_results"{HIDE_RESULTS_CHECKED} /></td>
</tr>
<!-- ENDIF -->

This will - hopefully- make the option to hide the results viewable only to admins...

Please post the results here..

[CrimsonThunder]

First of all thanks Litos for the mod. And ChriZathens for helping me. (I will test it in a second) Edit: Worked perfectly!!

All that I have to say is that it should be allowed that Admins and Mods can view the results! (And perhaps the topic creator) And that "Total Votes: *Amount*" should be un-viewable. If thats possible.

Maybe a "Make infinate private poll" just for those occations where you want no one else to know the results of a poll. This would of course need it so the admin can see it. ^^;

[RedTrinity]

All that I have to say is that it should be allowed that Admins and Mods can view the results! (And perhaps the topic creator) And that "Total Votes: *Amount*" should be un-viewable. If thats possible.

Maybe a "Make infinate private poll" just for those occations where you want no one else to know the results of a poll. This would of course need it so the admin can see it. ^^;

I 2nd these suggestions, especially those in regards to admin/moderators being able to see results regardless.

[Litos]

At the moment, I don't really have the time to work on the mod. Once I find some more spare time, I want to add an option for the admin to choose whether the total number of votes should be hidden as well and maybe (if this is possible) an option to prevent the editing of polls while they are hidden. Those were the features I wanted to add before submitting it to the mod database.

Allowing admins and mods to view the results is something which I definitely don't want in my forum, so unless I really have a lot of time and nothing else to do, I probably won't work in that direction. However, this is mod is under the GPL, so anyone is welcome to implement these changes themselves.

[CrimsonThunder]

At the moment, I don't really have the time to work on the mod. Once I find some more spare time, I want to add an option for the admin to choose whether the total number of votes should be hidden as well and maybe (if this is possible) an option to prevent the editing of polls while they are hidden. Those were the features I wanted to add before submitting it to the mod database.

Allowing admins and mods to view the results is something which I definitely don't want in my forum, so unless I really have a lot of time and nothing else to do, I probably won't work in that direction. However, this is mod is under the GPL, so anyone is welcome to implement these changes themselves.

I don't know how too.