Page 4 of 55

Re: [DEV] Smartfeed for phpBB 3

Posted: Thu Dec 20, 2007 6:54 pm
by MarkDHamill
Gosh, I guess I better start working on it again. I have been waylayed with holiday stuff and paying work so it has been on the back burner. Fortunately I have a long holiday coming up so I expect I can resume development work. It's nice to know it will be well received.

Re: RSS Feeds MOD for my Corvette Forums

Posted: Sat Dec 22, 2007 8:15 am
by joe_postscript
Hello,

I have many boards and am carefully evaluating moving to phpBB3 but wanting to verify functionality and support for what my boards can do now. One is RSS. I really like the control panel implementation you have and am bookmarking this MOD to see how it progresses, nice work. I had to pay for some custom modifications in my previous RSS Mod I was using with phpBB2. So, I will throw this out to see if you are planning to, or interested in supporting these important features. Without these, I find RSS from phpBB to be problematic.

(1) minimum size post, in number of characters
You have a featrure for post length <max> but also VERY important is <minimum> threshhold. If you have RSS going all over like I do, you will notice many jerkoffs on a forum posting, "thanks" or "That's nice", "Oh Brother, LMAO".... Stuff like that. This makes a feed worthless to allow such casual forum gibberish. In my customization of another MOD I set a minimum of 100 characters, then, clip the RSS text to around 300. This way if a poster doesn't have much to say or doesn't take time to write a decent post length, no need in wasting a feed spot for that post.

(2) textual formatting & character replacement
Ability to type in a set of characters to be replaced or deleted. Many posters will put multiple returns, retarded formatting of all kinds, when you see your feeds turning out poorly, can go in and tweak this to counter bad formatting issues. All feeds stripped of formatting and returns replaced by a space automatically by default, you get a smooth textual RSS feed with ability to clean up trash in a feed.

(3) Banword List
Ability to stop any feeds containing a certain word or list of words. Example, spammer posts "Buy Weenie Pills Make You big Man" You can put words common to spam posts in a list and be assured that your RSS will not be tied to spam sites and topics. For me, I put a single string to look for "[posted by spammer]" in the RSS MOD, then I put into my phpBB banned words to replace all banned words with that string. Thus no posts get RSS from my board with common spam topics and words.

These are all very important features to have real clean successful RSS from a board IMO. I am interested to hear your feedback, see what you think, and maybe if this is already on drawing board or can be added. Thanks for reading, sorry so long post.

Re: [DEV] Smartfeed for phpBB 3

Posted: Sat Dec 22, 2007 3:23 pm
by MarkDHamill
Smartfeed for phpBB 2 had no integrated ACP interface, but it did allow Administrators to set ads by seeing special screens in the smartfeed_url.php program. That feature is likely to go away until a subsequent version. First things first.

(1) minimum size post, in number of characters. I don't have that feature. I can consider it but it does add to the complexity of the work, which was complex before and will get more so moving to phpBB3.

(2) textual formatting & character replacement - this is a feature that could go into a subsequent version. I will try to keep it simple initially and may even remove the private message logic.

(3) Banword List - there is probably an existing function I can filter text through. It may do it already. Won't know until I get into the weeds.

These are good ideas but please understand that retrofitting this mod to phpBB3 is a huge amount of work, all of it uncompensated, so I do it as time permits and will work from a basic functionality at first until the major bugs are ironed out.

Re: [DEV] Smartfeed for phpBB 3

Posted: Mon Dec 24, 2007 3:42 am
by MarkDHamill
Today I upgraded my development board to phpBB 3 Gold.

I also made it work with phpBB 3's default prosilver theme. This required quite a bit of work since subsilver2 behaves quite a bit differently.

You can see the results here:

http://www.potomactavern.org/phpBB3/smartfeed_url.php

Re: [DEV] Smartfeed for phpBB 3

Posted: Mon Dec 24, 2007 4:41 am
by scott_thewspot
Hi Mark,

On behalf of everyone waiting for this mod, thank you. However, I think also on behalf of everyone waiting for this mod we are most likely able to find it in our hearts to let you have a few days break over this [insert relevant holiday here] period. :)

But since you decided to share, a few observations.
1. The feed link itself fails with an error "Authentication failure. "e" parameter "+PSrJ... ...auEl" is invalid with "u" parameter of "639"". I shall assume this is simply due to it still being in dev.
2. There is a sentence in the error statement reading "Please note that you must use this program to create a URL that can be used with phpBB Smartfeed" where "this program" is a link to "smartfeed.php", and I'm thinking it should be "smartfeed_url.php"?

Re: [DEV] Smartfeed for phpBB 3

Posted: Mon Dec 24, 2007 5:46 am
by MarkDHamill
Scott, thanks for reporting those development bugs, one of many. Applying a trim function to my decrypt algorithm solved the bad authentication error.

Re: [DEV] Smartfeed for phpBB 3

Posted: Fri Dec 28, 2007 8:57 pm
by magicwordlove
Changes:

File path:
language/lang_english/lang_faq.php = > language/en/help_faq.php
includes/page_header.php = > includes/functions.php
templates/subSilver/overall_header.tpl = > styles/subSilver2/template/overall_header.tpl


System Changes:
To call lang_smartfeed.php
include($phpbb_root_path . 'language/lang_' . $board_config['default_lang'] . '/lang_smartfeed.' . $phpEx);
= >
include($phpbb_root_path.'language/'.$user->data['user_lang'].'/lang_smartfeed.'.$phpEx);
in lang_smartfeed.php
$board_config['sitename']; phpbb variable = > $config['sitename'];




install.mod :

Code: Select all

# 
#-----[ SQL ]------------------------------------------ 
# 
ALTER TABLE `phpbb_users` ADD COLUMN `user_smartfeed_key` varchar(16) default NULL;

# 
#-----[ COPY ]------------------------------------------
#
copy smartfeed.php to smartfeed.php
copy smartfeed_url.php to smartfeed_url.php
copy cache/smartfeed_advertising.txt to cache/smartfeed_advertising.txt
copy includes/feedcreator.class.php to includes/feedcreator.class.php
copy includes/smartfeed_ads.class.php to includes/smartfeed_ads.class.php
copy includes/smartfeed_constants.php to includes/smartfeed_constants.php
copy language/lang_english/lang_smartfeed.php to language/en/lang_smartfeed.php
copy templates/subSilver/smartfeed_url_body.tpl to styles/subSilver2/template/smartfeed_url_body.tpl
copy templates/subSilver/images/icon_mini_feed.gif to styles/subSilver2/theme/images/icon_mini_feed.gif
#
#-----[ OPEN ]------------------------------------------
#

language/en/help_faq.php

#
#-----[ FIND ]------------------------------------------
#
	),
	array(
		0 => 'Who do I contact about abusive and/or legal matters related to this board?',
		1 => 'Any of the administrators listed on the “The team” page should be an appropriate point of contact for your complaints. If this still gets no response then you should contact the owner of the domain (do a <a href="http://www.google.com/search?q=whois">whois lookup</a>) or, if this is running on a free service (e.g. Yahoo!, free.fr, f2s.com, etc.), the management or abuse department of that service. Please note that the phpBB Group has <strong>absolutely no jurisdiction</strong> and cannot in any way be held liable over how, where or by whom this board is used. Do not contact the phpBB Group in relation to any legal (cease and desist, liable, defamatory comment, etc.) matter <strong>not directly related</strong> to the phpBB.com website or the discrete software of phpBB itself. If you do e-mail phpBB Group <strong>about any third party</strong> use of this software then you should expect a terse response or no response at all.'
	)

#
#-----[ AFTER, ADD ]------------------------------------------
#

	,
	array(
		0 => '--',
		1 => 'Newsfeeds'

	),
	array(
		0 => 'Are your forums accessible as a newsfeed using RSS and Atom protocols?',
		1 => 'Yes. This site has installed the Smartfeed phpBB modification, which allows access to both our public and private forums. Accessing private forums requires appropriate authorizations. <a href=\"" . append_sid("smartfeed_url.$phpEx") . "\">Learn more.</a>'
	)

#
#-----[ OPEN ]------------------------------------------
#
includes/functions.php

#
#-----[ FIND ]------------------------------------------
#
define('HEADER_INC', TRUE);
#
#-----[ AFTER, ADD ]------------------------------------------
#
// Begin Smartfeed 1.2 Modification
include($phpbb_root_path.'language/'.$user->data['user_lang'].'/lang_smartfeed.'.$phpEx);
// End Smartfeed 1.2 Modification
#
#-----[ FIND ]------------------------------------------
#
		'L_ONLINE_EXPLAIN'	=> $l_online_time,
#
#-----[ AFTER, ADD ]------------------------------------------
#
	        // Begin Smartfeed 1.2 Modification
	        'L_FEED'                => $lang['smartfeed_page_title'], 
	        // End Smartfeed 1.2 Modification
#
#-----[ FIND ]------------------------------------------
#

'U_MEMBERLIST'			=> append_sid("{$phpbb_root_path}memberlist.$phpEx"),
#
#-----[ AFTER, ADD ]------------------------------------------
#
// Begin Smartfeed 1.2 Modification
'U_FEED'                        => append_sid("{$phpbb_root_path}smartfeed_url.$phpEx"), 
// End Smartfeed 1.2 Modification
#
#-----[ OPEN ]------------------------------------------
#
styles/subSilver2/template/overall_header.tpl

#
#-----[ FIND ]------------------------------------------
#
						<td class="genmed" align="{S_CONTENT_FLOW_END}">
				<a href="{U_FAQ}"><img src="{T_THEME_PATH}/images/icon_mini_faq.gif" width="12" height="13" alt="*" /> {L_FAQ}</a>


#-----[ IN-LINE AFTER, ADD ]------------------------------------------

<a href="{U_FEED}"><img src="{T_THEME_PATH}/images/icon_mini_feed.gif" width="12" height="13" alt="*" /> {L_FEED}</a>


#
#-----[ OPEN ]------------------------------------------
#

language/en/lang_smartfeed.php

#
#-----[ FIND ]------------------------------------------
#

// Miscellaneous variables
$lang['smartfeed_feed_title'] = $board_config['sitename'];
$lang['smartfeed_feed_description'] = $board_config['site_desc'];
$lang['smartfeed_image_title'] = $board_config['site_desc'] . ' Logo';


#-----[ REPLACE]------------------------------------------

// Miscellaneous variables
$lang['smartfeed_feed_title'] = $config['sitename'];
$lang['smartfeed_feed_description'] = $config['site_desc'];
$lang['smartfeed_image_title'] = $config['site_desc'] . ' Logo';

#
#-----[ SAVE/CLOSE ALL FILES ]------------------------------------------
#
#Clear Cache....
# EoM  

Even though these,i could'nt manage to work it!
i think variables that was taken from profile.php have been changed.Help me please!

Re: [DEV] Smartfeed for phpBB 3

Posted: Fri Dec 28, 2007 9:25 pm
by MarkDHamill
I think you are posting to the wrong topic. I have not shared my source code yet. I think you mean this topic, Smartfeed for phpBB 2.

http://www.phpbb.com/community/viewtopi ... 5&t=373726

Re: [DEV] Smartfeed for phpBB 3

Posted: Fri Dec 28, 2007 9:49 pm
by magicwordlove
I know that you haven't published your codes.I searched all over the pages...But i am too impatient to wait.Your mod is wonderful!
So i tried a few changes for phpBB3 but i couldn't successfully do it....i look forward to seeing the new version....good luck.

Re: [DEV] Smartfeed for phpBB 3

Posted: Fri Dec 28, 2007 9:58 pm
by murnauvsbuñuel
wouu cool in prosilver.

i will translate your mod to spanish if you need this when you put the download link in the first post.
thanks for your work great MarkDHamill and scott

Re: [DEV] Smartfeed for phpBB 3

Posted: Fri Dec 28, 2007 10:18 pm
by MarkDHamill
Well, I have a lovely user interface but turning it into something workable is a big challenge. The big challenge right now is to figure out how to obtain a list of forums with read permissions for a user without going through the log in process. acl_getf() won't work in this case, although it was handy to have for smartfeed_url.php. It's mysterious how the user_permissions BLOB column works.

If I could simply tweak my version for phpBB 2 that would be lovely, but it is simply not possible. I can steal some code here and there, but mostly it is a complete rewrite.

murnauvsbuñuel, thanks for volunteering to write the Spanish translation. Actually, Smartfeed for phpBB 2 has had some new language additions, so you are welcome to turn the new ones for it into Spanish. They will appear as English in the Spanish translation.

Re: [DEV] Smartfeed for phpBB 3

Posted: Mon Dec 31, 2007 2:43 am
by Colin Kaminski
Perhaps you can release a beta that does not have the private posts option? I have a public forum and just need something very simple. But I have not been able to get a good result with simplerss.

Re: [DEV] Smartfeed for phpBB 3

Posted: Mon Dec 31, 2007 3:16 am
by MarkDHamill
Thanks. I was thinking of removing all unnecessary features for a beta.

But I still have major hurdles to climb. I spent much of the weekend examining phpBB 3's forum permissions systems. It is devilishly complex and I haven't figured out all of it yet, but among other things you have to translate a blob field from base 36 to base 2 and then associate the zeroes and ones with various format permissions. I need to do it independently because smartfeed.php authenticates separately; I cannot count on either a cookie or the ability to have someone log in.

If someone understands how it works please leave a post.

Re: [DEV] Smartfeed for phpBB 3

Posted: Mon Dec 31, 2007 11:15 am
by nizouille
I vote on this : just a simple smartfeed asap :)
This "rss" stuffs keeps me out of the migration to phpbb3 :)
Thanks for your job anyway

Re: [DEV] Smartfeed for phpBB 3

Posted: Mon Dec 31, 2007 1:09 pm
by -=ET=-
MarkDHamill wrote:No suggestions for changing/improving the user interface? This would be an ideal time to incorporate them.
Hi MarkDHamill,

First, congratulation for this very promising phpBB 3 MOD :)
I can't wait to install the gold release!!! :P

And in the mean time a suggestion and an offer:
- IMO, most of the selection options are designed to follow un-viewed topics for a forum user. But if you want to provide a news feed to be displayed on other websites you need to provide a limited number of news. So in "Fetch posts meeting the following criteria:", IMO values like "The 10 last", The 15 last" are missing.
- And the offer is that if you need a French translation, I can do it as I will do it for me ;-)

Happy new year from France! :)