Page 55 of 55

Re: [RC11] Smartfeed for phpBB 3

Posted: Thu Jul 16, 2009 7:57 pm
by Mickroz
ok thanks mark.

Re: [RC11] Smartfeed for phpBB 3

Posted: Thu Jul 16, 2009 8:35 pm
by MarkDHamill
The code in TripleDES.php should be:

Code: Select all

// require_once 'DES.php'; -- MDH 4/29/09 - This line commented out and following lines substituted to address MPV warning
if (file_exists($phpbb_root_path . "includes/Crypt/DES.$phpEx"))
{
	include ($phpbb_root_path . "includes/Crypt/DES.$phpEx");
}
else
{
	die(sprintf("Missing file %s. phpBB Smartfeed cannot encrypt. Either add file or remove phpBB Smartfeed.", $phpbb_root_path . 'includes/Crypt/DES.' . $phpEx));
}
This should get rid of the notice about missing constants with the Crypt library.

Re: [RC11] Smartfeed for phpBB 3

Posted: Thu Jul 16, 2009 8:39 pm
by MarkDHamill
Removed post text.

Version 2.2.11 now available

Posted: Fri Jul 17, 2009 10:23 pm
by MarkDHamill
Got another thorough review by the phpBB Mod Team, which was very useful. Code quality keeps improving. Here are some of the changes in this version. I was able to address some lingering issues, like how to do deeply nested switches inside of templates and I also took care of PHP Notices that were driving many of you nuts, along with fixing the include file problem with TripleDES.php. That wasn't really noticed because the code is triggered only if mcrypt is not compiled with PHP, which it usually is.

Download Here
- Inconsistent licensing is now consistent.
- subsilver2 and other languages files moved inside root folder of archive.
- Removed issues causing PHP Notices.
- Boolean template switches now being used consistently.
- Many template variable names changed to follow phpBB Coding Standards. There were some inconsistencies.
- sprintf and other variable declarations removed from language file.
- TripleDES.php now properly includes DES.php. Was not noticed much before because most people have mcrypt compiled into PHP.
It should be quite stable in spite of significant code changes. I will wait a few days to hear if anyone squeals before submitting for review. Will this mod ever get approved? I sure hope so because by phpBB 3.2 it may be moot!

Version 2.2.12 now available

Posted: Fri Jul 24, 2009 1:40 pm
by MarkDHamill
Good news. The phpBB Mod Team has been working on this at a fairly brisk clip and (knock on wood) I have now fixed all errors to their satisfaction. Meanwhile one more and hopefully last review. They say it is close to approval.

Version 2.2.12 is pretty minor but includes their recommended fixes.

Change log:
- Template changes to use ELSE where appropriate.
- Include logic now consistently looks for either an expected constant or a function existing and if it does not find it includes the file.
- Added missing case statements to handle_error function in smartfeed.php
- smartfeed_url.php now looks at the user's is_registered value to determine if they can access private forums.
- Removed unneed intval() function when updating phpbb_users table in smartfeed_url.php
Download Here

Re: [RC15] Smartfeed for phpBB 3

Posted: Fri Jul 24, 2009 4:16 pm
by MarkDHamill
If you just downloaded the archive, please download again. I forgot to update TripleDES.php.

And since this file needs to be copied down for an upgrade, if upgrading use the new instructions from 2.2.11 to 2.2.12 which say to copy over this file too.

Smartfeed Mod is approved!

Posted: Thu Aug 06, 2009 12:39 pm
by MarkDHamill
Thanks everyone for your help over more than a year developing and fine tuning this mod. You can download Smartfeed from phpBB here:

http://www.phpbb.com/mods/db/index.php? ... ib_id=5585

Conversation will move to this topic here:

http://www.phpbb.com/community/viewtopic.php?t=1726785

Note one small change to the archive on my website. The program smartfeed_url_key.php program was changed to use sql_query_limit. I will replace 2.2.12 archive on my site with this corrected version.