[RC] phpBB Gallery 1.0.4 (including TS Gallery converter)

A place for MOD Authors to post and receive feedback on MODs still in development. No MODs within this forum should be used within a live environment!
Scam Warning
User avatar
KillBill.
Registered User
Posts: 598
Joined: Tue Jun 02, 2009 4:07 pm
Contact:

Re: [RC] phpBB Gallery 1.0.3 (including TS Gallery converter)

Post by KillBill. » Mon Nov 16, 2009 9:37 pm

nickvergessen wrote:
KillBill. wrote:The problem is there: if an user create a personal album, but the dont upload any
image to album, then an administrator clean up the mod, then we got a Generating error.
the correct fix is: http://code.bantux.org/repositories/dif ... p?rev=1328
This is is only for against te error messages, but cannot fix the error!

Because the $user_image_count remain empty, so the run of foreach
cannot be done, so the error will remain, that the cleaned user can not
open personal album again until the reset.

You do not recommend the deleting cause else for another thing, thats ok.
I am just thinking about it, and if I delete a user's personal album, then why remain
some data for this? I am sure we dont need any data from deteled albums...

nickvergessen wrote: regarding the edit on the album.php
this is the fix to go: http://code.bantux.org/repositories/dif ... p?rev=1317
This fine, thx.

I just installed this mod right now and I dont see correctly the things yet,
But I am trying. Anyway, its nice work.

PS: the deleting of comments without valid authors.
There is a bug, too, if i try to open the image..I am waiting for your answer.

User avatar
nickvergessen
Former Team Member
Posts: 4397
Joined: Mon Apr 30, 2007 5:33 pm
Location: Stuttgart, Germany
Name: Joas Schilling
Contact:

Re: [RC] phpBB Gallery 1.0.3 (including TS Gallery converter)

Post by nickvergessen » Mon Nov 16, 2009 10:07 pm

KillBill. wrote:This is is only for against te error messages, but cannot fix the error!

Because the $user_image_count remain empty, so the run of foreach
cannot be done, so the error will remain, that the cleaned user can not
open personal album again until the reset.

You do not recommend the deleting cause else for another thing, thats ok.
I am just thinking about it, and if I delete a user's personal album, then why remain
some data for this? I am sure we dont need any data from deteled albums...
Did you test that? Cause I did, and it is fixed for me ;) we do not keep any-data we don't need (except the atrack which you already pointed out)
KillBill. wrote:PS: the deleting of comments without valid authors.
There is a bug, too, if i try to open the image..I am waiting for your answer.
I will look at that this week.
No Support via PM

User avatar
KillBill.
Registered User
Posts: 598
Joined: Tue Jun 02, 2009 4:07 pm
Contact:

Re: [RC] phpBB Gallery 1.0.3 (including TS Gallery converter)

Post by KillBill. » Mon Nov 16, 2009 10:31 pm

OK, if you think you did correct, then do this:
Open a personal album, then go to acp,delete the album,, then go back to your profile and try to create a personal album, and you will see, that you cannot, cause you do not have permission

this modify fix the problem what I say

find

Code: Select all

                // No errors, if the image_count would be lower than 0
                $db->sql_return_on_error(true);
                foreach ($user_image_count as $user_id => $images)
                {
                    if (!function_exists('gallery_hookup_image_counter'))
                    {
                        global $gallery_root_path, $phpbb_root_path, $phpEx;
                        include($phpbb_root_path . $gallery_root_path . 'includes/hookup_gallery.' . $phpEx);
                    }
                    gallery_hookup_image_counter($user_id, (0 - $images));

                    $sql = 'UPDATE ' . GALLERY_USERS_TABLE . '
                        SET personal_album_id = 0,
                            user_images = user_images - ' . $images . '
                        WHERE user_id = ' . $user_id;
                    $result = $db->sql_query($sql);

                    if ($result === false)
                    {
                        $sql = 'UPDATE ' . GALLERY_USERS_TABLE . '
                            SET personal_album_id = 0,
                                user_images = 0
                            WHERE user_id = ' . $user_id;
                        $db->sql_query($sql);
                    }
                    $db->sql_freeresult($result);
                }
                $db->sql_return_on_error(false); 
replace

Code: Select all

                foreach ($user_image_count as $user_id => $images)
                {
                    if (!function_exists('gallery_hookup_image_counter'))
                    {
                        global $gallery_root_path, $phpbb_root_path, $phpEx;
                        include($phpbb_root_path . $gallery_root_path . 'includes/hookup_gallery.' . $phpEx);
                    }
                    gallery_hookup_image_counter($user_id, (0 - $images));
                    $db->sql_query('UPDATE ' . GALLERY_USERS_TABLE . '  SET personal_album_id = 0, user_images = user_images - ' . $images . ' WHERE user_id = ' . $user_id);
                }

                    if(!sizeof($user_image_count))
                    {
                    $db->sql_query('UPDATE ' . GALLERY_USERS_TABLE . '  SET personal_album_id = 0 WHERE ' . $db->sql_in_set('personal_album_id', $deleted_albums));
                    } 

Catscan
Registered User
Posts: 7
Joined: Mon Nov 09, 2009 5:01 pm

Re: [RC] phpBB Gallery 1.0.3 (including TS Gallery converter)

Post by Catscan » Sat Nov 21, 2009 9:52 am

My Album button dissapears when i log in to my forum?

Logged in
Image

Not logged in
Image

Why? solution?

User avatar
nickvergessen
Former Team Member
Posts: 4397
Joined: Mon Apr 30, 2007 5:33 pm
Location: Stuttgart, Germany
Name: Joas Schilling
Contact:

Re: [RC] phpBB Gallery 1.0.3 (including TS Gallery converter)

Post by nickvergessen » Sat Nov 21, 2009 10:42 am

Are you using different languages?
If so, you need to do the edit from subsilver/imageset/en/imageset.cfg to the subsilver/imageset/**/imageset.cfg aswell and also copy the button to subsilver/imageset/**/

Afterwards go to ACp > Styles > Theme and refresh it.
No Support via PM

User avatar
sunsop
Registered User
Posts: 671
Joined: Sat Sep 05, 2009 6:36 am

Re: [RC] phpBB Gallery 1.0.3 (including TS Gallery converter)

Post by sunsop » Sun Nov 22, 2009 6:11 am

This is for Prosilver only? I looked at the required edits and it only listed Prosilver files to edit :cry:

User avatar
nickvergessen
Former Team Member
Posts: 4397
Joined: Mon Apr 30, 2007 5:33 pm
Location: Stuttgart, Germany
Name: Joas Schilling
Contact:

Re: [RC] phpBB Gallery 1.0.3 (including TS Gallery converter)

Post by nickvergessen » Sun Nov 22, 2009 10:01 am

sunsop wrote:This is for Prosilver only? I looked at the required edits and it only listed Prosilver files to edit :cry:
subsilver2 is in contrib/subsilver2.xml
No Support via PM

User avatar
Gremlinn
Registered User
Posts: 2133
Joined: Mon Aug 04, 2003 12:13 am
Location: Rochester, NY
Name: Nathan

Re: [RC] phpBB Gallery 1.0.3 (including TS Gallery converter)

Post by Gremlinn » Mon Nov 23, 2009 8:28 pm

I went back a few pages and didn't find an answer.

I am getting this with debug turned on:

Code: Select all

[phpBB Debug] PHP Notice: in file /gallery/includes/functions_version_check.php on line 99: Undefined variable: mod_version

Peter77sx
Registered User
Posts: 3257
Joined: Wed Nov 09, 2005 2:51 pm

Re: [RC] phpBB Gallery 1.0.3 (including TS Gallery converter)

Post by Peter77sx » Mon Nov 23, 2009 9:22 pm


User avatar
nickvergessen
Former Team Member
Posts: 4397
Joined: Mon Apr 30, 2007 5:33 pm
Location: Stuttgart, Germany
Name: Joas Schilling
Contact:

Re: [RC] phpBB Gallery 1.0.3 (including TS Gallery converter)

Post by nickvergessen » Tue Nov 24, 2009 12:17 am

Peter77sx wrote:Hey Gremlinn, this should help
http://www.flying-bits.org/viewtopic.php?f=67&t=1995
Not exactly, but http://code.bantux.org/repositories/dif ... p?rev=1316 (edit gallery/includes/functions_version_check.php)
No Support via PM

sTimulated
Registered User
Posts: 91
Joined: Fri Mar 27, 2009 4:16 pm
Contact:

Re: [RC] phpBB Gallery 1.0.3 (including TS Gallery converter)

Post by sTimulated » Tue Nov 24, 2009 11:50 am

I occasionally get this error?

[phpBB Debug] PHP Notice: in file /gallery/includes/functions_version_check.php on line 36: include(mods/phpbb_gallery_version.php) [function.include]: failed to open stream: No such file or directory
[phpBB Debug] PHP Notice: in file /gallery/includes/functions_version_check.php on line 36: include() [function.include]: Failed opening 'mods/phpbb_gallery_version.php' for inclusion (include_path='.;C:/php5/pear')
[phpBB Debug] PHP Notice: in file /gallery/includes/functions_version_check.php on line 39: call_user_func(phpbb_gallery_version::version) [function.call-user-func]: First argument is expected to be a valid callback
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 4209: Cannot modify header information - headers already sent by (output started at /includes/functions.php:3491)
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 4211: Cannot modify header information - headers already sent by (output started at /includes/functions.php:3491)
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 4212: Cannot modify header information - headers already sent by (output started at /includes/functions.php:3491)
[phpBB Debug] PHP Notice: in file /includes/functions.php on line 4213: Cannot modify header information - headers already sent by (output started at /includes/functions.php:3491)

If I refresh the page it disappears and everything is normal.
Is it something I need to worry about and can I fix the problem?

User avatar
Gremlinn
Registered User
Posts: 2133
Joined: Mon Aug 04, 2003 12:13 am
Location: Rochester, NY
Name: Nathan

Re: [RC] phpBB Gallery 1.0.3 (including TS Gallery converter)

Post by Gremlinn » Tue Nov 24, 2009 1:43 pm

nickvergessen wrote:
Peter77sx wrote:Hey Gremlinn, this should help
http://www.flying-bits.org/viewtopic.php?f=67&t=1995
Not exactly, but http://code.bantux.org/repositories/dif ... p?rev=1316 (edit gallery/includes/functions_version_check.php)

Perfect. Thanks.

User avatar
nickvergessen
Former Team Member
Posts: 4397
Joined: Mon Apr 30, 2007 5:33 pm
Location: Stuttgart, Germany
Name: Joas Schilling
Contact:

Re: [RC] phpBB Gallery 1.0.3 (including TS Gallery converter)

Post by nickvergessen » Tue Nov 24, 2009 3:14 pm

sTimulated wrote:If I refresh the page it disappears and everything is normal.
Is it something I need to worry about and can I fix the problem?
Please read the FAQs :!:
No Support via PM

MalkContent
Registered User
Posts: 203
Joined: Mon Aug 18, 2008 10:00 am

Re: [RC] phpBB Gallery 1.0.3 (including TS Gallery converter)

Post by MalkContent » Tue Nov 24, 2009 3:17 pm

Hey

I just updated my old phpbb gallery install from 0.4.1 to 1.0.0. to 1.0.1 to 1.0.2 to 1.0.3 and somehow I am missing the slide show thing and clicking on the images loads the images in the browser.
Did I do something wrong or is there an option for this in the acp/mods section which i overlooked?

User avatar
nickvergessen
Former Team Member
Posts: 4397
Joined: Mon Apr 30, 2007 5:33 pm
Location: Stuttgart, Germany
Name: Joas Schilling
Contact:

Re: [RC] phpBB Gallery 1.0.3 (including TS Gallery converter)

Post by nickvergessen » Tue Nov 24, 2009 3:22 pm

MalkContent wrote:Hey

I just updated my old phpbb gallery install from 0.4.1 to 1.0.0. to 1.0.1 to 1.0.2 to 1.0.3 and somehow I am missing the slide show thing and clicking on the images loads the images in the browser.
Did I do something wrong or is there an option for this in the acp/mods section which i overlooked?
http://www.flying-bits.org/viewtopic.php?f=67&t=1629
No Support via PM

Locked

Return to “[3.0.x] MODs in Development”