UMIL/UMIF - New MOD Installation Library - Feedback needed

Discussion forum for MOD Writers regarding MOD Development.
User avatar
EXreaction
Former Team Member
Posts: 5666
Joined: Sun Aug 21, 2005 9:31 pm
Location: Wisconsin, U.S.
Name: Nathan

Re: UMIL/UMIF - New MOD Installation Library - Feedback needed

Post by EXreaction » Fri Dec 05, 2008 2:21 am

Alright, I'll look into adding a warning box if any permissions are added.

User avatar
EXreaction
Former Team Member
Posts: 5666
Joined: Sun Aug 21, 2005 9:31 pm
Location: Wisconsin, U.S.
Name: Nathan

Re: UMIL/UMIF - New MOD Installation Library - Feedback needed

Post by EXreaction » Sat Dec 06, 2008 10:55 pm

One question for you guys about setting permissions for roles/groups.

What should it do if that auth option is already set? Should I use the new setting or the old? I am leaning towards having it just keep the old setting, but if I just have it use the new setting I can shorten this function up a lot and wouldn't need to check whether it is set now or not.

User avatar
Erik Frèrejean
Former Team Member
Posts: 9899
Joined: Tue Oct 09, 2007 9:09 am
Location: The Netherlands, 3.0.x Support Forum
Name: Erik Frèrejean
Contact:

Re: UMIL/UMIF - New MOD Installation Library - Feedback needed

Post by Erik Frèrejean » Sat Dec 06, 2008 11:30 pm

I must say that I'm not really sure what you mean.
Do you mean that if one user is part of two groups and one group al ready has this permission set, and the installer is about to set this permission for the second group? In that case I would say that it should follow the phpBB order. Thus yes over rules no and never over rules a yes.

Or do you mean something completely different? :?
Support Toolkit | Support Request Template | Knowledge Base | phpBB 3.0.x documentation
I don't give support via PM or IM! (all unsolicited pms will be trashed!)

User avatar
EXreaction
Former Team Member
Posts: 5666
Joined: Sun Aug 21, 2005 9:31 pm
Location: Wisconsin, U.S.
Name: Nathan

Re: UMIL/UMIF - New MOD Installation Library - Feedback needed

Post by EXreaction » Sun Dec 07, 2008 12:20 am

No, if the permission option that the mod is trying to set is already set for the group or role.

User avatar
Highway of Life
Former Team Member
Posts: 6048
Joined: Wed Feb 02, 2005 5:41 pm
Location: Seattle, WA
Name: David Lewis
Contact:

Re: UMIL/UMIF - New MOD Installation Library - Feedback needed

Post by Highway of Life » Sun Dec 07, 2008 3:01 am

EXreaction wrote:No, if the permission option that the mod is trying to set is already set for the group or role.
It should be setting permissions on a role basis, not a group basis. Groups should have roles assigned by the administrator.

If you’re trying to add a permission option to a role and it already exists in that role, just move on from there. If it does not exist in that role and the script installs it into the role, that is what would occur. Otherwise I’m not clear on what you’re asking.
The phpBB Weekly Podcast - Discussing the developments of phpBB4 and beyond.

New to phpBB3? Want to learn about programing?
Visit phpBB Academy at StarTrekGuide to learn how.

User avatar
EXreaction
Former Team Member
Posts: 5666
Joined: Sun Aug 21, 2005 9:31 pm
Location: Wisconsin, U.S.
Name: Nathan

Re: UMIL/UMIF - New MOD Installation Library - Feedback needed

Post by EXreaction » Sun Dec 07, 2008 3:35 am

What about guests then?

Guests have no role, so administrators will be forced to set permissions for them always. If administrators have to set some permissions I'd rather let them set all of the permissions.

User avatar
Highway of Life
Former Team Member
Posts: 6048
Joined: Wed Feb 02, 2005 5:41 pm
Location: Seattle, WA
Name: David Lewis
Contact:

Re: UMIL/UMIF - New MOD Installation Library - Feedback needed

Post by Highway of Life » Sun Dec 07, 2008 3:36 am

Anonymous user is in the Guest group, the Guest group must still be assigned roles.
The phpBB Weekly Podcast - Discussing the developments of phpBB4 and beyond.

New to phpBB3? Want to learn about programing?
Visit phpBB Academy at StarTrekGuide to learn how.

User avatar
EXreaction
Former Team Member
Posts: 5666
Joined: Sun Aug 21, 2005 9:31 pm
Location: Wisconsin, U.S.
Name: Nathan

Re: UMIL/UMIF - New MOD Installation Library - Feedback needed

Post by EXreaction » Sun Dec 07, 2008 4:42 pm

I am not sure what you are saying.

With only the option to assign permissions to roles, one can not set permissions for the guests on a default install.

If the admin needs to set any permissions I'd rather have them set all of them, otherwise all you get is "why can't guests see this?".

User avatar
Highway of Life
Former Team Member
Posts: 6048
Joined: Wed Feb 02, 2005 5:41 pm
Location: Seattle, WA
Name: David Lewis
Contact:

Re: UMIL/UMIF - New MOD Installation Library - Feedback needed

Post by Highway of Life » Sun Dec 07, 2008 10:58 pm

The Anonymous user (user_id 1) is by default included in the group: GUESTS (group id 1).
The group GUESTS are assigned the following roles by default: forum_id 1, 2, role id 17 (ROLE_FORUM_READONLY). And the following individual auth option ids: 85 (u_), 93 (u_download), and 111 (u_search).

The Anonymous user has NO individual auth options or roles assigned, all permissions for Anonymous are assigned via individual auth options or roles to the GUESTS group.

Users should never be assigned individual permissions or roles, permissions should always be assigned to roles, and then roles to groups.
The phpBB Weekly Podcast - Discussing the developments of phpBB4 and beyond.

New to phpBB3? Want to learn about programing?
Visit phpBB Academy at StarTrekGuide to learn how.

User avatar
EXreaction
Former Team Member
Posts: 5666
Joined: Sun Aug 21, 2005 9:31 pm
Location: Wisconsin, U.S.
Name: Nathan

Re: UMIL/UMIF - New MOD Installation Library - Feedback needed

Post by EXreaction » Sun Dec 07, 2008 11:55 pm

Yes, guests have roles set for forums by default, but not for their global permissions.

User avatar
Highway of Life
Former Team Member
Posts: 6048
Joined: Wed Feb 02, 2005 5:41 pm
Location: Seattle, WA
Name: David Lewis
Contact:

Re: UMIL/UMIF - New MOD Installation Library - Feedback needed

Post by Highway of Life » Mon Dec 08, 2008 1:05 am

EXreaction wrote:Yes, guests have roles set for forums by default, but not for their global permissions.
But never the user, permissions are not assigned on a per-user basis. They are assigned to the group.
Therefore, if the MOD Author is adding permissions for guests, it needs to be done on a role basis, or the permission assigned to the Guest group.
The phpBB Weekly Podcast - Discussing the developments of phpBB4 and beyond.

New to phpBB3? Want to learn about programing?
Visit phpBB Academy at StarTrekGuide to learn how.

User avatar
EXreaction
Former Team Member
Posts: 5666
Joined: Sun Aug 21, 2005 9:31 pm
Location: Wisconsin, U.S.
Name: Nathan

Re: UMIL/UMIF - New MOD Installation Library - Feedback needed

Post by EXreaction » Mon Dec 08, 2008 1:35 am

Yes, they would need to assign permissions to the guest group.

There will be no method of giving individual users permissions, just groups and roles.

I've tried setting individual permissions to groups with roles already set, and I found out that if a group has a role selected for their permissions, any other permission settings are ignored, so if one were to set permissions for the guest group and it happened to have a role set for it, no permissions would actually get set.

So then it goes back to me thinking that it should not have the option to set permissions for groups because that can vary too much depending on the board settings. But then again, if permissions can not be set for guests I would not want to allow any permissions to be set at all.

I guess I'll talk to Acyd Burn once, maybe I can convince him to throw in a default role for the guest group as that would make things much easier.

User avatar
Highway of Life
Former Team Member
Posts: 6048
Joined: Wed Feb 02, 2005 5:41 pm
Location: Seattle, WA
Name: David Lewis
Contact:

Re: UMIL/UMIF - New MOD Installation Library - Feedback needed

Post by Highway of Life » Mon Dec 08, 2008 1:46 am

Better talk to him quick before 3.0.4 gets released. ;) He might also have an idea for this situation.
You should be able to check and see if a group has a role assigned, and if not, just add the individual auth option to that role, that should solve the problem of conflicting permissions versus roles.
The phpBB Weekly Podcast - Discussing the developments of phpBB4 and beyond.

New to phpBB3? Want to learn about programing?
Visit phpBB Academy at StarTrekGuide to learn how.

User avatar
EXreaction
Former Team Member
Posts: 5666
Joined: Sun Aug 21, 2005 9:31 pm
Location: Wisconsin, U.S.
Name: Nathan

Re: UMIL/UMIF - New MOD Installation Library - Feedback needed

Post by EXreaction » Mon Dec 08, 2008 2:18 am

Yes, I sent him a PM earlier.

That may be an option, I'd rather only allow permissions to be set for roles though (it would certainly make things much easier).

User avatar
EXreaction
Former Team Member
Posts: 5666
Joined: Sun Aug 21, 2005 9:31 pm
Location: Wisconsin, U.S.
Name: Nathan

Re: UMIL/UMIF - New MOD Installation Library - Feedback needed

Post by EXreaction » Mon Dec 08, 2008 4:43 pm

3.0.4 is a no, since it is RC1 nothing new will be added.

I guess I'll just have to do this the hard way. I'll set it up for groups and have it put the new permission in their role if they have one.

Locked

Return to “[3.0.x] MOD Writers Discussion”