[SOLVED] Karma MOD vs MPV

Discussion forum for MOD Writers regarding MOD Development.
User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 17003
Joined: Thu Jan 06, 2005 1:30 pm
Location: Fishkill, NY
Name: David Colón
Contact:

Re: Karma MOD vs MPV

Post by DavidIQ » Mon Feb 22, 2010 5:23 pm

No it's a timeout. It runs fine if I run it directly against the server instead of from here. Might have something to do with the changes we did...
Apply to become a Jr. Extension Validator
My extensions | In need of phpBB services? | Was I helpful today?
No unsolicited PMs unless you're planning on asking for paid help.

User avatar
m157y
Registered User
Posts: 482
Joined: Mon Apr 30, 2007 9:39 am
Location: Russia, Moscow, Khimki
Contact:

Re: Karma MOD vs MPV

Post by m157y » Mon Feb 22, 2010 5:29 pm

Mmm. Possible the problem because we're uploading file and it takes some time, but archive of Karma MOD is more then 300kb, also i have a lot of files. So, i think, it'll be better to separate tests, for example like this:
  • Step 1: Upload file
  • Step 2: Test structure
  • Step 3: Test XML
  • Step 4: Test mod-files
It'll increase size of MPV`s source-code files, but it'll decrease server-load, because we don't checks everything at once and most of mod authors will fix errors from current step and don't go to next before fixing all of errors. Also it'll increase available server-time for each of tests, so we will not have an timeout problem like this.
What do you think about it?
m157y aka Misty
NO SUPPORT VIA PM
KarmaMOD for phpBB 3.0.x | bbAJAX
Follow me on twitter

User avatar
igorw
Former Team Member
Posts: 8024
Joined: Fri Dec 16, 2005 12:23 pm
Location: {postrow.POSTER_FROM}
Name: Igor Wiedler

Re: Karma MOD vs MPV

Post by igorw » Mon Feb 22, 2010 6:26 pm

To test it properly you need to set the $unzip_type (second argument for mpv constructor) to mpv::UNZIP_PHP. That's the one currently used by MPV on phpBB.com.

By default it uses mpv::UNZIP_PREFERENCE which will try to use the command-line "unzip" (will work on OSX and linux but not on windows), next it will try to use the zip PHP extension (this was added by the patch and will work on PHP5.2+) and if that fails it will use phpBB's zip class (which was causing the initial errors).
Igor Wiedler | area51 | GitHub | trashbin | Formerly known as evil less than three

User avatar
m157y
Registered User
Posts: 482
Joined: Mon Apr 30, 2007 9:39 am
Location: Russia, Moscow, Khimki
Contact:

Re: Karma MOD vs MPV

Post by m157y » Mon Feb 22, 2010 8:16 pm

My PHP was compiled w/o zip support, so i can't test it now. But as you say, phpBB's zip class causes errors, but it works perfectly at my localhost.
m157y aka Misty
NO SUPPORT VIA PM
KarmaMOD for phpBB 3.0.x | bbAJAX
Follow me on twitter

Locked

Return to “[3.0.x] MOD Writers Discussion”