[rant] Please use existing CSS classes in your MOD blocks !
Posted: Sat Nov 05, 2011 5:55 pm
Hello,
As a Style author, I come here for a little rant : For the sake of style authors and phpBB users, please use existing CSS classes in your blocks that are added by your MODs.
Why, you'd ask me ? Because when these classes (.panel, .bg1, .bg2, .bg3, …) aren't used in your Mods, the blocks colors cannot adapt themselves to the style changes and thus, cause colour bugs that might make some texts unreadable, especially for styles that use a dark background with light-coloured blocks like my pro_ubuntu_lucid does !
Examples of MODs with the problems :
- Social Network
- MChat
- board3portal
Because of this, especially in the case of Social Network, a LOT of adaptation is needed to make this MOD compatible with the styles such as pro_ubuntu_lucid, because this MOD only uses custom classes for its blocks ! If this continues like this, I'll have to create GitHub repos just for adaptations because not all phpBB users are HTML/CSS cracks !
So please, use custom classes for CSS properties that aren't related to colours, and existing CSS properties (.panel, .bg1, .bg2, .bg3, .forumbg, .forabg) for colour scheme ! By doing this, your MOD will be more flexible towards style change !
And for MOD validators, I suggest this to be added as a good practice advice.
That was my two cents.
Ishimaru
As a Style author, I come here for a little rant : For the sake of style authors and phpBB users, please use existing CSS classes in your blocks that are added by your MODs.
Why, you'd ask me ? Because when these classes (.panel, .bg1, .bg2, .bg3, …) aren't used in your Mods, the blocks colors cannot adapt themselves to the style changes and thus, cause colour bugs that might make some texts unreadable, especially for styles that use a dark background with light-coloured blocks like my pro_ubuntu_lucid does !
Examples of MODs with the problems :
- Social Network
- MChat
- board3portal
Because of this, especially in the case of Social Network, a LOT of adaptation is needed to make this MOD compatible with the styles such as pro_ubuntu_lucid, because this MOD only uses custom classes for its blocks ! If this continues like this, I'll have to create GitHub repos just for adaptations because not all phpBB users are HTML/CSS cracks !
So please, use custom classes for CSS properties that aren't related to colours, and existing CSS properties (.panel, .bg1, .bg2, .bg3, .forumbg, .forabg) for colour scheme ! By doing this, your MOD will be more flexible towards style change !
And for MOD validators, I suggest this to be added as a good practice advice.
That was my two cents.
Ishimaru