Your feedback on the MOD Database and Validation process

Discussion forum for MOD Writers regarding MOD Development.
User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 17079
Joined: Thu Jan 06, 2005 1:30 pm
Location: Fishkill, NY
Name: David Colón
Contact:

Re: Your feedback on the MOD Database and Validation process

Post by DavidIQ » Fri Dec 03, 2010 9:04 pm

We are also working on modifying the mpv page to allow for direct uploading of MOD packages to make the mpv checking much easier and, hopefully, reduce the reoccurrence of this sort of thing. :)
Apply to become a Jr. Extension Validator
My extensions | In need of phpBB services? | Was I helpful today?
No unsolicited PMs unless you're planning on asking for paid help.

User avatar
Dugi
Registered User
Posts: 1386
Joined: Sun May 25, 2008 5:36 pm
Location: Mainz, Germany
Name: Dukagjin Surdulli
Contact:

Re: Your feedback on the MOD Database and Validation process

Post by Dugi » Fri Dec 03, 2010 9:16 pm

Sorry guys, my reply/suggestion wasn't meant to make any of you angry :lol:.
PM me for custom extension pricing / My validated MODs / My MODs in development

User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: Your feedback on the MOD Database and Validation process

Post by RMcGirr83 » Fri Dec 03, 2010 9:18 pm

I can't speak for anyone else but I'm not angry at all. :)
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored

User avatar
imkingdavid
Former Team Member
Posts: 2667
Joined: Sun Jul 26, 2009 7:59 pm
Location: EST
Name: David King

Re: Your feedback on the MOD Database and Validation process

Post by imkingdavid » Fri Dec 03, 2010 10:19 pm

Dugi wrote:Sorry guys, my reply/suggestion wasn't meant to make any of you angry :lol:.
I'm not angry, just responding to your suggestion. ;)
Don't forget to smile today. :)
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
Martin Truckenbrodt
Registered User
Posts: 3045
Joined: Sun Mar 23, 2003 6:22 pm
Location: Franconia
Name: Martin Truckenbrodt
Contact:

Re: Your feedback on the MOD Database and Validation process

Post by Martin Truckenbrodt » Sat Dec 04, 2010 2:10 am

Hello,
Some suggestions for MPV:

Please remove the IN_PHPBB check check for the files under :/includes/acp/info/, ./includes/mcp/info/ and ./includes/acp/info/. Files in these folders never are having a IN_PHPBB check included.
Although you could remove the check for the files at the folder ./umil/. Just check the UMIL version only. UMIL is not a part of the MOD itself.

Bye Martin
Free tutorial: Installing MODs in phpBB 3.0
Advanced Block MOD - Prevent spam on your phpBB 3.0 board with Stop Forum Spam, BotScout, Akismet, Project Honey Pot and several IP-RBL and Domain-RBL DNS blacklists!
My MODs
Use the official phpBB Ideas to vote missing core features!!!

Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 25488
Joined: Sat Dec 04, 2004 3:44 pm
Location: The netherlands.
Name: Paul Sohier
Contact:

Re: Your feedback on the MOD Database and Validation process

Post by Paul » Sat Dec 04, 2010 7:42 am

As I said lately in a bugreport, it is kinda hard to remove that check, without creating any false positives. And it is not bad if there is a IN_PHPBB check in that file.
UMIL need to be checked with MPV as well, as there are MOD authors who edit the UMIL files.
Knock knock
Race condition
Who's there?

My BlogMy Photosmy phpBB Extensionscustom phpBB work & Development

User avatar
Martin Truckenbrodt
Registered User
Posts: 3045
Joined: Sun Mar 23, 2003 6:22 pm
Location: Franconia
Name: Martin Truckenbrodt
Contact:

Re: Your feedback on the MOD Database and Validation process

Post by Martin Truckenbrodt » Sat Dec 04, 2010 11:53 am

Hello Paul,
thank you very much for the information!

IN_PHPBB check:
I'm always looking how it is done in phpBB core code (Copy&Paste modding ;) ). For me this is the standard I have to follow. -> If in core files there is no IN_PHPBB check then I will not add it to the MOD files.

UMIL folder:
It's allowed to modify UMIL files? I think this is not a good idea. Although I could imagine that the done edits could be added to the MOD UMIL install file, too. Or not? (It's just a technical question of mine.)

Just my personal thoughts!

Bye Martin
Free tutorial: Installing MODs in phpBB 3.0
Advanced Block MOD - Prevent spam on your phpBB 3.0 board with Stop Forum Spam, BotScout, Akismet, Project Honey Pot and several IP-RBL and Domain-RBL DNS blacklists!
My MODs
Use the official phpBB Ideas to vote missing core features!!!

Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 25488
Joined: Sat Dec 04, 2004 3:44 pm
Location: The netherlands.
Name: Paul Sohier
Contact:

Re: Your feedback on the MOD Database and Validation process

Post by Paul » Sat Dec 04, 2010 12:16 pm

Martin Truckenbrodt wrote:Hello Paul,
thank you very much for the information!

IN_PHPBB check:
I'm always looking how it is done in phpBB core code (Copy&Paste modding ;) ). For me this is the standard I have to follow. -> If in core files there is no IN_PHPBB check then I will not add it to the MOD files.e[]
No, you should follow the coding guidelines, not phpBB itself.
UMIL folder:
It's allowed to modify UMIL files? I think this is not a good idea. Although I could imagine that the done edits could be added to the MOD UMIL install file, too. Or not? (It's just a technical question of mine.)

Just my personal thoughts!

Bye Martin
No, thats not allowed, and thats why MPV checks the files.
Knock knock
Race condition
Who's there?

My BlogMy Photosmy phpBB Extensionscustom phpBB work & Development

User avatar
Martin Truckenbrodt
Registered User
Posts: 3045
Joined: Sun Mar 23, 2003 6:22 pm
Location: Franconia
Name: Martin Truckenbrodt
Contact:

Re: Your feedback on the MOD Database and Validation process

Post by Martin Truckenbrodt » Sat Dec 04, 2010 12:33 pm

Hello Paul,
IN_PHPBB:
Sorry, for me it sound a little bit strange. But it's okay.

UMIL folder:
It's a little bit annoying that several times by now UMIL contains unmodified files which are not validated. E.g. language files which don't have the UNIX file endings. That's the background for my suggestion.

Bye Martin
Free tutorial: Installing MODs in phpBB 3.0
Advanced Block MOD - Prevent spam on your phpBB 3.0 board with Stop Forum Spam, BotScout, Akismet, Project Honey Pot and several IP-RBL and Domain-RBL DNS blacklists!
My MODs
Use the official phpBB Ideas to vote missing core features!!!

Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 25488
Joined: Sat Dec 04, 2004 3:44 pm
Location: The netherlands.
Name: Paul Sohier
Contact:

Re: Your feedback on the MOD Database and Validation process

Post by Paul » Sat Dec 04, 2010 12:58 pm

We have made internal changes to make sure UMIL will pass MPV for the next release by default.
Knock knock
Race condition
Who's there?

My BlogMy Photosmy phpBB Extensionscustom phpBB work & Development

Locked

Return to “[3.0.x] MOD Writers Discussion”