Style Problem in ACP with FireFox

For support and discussion related to templates, themes, and imagesets in phpBB 3.0.
Anti-Spam Guide
User avatar
girlintrouble
Registered User
Posts: 856
Joined: Fri Jan 25, 2008 8:35 pm
Location: UK

Style Problem in ACP with FireFox

Post by girlintrouble » Sat Jun 27, 2009 7:17 pm

Hi
I have a problem with ranks being displayed properly in the ACP
Image
http://www.phpbb.com/community/viewtopi ... 0&t=967635
I contacted the MOD author, he says its a problem with Firefox, he says he used the coding standards for PhpBB so I;m really very surprised we have this problem.
I hate using IE, in fact I virtually swore off it.
I was wondering if anyone here would be willing to take a little look and make any suggestion?
Thank you

User avatar
Elitzur
I've Been Banned!
Posts: 323
Joined: Sat Sep 15, 2007 7:49 am
Location: Europe, UK.
Contact:

Re: Style Problem in ACP with FireFox

Post by Elitzur » Sat Jun 27, 2009 7:28 pm

Well it is more than likely Firefox really, because the MOD Team do check MODs over and over to make sure
no bugs are found, I suggest trying IE just to check or if you really don't want to, download Safari and give that
a go because it is pretty good.

Awinee
Registered User
Posts: 86
Joined: Tue Jun 02, 2009 7:48 pm

Re: Style Problem in ACP with FireFox

Post by Awinee » Sat Jun 27, 2009 7:33 pm

I take it that you didn't modify any files in the /adm/ folder?
If no, i would suggest re-uploading that folder from a freshdownloaded version. Tho, id backup my files first (both in the admin panel + the /adm/ folder you got uploaded atm).

- Martijn

User avatar
girlintrouble
Registered User
Posts: 856
Joined: Fri Jan 25, 2008 8:35 pm
Location: UK

Re: Style Problem in ACP with FireFox

Post by girlintrouble » Sat Jun 27, 2009 9:02 pm

Guys the mod author says this is a known problem with his mod. So latest code has not fixed this problem.
Its not an issue about using IE, Id rather use FF.
What Id prefer is fixing the problem, after all it should be possible shouldnt it?!

Awinee
Registered User
Posts: 86
Joined: Tue Jun 02, 2009 7:48 pm

Re: Style Problem in ACP with FireFox

Post by Awinee » Sat Jun 27, 2009 9:37 pm

Awinee wrote:I take it that you didn't modify any files in the /adm/ folder?
If no, i would suggest re-uploading that folder from a freshdownloaded version. Tho, id backup my files first (both in the admin panel + the /adm/ folder you got uploaded atm).

- Martijn
I gave u a way to TRY to fix it ;)

- Martijn

User avatar
Arty
Former Team Member
Posts: 16654
Joined: Wed Mar 06, 2002 2:36 pm
Name: Vjacheslav Trushkin
Contact:

Re: Style Problem in ACP with FireFox

Post by Arty » Sat Jun 27, 2009 10:40 pm

In code that mod changed in adm/style/acp_users.html find

Code: Select all

<dt><label for="user_rank2">User rank 2:</label></dt>
<dd><select name="user_rank2" id="user_rank2">{S_RANK2_OPTIONS}</select></dd>
<dt><label for="user_rank3">User rank 3:</label></dt>
<dd><select name="user_rank3" id="user_rank3">{S_RANK3_OPTIONS}</select></dd>
and replace with

Code: Select all

<dt style="clear: left;"><label for="user_rank2">User rank 2:</label></dt>
<dd><select name="user_rank2" id="user_rank2">{S_RANK2_OPTIONS}</select></dd>
<dt style="clear: left;"><label for="user_rank3">User rank 3:</label></dt>
<dd><select name="user_rank3" id="user_rank3">{S_RANK3_OPTIONS}</select></dd>
Vjacheslav Trushkin / Arty.
Free phpBB 3.1 styles | New project: Iconify - modern SVG framework

User avatar
girlintrouble
Registered User
Posts: 856
Joined: Fri Jan 25, 2008 8:35 pm
Location: UK

Re: Style Problem in ACP with FireFox

Post by girlintrouble » Sun Jun 28, 2009 9:37 am

Maybe I didnt understand what you said then Awinee :oops: :lol: I never said I was smart.
I did change files in the ADM folder as the mod says and the mod author knows this problem is there it isnt what Ive done (this time :lol: ) that caused it so uploading new files will not help me. Or did you mean something else?

Will try other syggestion
Thanks for looking

User avatar
girlintrouble
Registered User
Posts: 856
Joined: Fri Jan 25, 2008 8:35 pm
Location: UK

Re: Style Problem in ACP with FireFox

Post by girlintrouble » Sun Jun 28, 2009 12:59 pm

CyberAlien Thankyou that is fixed!!!! Im sure the Mod author and many other users will also be very happy and grateful for this fix. I'm very happy.

One last thing, how do I put line spaces in between the rows, they are very squiged together.
Thank you so much again! :D

User avatar
Arty
Former Team Member
Posts: 16654
Joined: Wed Mar 06, 2002 2:36 pm
Name: Vjacheslav Trushkin
Contact:

Re: Style Problem in ACP with FireFox

Post by Arty » Sun Jun 28, 2009 5:47 pm

In that code replace style="clear: left;" with style="clear: left; margin-top: 5px;"

btw, its not a Firefox bug, Firefox shows data correctly. Problem is caused by coding, which didn't account for possibility of left column being longer than right column.
Vjacheslav Trushkin / Arty.
Free phpBB 3.1 styles | New project: Iconify - modern SVG framework

User avatar
girlintrouble
Registered User
Posts: 856
Joined: Fri Jan 25, 2008 8:35 pm
Location: UK

Re: Style Problem in ACP with FireFox

Post by girlintrouble » Sun Jun 28, 2009 9:34 pm

Nearly there:

Image
Second column hasnt got the top margin.
Wonder if we can fix that?

User avatar
Arty
Former Team Member
Posts: 16654
Joined: Wed Mar 06, 2002 2:36 pm
Name: Vjacheslav Trushkin
Contact:

Re: Style Problem in ACP with FireFox

Post by Arty » Sun Jun 28, 2009 9:40 pm

Oh, the problem is completely different. That mod's author forgot <dl> and </dl> before every row. So forget about adding inline style, change that code to something like this

Code: Select all

<dl>
  <dt><label for="user_rank2">User rank 2:</label></dt><
  <dd><select name="user_rank2" id="user_rank2">{S_RANK2_OPTIONS}</select></dd>
</dl>
<dl>
  <dt><label for="user_rank3">User rank 3:</label></dt>
  <dd><select name="user_rank3" id="user_rank3">{S_RANK3_OPTIONS}</select></dd>
</dl>
and make sure code before it also has </dl> and code after it starts with <dl>
Vjacheslav Trushkin / Arty.
Free phpBB 3.1 styles | New project: Iconify - modern SVG framework

User avatar
girlintrouble
Registered User
Posts: 856
Joined: Fri Jan 25, 2008 8:35 pm
Location: UK

Re: Style Problem in ACP with FireFox

Post by girlintrouble » Sun Jun 28, 2009 9:57 pm

Hmmm that works nicely - so looks like there is more than one way too fix this problem depending on how you look at it. :lol:

That has fixed the layout however the font size has gotten smaller for the label and the drop down selection which is a little strange. Back to having a style tag?
Also rather stangely the label side seems to have a odd mouseover effect :? :lol: How strange

User avatar
Arty
Former Team Member
Posts: 16654
Joined: Wed Mar 06, 2002 2:36 pm
Name: Vjacheslav Trushkin
Contact:

Re: Style Problem in ACP with FireFox

Post by Arty » Mon Jun 29, 2009 5:18 pm

Probably there is a double <dl> or some other leftover of old code.
Vjacheslav Trushkin / Arty.
Free phpBB 3.1 styles | New project: Iconify - modern SVG framework

User avatar
girlintrouble
Registered User
Posts: 856
Joined: Fri Jan 25, 2008 8:35 pm
Location: UK

Re: Style Problem in ACP with FireFox

Post by girlintrouble » Sat Jul 04, 2009 5:13 am

I check the edits but I couldnt see anything, all the <dl> have a closing </dl> and all <dt> </dt> are enclosed in <dl> </dl>.
This is whatthe size was before:
Image
This is the font size now:
Image
This is my code:

Code: Select all

<!-- INCLUDE overall_header.html -->

<a name="maincontent"></a>

<!-- IF S_SELECT_USER -->

	<h1>{L_USER_ADMIN}</h1>

	<p>{L_USER_ADMIN_EXPLAIN}</p>

	<form id="select_user" method="post" action="{U_ACTION}">

	<fieldset>
		<legend>{L_SELECT_USER}</legend>
	<dl>
		<dt><label for="username">{L_FIND_USERNAME}:</label></dt>
		<dd><input class="text medium" type="text" id="username" name="username" /></dd>
		<dd>[ <a href="{U_FIND_USERNAME}" onclick="find_username(this.href); return false;">{L_FIND_USERNAME}</a> ]</dd>
		<dd class="full" style="text-align: left;"><label><input type="checkbox" class="radio" id="anonymous" name="u" value="{ANONYMOUS_USER_ID}" /> {L_SELECT_ANONYMOUS}</label></dd>
	</dl>

	<p class="quick">
		<input type="submit" name="submituser" value="{L_SUBMIT}" class="button1" />
	</p>
	</fieldset>

	</form>

<!-- ELSEIF S_SELECT_FORUM -->

	<a href="{U_BACK}" style="float: {S_CONTENT_FLOW_END};">&laquo; {L_BACK}</a>

	<h1>{L_USER_ADMIN}</h1>

	<p>{L_USER_ADMIN_EXPLAIN}</p>

	<form id="select_forum" method="post" action="{U_ACTION}">

	<fieldset>
		<legend>{L_USER_ADMIN_MOVE_POSTS}</legend>
	<dl>
		<dt><label for="new_forum">{L_USER_ADMIN_MOVE_POSTS}</label><br /><span>{L_MOVE_POSTS_EXPLAIN}</span></dt>
		<dd><select id="new_forum" name="new_f">{S_FORUM_OPTIONS}</select></dd>
	</dl>
	</fieldset>

	<fieldset class="quick">
		<input type="submit" name="update" value="{L_SUBMIT}" class="button1" />
		{S_FORM_TOKEN}
	</fieldset>
	</form>

<!-- ELSE -->

	<a href="{U_BACK}" style="float: {S_CONTENT_FLOW_END};">&laquo; {L_BACK}</a>

	<h1>{L_USER_ADMIN} :: {MANAGED_USERNAME}</h1>

	<p>{L_USER_ADMIN_EXPLAIN}</p>

	<!-- IF S_ERROR -->
		<div class="errorbox">
			<h3>{L_WARNING}</h3>
			<p>{ERROR_MSG}</p>
		</div>
	<!-- ENDIF -->

	<form id="mode_select" method="post" action="{U_MODE_SELECT}">

	<fieldset class="quick">
		{L_SELECT_FORM}: <select name="mode" onchange="if (this.options[this.selectedIndex].value != '') this.form.submit();">{S_FORM_OPTIONS}</select> <input class="button2" type="submit" value="{L_GO}" />
		{S_FORM_TOKEN}
	</fieldset>
	</form>

<!-- ENDIF -->

<!-- IF S_OVERVIEW -->

<!-- INCLUDE acp_users_overview.html -->

<!-- ELSEIF S_FEEDBACK -->

<!-- INCLUDE acp_users_feedback.html -->

<!-- ELSEIF S_PROFILE -->

<!-- INCLUDE acp_users_profile.html -->

<!-- ELSEIF S_PREFS -->

<!-- INCLUDE acp_users_prefs.html -->

<!-- ELSEIF S_AVATAR -->

<!-- INCLUDE acp_users_avatar.html -->

<!-- ELSEIF S_RANK -->

	<form id="user_prefs" method="post" action="{U_ACTION}">

	<fieldset>
		<legend>{L_ACP_USER_RANK}</legend>
	<dl>
		<dl>    <dt><label for="user_rank">{L_USER_RANK}:</label></dt>
		<dd><select name="user_rank" id="user_rank">{S_RANK_OPTIONS}</select></dd> 		</dl>
		<dl>    <dt><label for="user_rank2">User rank 2:</label></dt>
		<dd><select name="user_rank2" id="user_rank2">{S_RANK2_OPTIONS}</select></dd> 	</dl>
        <dl>	<dt><label for="user_rank3">User rank 3:</label></dt>
		<dd><select name="user_rank3" id="user_rank3">{S_RANK3_OPTIONS}</select></dd>	</dl>
        <dl>	<dt><label for="user_rank4">User rank 4:</label></dt>
		<dd><select name="user_rank4" id="user_rank4">{S_RANK4_OPTIONS}</select></dd>	</dl>
        <dl>	<dt><label for="user_rank5">User rank 5:</label></dt>
		<dd><select name="user_rank5" id="user_rank5">{S_RANK5_OPTIONS}</select></dd>	</dl>
		<dl>	<dt><label for="user_rank6">User rank 6:</label></dt>
		<dd><select name="user_rank6" id="user_rank6">{S_RANK6_OPTIONS}</select></dd>	</dl>
	</dl>
	</fieldset>

	<fieldset class="quick">
		<input class="button1" type="submit" name="update" value="{L_SUBMIT}" />
		{S_FORM_TOKEN}
	</fieldset>
	</form>

<!-- ELSEIF S_SIGNATURE -->

<!-- INCLUDE acp_users_signature.html -->

<!-- ELSEIF S_GROUPS -->

	<form id="user_groups" method="post" action="{U_ACTION}">

	<table cellspacing="1">
	<tbody>
	<!-- BEGIN group -->
		<!-- IF group.S_NEW_GROUP_TYPE -->
		<tr>
			<td class="row3" colspan="4"><strong>{group.GROUP_TYPE}</strong></td>
		</tr>
		<!-- ELSE -->
			<!-- IF group.S_ROW_COUNT is even --><tr class="row1"><!-- ELSE --><tr class="row2"><!-- ENDIF -->
				<td><a href="{group.U_EDIT_GROUP}">{group.GROUP_NAME}</a></td>
				<td><!-- IF group.S_NO_DEFAULT --><a href="{group.U_DEFAULT}">{L_GROUP_DEFAULT}</a><!-- ELSE --><strong>{L_GROUP_DEFAULT}</strong><!-- ENDIF --></td>
				<td><!-- IF not group.S_SPECIAL_GROUP --><a href="{group.U_DEMOTE_PROMOTE}">{group.L_DEMOTE_PROMOTE}</a><!-- ELSE -->&nbsp;<!-- ENDIF --></td>
				<td><a href="{group.U_DELETE}">{L_GROUP_DELETE}</a></td>
			</tr>
		<!-- ENDIF -->
	<!-- END group -->
	</tbody>
	</table>

	<!-- IF S_GROUP_OPTIONS -->
		<fieldset class="quick">
			{L_USER_GROUP_ADD}: <select name="g">{S_GROUP_OPTIONS}</select> <input class="button1" type="submit" name="update" value="{L_SUBMIT}" />
			{S_FORM_TOKEN}
		</fieldset>
	<!-- ENDIF -->
	</form>

<!-- ELSEIF S_ATTACHMENTS -->

	<form id="user_attachments" method="post" action="{U_ACTION}">


	<!-- IF PAGINATION -->
	<div class="pagination">
		<a href="#" onclick="jumpto(); return false;" title="{L_JUMP_TO_PAGE}">{S_ON_PAGE}</a> &bull; <span>{PAGINATION}</span>
	</div>
	<!-- ENDIF -->

	<!-- IF .attach -->
	<table cellspacing="1">
	<thead>
	<tr>
		<th>{L_FILENAME}</th>
		<th>{L_POST_TIME}</th>
		<th>{L_FILESIZE}</th>
		<th>{L_DOWNLOADS}</th>
		<th>{L_MARK}</th>
	</tr>
	</thead>
	<tbody>
	<!-- BEGIN attach -->
		<!-- IF attach.S_ROW_COUNT is even --><tr class="row1"><!-- ELSE --><tr class="row2"><!-- ENDIF -->
		<td><a href="{attach.U_DOWNLOAD}">{attach.REAL_FILENAME}</a><br /><span class="small"><!-- IF attach.S_IN_MESSAGE --><strong>{L_PM}: </strong><!-- ELSE --><strong>{L_POST}: </strong><!-- ENDIF --><a href="{attach.U_VIEW_TOPIC}">{attach.TOPIC_TITLE}</a></span></td>
		<td style="text-align: center">{attach.POST_TIME}</td>
		<td style="text-align: center">{attach.SIZE}</td>
		<td style="text-align: center">{attach.DOWNLOAD_COUNT}</td>
		<td style="text-align: center"><input type="checkbox" class="radio" name="mark[]" value="{attach.ATTACH_ID}" /></td>
	</tr>
	<!-- END attach -->
	</tbody>
	</table>
	<!-- ELSE -->
	<div class="errorbox">
		<p>{L_USER_NO_ATTACHMENTS}</p>
	</div>
	<!-- ENDIF -->
	<fieldset class="display-options">
		{L_SORT_BY}: <select name="sk">{S_SORT_KEY}</select> <select name="sd">{S_SORT_DIR}</select>
		<input class="button2" type="submit" value="{L_GO}" name="sort" />
	</fieldset>
	<hr />
	<!-- IF PAGINATION -->
	<div class="pagination">
		<a href="#" onclick="jumpto(); return false;" title="{L_JUMP_TO_PAGE}">{S_ON_PAGE}</a> &bull; <span>{PAGINATION}</span>
	</div>
	<!-- ENDIF -->
	
	<fieldset class="quick">
		<input class="button2" type="submit" name="delmarked" value="{L_DELETE_MARKED}" />
		<p class="small"><a href="#" onclick="marklist('user_attachments', 'mark', true);">{L_MARK_ALL}</a> &bull; <a href="#" onclick="marklist('user_attachments', 'mark', false);">{L_UNMARK_ALL}</a></p>
		{S_FORM_TOKEN}
	</fieldset>
	</form>

<!-- ELSEIF S_PERMISSIONS -->

	<div style="float: {S_CONTENT_FLOW_END};">
		<a href="{U_USER_PERMISSIONS}">&raquo; {L_SET_USERS_PERMISSIONS}</a><br />
		<a href="{U_USER_FORUM_PERMISSIONS}">&raquo; {L_SET_USERS_FORUM_PERMISSIONS}</a>
	</div>

	<form id="select_forum" method="post" action="{U_ACTION}">

		<fieldset class="quick" style="text-align: left;">
			{L_SELECT_FORUM}: <select name="f">{S_FORUM_OPTIONS}</select> 
			<input class="button2" type="submit" value="{L_GO}" name="select" />
			{S_FORM_TOKEN}
		</fieldset>
	</form>

	<div class="clearfix">&nbsp;</div>

	<!-- INCLUDE permission_mask.html -->

<!-- ENDIF -->

<!-- INCLUDE overall_footer.html -->
Hope you can help? Thanks

User avatar
Arty
Former Team Member
Posts: 16654
Joined: Wed Mar 06, 2002 2:36 pm
Name: Vjacheslav Trushkin
Contact:

Re: Style Problem in ACP with FireFox

Post by Arty » Sat Jul 04, 2009 7:43 am

There are extra <dl> and </dl>.

Notice 2 <dl> in a row (delete one):

Code: Select all

          <legend>{L_ACP_USER_RANK}</legend>
       <dl>
          <dl>    <dt><label for="user_rank">{L_USER_RANK}:</label></dt>
and 2 </dl> in a row (also delete one):

Code: Select all

          <dd><select name="user_rank6" id="user_rank6">{S_RANK6_OPTIONS}</select></dd>   </dl>
       </dl>
       </fieldset>
Vjacheslav Trushkin / Arty.
Free phpBB 3.1 styles | New project: Iconify - modern SVG framework

Locked

Return to “[3.0.x] Styles Support & Discussion”