subsilver2 postlink class missing?

For support and discussion related to templates, themes, and imagesets in phpBB 3.0.
Get Involved
Locked
kulinar
Registered User
Posts: 651
Joined: Thu Feb 17, 2005 7:31 pm
Contact:

subsilver2 postlink class missing?

Post by kulinar » Mon Jul 04, 2011 8:52 am

Am I wrong or postlink class is missing in subsilver2 css files? I searched (grep-ed) throughout the subsilver2 files but I couldn't find such class defined although it is used it /styles/subsilver2/template/faq_body.html and /styles/subsilver2/template/bbcode.html.

In prosilver it is defined in /styles/prosilver/theme/links.css but I use subsilver2.

What is the prosilver's postlink alternative in subsilver2?

Thanks in advance

User avatar
Lumpy Burgertushie
Registered User
Posts: 66849
Joined: Mon May 02, 2005 3:11 am
Contact:

Re: subsilver2 postlink class missing?

Post by Lumpy Burgertushie » Mon Jul 04, 2011 1:34 pm

I think you may have found a bug. It is only used twice in the files ( as you mentioned ) . I bet nobody every noticed it was left over.
It is not hurting anything because it is not doing anything. You could just remove the reference to that class in both of those files if you wanted to.

robert
I'm baaaaaccckkkk. still doing work on donation basis. PM your needs.

Premium phpBB 3.2 Styles by PlanetStyles.net

If a tree falls in the forest and nobody is there, does it make a sound?

kulinar
Registered User
Posts: 651
Joined: Thu Feb 17, 2005 7:31 pm
Contact:

Re: subsilver2 postlink class missing?

Post by kulinar » Mon Jul 04, 2011 1:57 pm

In fact this class is used in one more file in phpBB3 - includes/functions_content.php

You are right, the bug does no harm but it causes some design issues (bad look nothing more). I fixed that by adding postlink class in my stylesheet.css but I guess not every user is capable of doing so.

at the end of the stysheet.css add:

Code: Select all

.postlink {
	color: #000000 !important;
}

User avatar
Arty
Former Team Member
Posts: 16654
Joined: Wed Mar 06, 2002 2:36 pm
Name: Vjacheslav Trushkin
Contact:

Re: subsilver2 postlink class missing?

Post by Arty » Mon Jul 04, 2011 2:07 pm

Its not a bug.

There are two types of URLs in phpBB: ones that are parsed from "url" bbcode and ones that are detected from message text, such as this one: http://www.phpbb.com/

BBCode parser uses bbcode.html to parse first one, but it uses hardcoded regular expression to parse second one. First one has class="postlink" in default bbcode.html for prosilver and subsilver, second one has hardcoded class="postlink" in make_clickable() in functions_content.php so all links would have same class in both default styles.

subsilver doesn't use that class, so that's why you didn't find it in css file
Vjacheslav Trushkin / Arty.
Free phpBB 3.1 styles | New project: Iconify - modern SVG framework

User avatar
Lumpy Burgertushie
Registered User
Posts: 66849
Joined: Mon May 02, 2005 3:11 am
Contact:

Re: subsilver2 postlink class missing?

Post by Lumpy Burgertushie » Mon Jul 04, 2011 3:00 pm

CyberAlien wrote:Its not a bug.

There are two types of URLs in phpBB: ones that are parsed from "url" bbcode and ones that are detected from message text, such as this one: http://www.phpbb.com/

BBCode parser uses bbcode.html to parse first one, but it uses hardcoded regular expression to parse second one. First one has class="postlink" in default bbcode.html for prosilver and subsilver, second one has hardcoded class="postlink" in make_clickable() in functions_content.php so all links would have same class in both default styles.

subsilver doesn't use that class, so that's why you didn't find it in css file
If it does not use the class why is it there?
I know I am probably being dumb here, but if there is no need for it in the code and it is still there, then why is that not a bug?
I'm baaaaaccckkkk. still doing work on donation basis. PM your needs.

Premium phpBB 3.2 Styles by PlanetStyles.net

If a tree falls in the forest and nobody is there, does it make a sound?

User avatar
Arty
Former Team Member
Posts: 16654
Joined: Wed Mar 06, 2002 2:36 pm
Name: Vjacheslav Trushkin
Contact:

Re: subsilver2 postlink class missing?

Post by Arty » Mon Jul 04, 2011 3:32 pm

It can be used by style authors to easily add custom style to links inside posts, so its useful.
Vjacheslav Trushkin / Arty.
Free phpBB 3.1 styles | New project: Iconify - modern SVG framework

User avatar
Lumpy Burgertushie
Registered User
Posts: 66849
Joined: Mon May 02, 2005 3:11 am
Contact:

Re: subsilver2 postlink class missing?

Post by Lumpy Burgertushie » Mon Jul 04, 2011 6:41 pm

CyberAlien wrote:It can be used by style authors to easily add custom style to links inside posts, so its useful.
Ok, that doesn't really make any sense to me but ... oh well. with that logic you could put all sorts of calls to all sorts of css classes that do not exist , on the premise that maybe someday a style author might be able to use them.

or am I just not understanding what you are saying?

robert
I'm baaaaaccckkkk. still doing work on donation basis. PM your needs.

Premium phpBB 3.2 Styles by PlanetStyles.net

If a tree falls in the forest and nobody is there, does it make a sound?

User avatar
Arty
Former Team Member
Posts: 16654
Joined: Wed Mar 06, 2002 2:36 pm
Name: Vjacheslav Trushkin
Contact:

Re: subsilver2 postlink class missing?

Post by Arty » Mon Jul 04, 2011 7:30 pm

You are missing one important point: that link's html code is hardcoded in php files.

Its code can't be changed in templates, so developers added class to it, so style authors could add style to it. Prosilver uses that class, most other styles use it.
Vjacheslav Trushkin / Arty.
Free phpBB 3.1 styles | New project: Iconify - modern SVG framework

Locked

Return to “[3.0.x] Styles Support & Discussion”