[2.0.8] Form SetFocus MOD

AbelaJohnB · Post by **AbelaJohnB** » Fri Jun 13, 2003 2:27 am

MOD Name: Form SetFocus MOD
Author: AbelaJohnB
MOD Description: This MOD will set your cursor to be auto-focused on most (but not all) forms within phpBB. Uses simple JavaScript.

MOD Version: 1.0.0

Download File: setfocus.mod
File Size: 7403 Bytes

AbelaJohnB · Post by **AbelaJohnB** » Tue Jun 17, 2003 1:41 am

MOD Validated/Released

deny · Post by **deny** » Tue Jun 17, 2003 11:25 am

Work this MOds with phpbb 2.0.4?

romans1423 · Post by **romans1423** » Tue Jun 17, 2003 7:56 pm

Won't this affect the BBCode JavaScript, which reference the posting form by the name "post", not "form" (which this MOD changes it to)??

AbelaJohnB · Post by **AbelaJohnB** » Tue Jun 17, 2003 8:33 pm

romans1423 wrote: Won't this affect the BBCode JavaScript, which reference the posting form by the name "post", not "form" (which this MOD changes it to)??

If you find that happening, I'd be interrested in knowing about it.

romans1423 · Post by **romans1423** » Tue Jun 17, 2003 8:38 pm

John,
Well, I solved the problem before I even tried to see if it was really a problem... I simply edited all the BBCode JS to reference the new form name instead of the old.

However, the JavaScript that you add to the overall_header results in an error on any page that doesn't have a modded form since the header JS references the forms which don't exist on every page... Minor problem yes, but I have removed the MOD until further notice.

I love the idea though!

Daz · Post by **Daz** » Thu Jun 19, 2003 3:55 pm

romans1423,

Have a read of This...

Carpe Diem · Post by **Carpe Diem** » Fri Jun 20, 2003 11:58 pm

romans1423 wrote: Won't this affect the BBCode JavaScript, which reference the posting form by the name "post", not "form" (which this MOD changes it to)??

I really don't understand what kind of a problem you mean this would generate?

I have installed this mod in its original shape, meaning I have only made the same changes that was said in the mod instruction file without changing any other coding text for the bbcode JS, and everything seems to be working just fine.. the submitting of a post with or without bbcodes works just fine so I don't understand what kind of errors I should look for??

I'm using a 2.0.4 board..

GPHemsley · Post by **GPHemsley** » Sat Jun 21, 2003 12:40 am

Carpe Diem wrote: I'm using a 2.0.4 board..

That could be the reason you are not haveing problems... This is a 2.0.5 MOD... (Weird, I know)

Carpe Diem · Post by **Carpe Diem** » Wed Jun 25, 2003 10:01 am

GPHemsley wrote:
Carpe Diem wrote:I'm using a 2.0.4 board..

That could be the reason you are not haveing problems... This is a 2.0.5 MOD... (Weird, I know)

Aha.. hmm... oh well I've decided NOT to upgrade to 2.0.5 for now, as the id_session part is also removed in 2.0.5 and that obviously creates some problems.. anyway thx for the response! 2.0.4 is running without any hassles on my testboard for now so, I'm satisfied.

quentin · Post by **quentin** » Wed Jun 25, 2003 12:57 pm

However, the JavaScript that you add to the overall_header results in an error on any page that doesn't have a modded form since the header JS references the forms which don't exist on every page...

That can be easily solved by checking the form exists in the javascript before doing anything.
Nice mod.

Quentin

Whip-lash · Post by **Whip-lash** » Thu Jul 10, 2003 5:05 pm

AbelaJohnB wrote:
romans1423 wrote:Won't this affect the BBCode JavaScript, which reference the posting form by the name "post", not "form" (which this MOD changes it to)??

If you find that happening, I'd be interrested in knowing about it.

Erm, it's happening...

Please excuse me as I am not very knowlegable in JavaScript, so I'm not sure what I should do to fix this. I'm using 2.0.5, with the Attachment and Visual Verification mods.

Pages without the modified forms specified in the mod documentation get the following error: 'document.form.elements' is null or not an object.

I think what quentin noted should resolve this, that is if the JavaScript could check if the form existed on the page before trying to SetFocus.

Pages with the modified forms that also use the BBcode buttons get errors simlar to this: 'document.post.message' is null or not an object.

What should resolve this would be to have the BBcode use "form" instead of "post"...

Any ideas?

Whip-lash · Post by **Whip-lash** » Fri Jul 11, 2003 12:42 pm

Just wondering if anyone had any thoughts about this yet..., so... *bump*

drathbun · Post by **drathbun** » Fri Jul 11, 2003 1:46 pm

I got a version of this mod a long time ago (not this one, someone else wrote it). Here's the javascript that is used, which only works if it finds a form, and then finds the first empty field in that form.

Code: Select all

function focusTextField (form) {

        // first, validate form objects
        if ((typeof form != 'object') || (typeof form.elements != 'object')) {
                return false;
        }

        // set array of elements
        var elements = form.elements;

        // loop through array of elements, finding the first empty input field
        // set focus to that field
        for (var i = 0; i < elements.length; i++) {
                if ((elements[i].type != 'text') &&
                        (elements[i].type != 'password') &&
                        (elements[i].type != 'textarea'))
                {
                        continue;
                }
                if (elements[i].name == 'helpbox') {
                        continue;
                }
                if (elements[i].value == '') {
                        elements[i].focus();
                        break;
                }
        }
        return true;
}

The form name is passed as a parameter. I've been using this for over a year with various versions of phpBB and not had any problems. There are a few hard-coded values to handle specific cases on specific forms.

Dave

Haywood Jahelpme · Post by **Haywood Jahelpme** » Thu Oct 16, 2003 10:56 am

looks sweet... Thanks!

Rating: