RMcGirr83 wrote:Congrats on the validation Tom!!
I ran across an issue recently after installing this and updating the board to 3.0.6-RC2. As you may be aware 3.0.6 adds a new group ("Newly Registered Users"). This new group did not present itself in your new panel to be "moved" even though I selected the group to display on the legend.
The reason that the "Newly Registered Users" group is not showing up on the repositioning panel after installing on 3.0.5 and updating to 3.0.6-RC2 is because, after the code edits are done for the MOD, you ran the install_legend_repositioning.php
file and it gave an incrementing numeric value in the group_position
field for each of your existing groups in the database. However, once you updated to 3.0.6-RC2 it added the "Newly Registered Users" group, but that group was not assigned a numeric value for the group_position
field. Therefore, it didn't show up on the repositioning panel in the ACP on purpose because I designed the panel so that it would only list the groups that have a numeric value for the group_position
field. This prevents some problems that may occur when you try to reposition a group that has a group_position
value of "0". Your fix will work, but it will no longer show groups that are not shown on the legend in the repositioning panel, and that could be a problem. The reason it could be a problem is because I purposely wanted all groups listed in the repositioning panel (whether they're on the legend or not) so that you can see how each group would be positioned on the legend if it was to be shown there. That's why in the repositioning panel groups that are listed on the legend show up with a light-blue background, and groups that aren't listed on the legend have a white background.
This wouldn't be a problem if the MOD was installed directly on a 3.0.6-RC2 installation, but if it is installed on a 3.0.5 installation and is then updated to 3.0.6-RC2, then that is where problems will arise. I'll need to create a quick fix script that can be run to give a value in the group_position
field for the "Newly Registered Users" group - that should fix this problem. I'll get to posting the "fix script" for this issue later today.
Thank you for pointing this out. I submitted this MOD before 3.0.6-RC1 was released, so I never needed to think about an issue like this (because 3.0.5 was the "latest greatest" at the time).
I appreciate you checking it out.