[ABD] phpBB Garage 2.0

Any abandoned MODs will be moved to this forum.

WARNING: MODs in this forum are not currently being supported or maintained by the original MOD author. Proceed at your own risk.
Forum rules
IMPORTANT: MOD Development Forum rules

WARNING: MODs in this forum are not currently being supported nor updated by the original MOD author. Proceed at your own risk.
Locked
User avatar
Steve
Registered User
Posts: 997
Joined: Tue Apr 07, 2009 7:48 pm
Location: UK ,up north!!
Name: Steven Clark

Re: [DEV] phpBB Garage 2.0

Post by Steve » Wed Oct 06, 2010 8:36 pm

poyntesm wrote:OK, thanks all for posts. Just made my first commit in a long time. Updated to UMIL 1.0.3 and MODX 1.2.5 :)

Have 3.0.7-PL1 up and AutoMOD 1.0.0 , so I have tested and fixed install to latest now.

So ... next to the real stuff :)

Make sure you read my pm on your garage forum ;) ,i included html valid files but i did forget to say that the adm/style/acp_garage_quota.html layout needs some work it looks wrong ;) so never bothered!
phpBB is fun!! :)
Topic/Post Reactions|phpBB Vehicle Showroom + Market Place + Tracks + 1/4 Mile | Calendar
All coming back for testing soon. (dated 6/11/2019)

User avatar
Blue Blood
Registered User
Posts: 763
Joined: Sat Apr 11, 2009 7:09 am
Location: U§A
Name: Blue Blood
Contact:

Re: [DEV] phpBB Garage 2.0

Post by Blue Blood » Thu Oct 07, 2010 4:18 am

matt1206 wrote: This is trying to insert an empty value into the array. All the other values are being checked to see if they are empty, and then directing you to the EID=3 page.

To fix this, you need to add the value shop_id to the array that is passed to the check_required_vars function

garage_modification.php

Line 206
Find:

Code: Select all

$params = array('category_id', 'manufacturer_id', 'product_id');
   
Change To:

Code: Select all

$params = array('category_id', 'manufacturer_id', 'shop_id', 'product_id');
   
This is not working...
I will fill all fields and now I always get this

Code: Select all

Garage Error Occured

Required Field Missing

A Field Marked As [Required] Was Not Filled In
Please Use Your Browsers Back Button And Fill It In

User avatar
EFiNSTORM
Registered User
Posts: 160
Joined: Fri Dec 26, 2008 4:09 am
Location: localhost

Re: [DEV] phpBB Garage 2.0

Post by EFiNSTORM » Thu Oct 07, 2010 7:02 am

poyntesm wrote:Well first things first I will need to get any critical bugs fixed.. stuff that is causing error pages.

So if you have any repeatable bugs let me know. Second I still wuold love a CSS person or someone with good CSS skills to help me.

I am not adding any features or adjusting how it works. Goal no.1 is get this into mod DB in a working state. Improvements are for later. So stuff like hilight boxes or whatever need to wait.

My own site is still spam filled so post them here for now.
I could help out with the css since i know abit depends how much things need to be done.


EDIT:
This how mine is styled
http://speedjunkies.org/forums/garage_v ... icle&VID=1

User avatar
matt1206
Registered User
Posts: 213
Joined: Wed Mar 08, 2006 3:04 pm
Location: Sheffield, UK
Name: Matt Worthington

Re: [DEV] phpBB Garage 2.0

Post by matt1206 » Thu Oct 07, 2010 7:04 am

Blue Blood wrote:This is not working...
I will fill all fields and now I always get this

Code: Select all

Garage Error Occured

Required Field Missing

A Field Marked As [Required] Was Not Filled In
Please Use Your Browsers Back Button And Fill It In
Works fine for me, I changed that bit of code in Feb 2009, and haven't had any issues.

I can also replicate the mysql error by not selecting an Installed By value
General Error
SQL ERROR [ mysqli ]

Incorrect integer value: '' for column 'installer_id' at row 1 [1366]

SQL

INSERT INTO phpbb_garage_modifications (vehicle_id, user_id, category_id, product_id, shop_id, installer_id, price, purchase_rating, comments, install_price, install_rating, install_comments, product_rating, date_created, date_updated) VALUES ('1', '2', '1', '183', '28', '', '10.0', 10, '', '10.0', 10, '', 10, 1286434859, 1286434859)

BACKTRACE

FILE: includes/db/mysqli.php
LINE: 163
CALL: dbal->sql_error()

FILE: includes/mods/class_garage_modification.php
LINE: 54
CALL: dbal_mysqli->sql_query()

FILE: garage_modification.php
LINE: 212
CALL: garage_modification->insert_modification()
so I added the installer_id value to the array

Code: Select all

$params = array('category_id', 'manufacturer_id', 'shop_id', 'product_id', 'installer_id'); 
I can replicate your issue, but only by editing the array, and trying to then submit the php page. You need to navigate away from the modification page, and go back to it, and try again.

emsik
Registered User
Posts: 102
Joined: Wed Jul 01, 2009 12:55 pm

Re: [DEV] phpBB Garage 2.0

Post by emsik » Thu Oct 07, 2010 8:44 am

good to know that project is being started again :D

User avatar
poyntesm
Registered User
Posts: 1671
Joined: Tue Jan 18, 2005 11:19 am
Location: Dublin, Ireland
Contact:

Re: [DEV] phpBB Garage 2.0

Post by poyntesm » Thu Oct 07, 2010 8:48 am

Will I be working with the SMF team? No. Just no time to do that.

Steve, your files in the PM are same to latest revision? Did you attach correct ones?

User avatar
poyntesm
Registered User
Posts: 1671
Joined: Tue Jan 18, 2005 11:19 am
Location: Dublin, Ireland
Contact:

Re: [DEV] phpBB Garage 2.0

Post by poyntesm » Thu Oct 07, 2010 2:32 pm

Blue Blood wrote:
matt1206 wrote: This is trying to insert an empty value into the array. All the other values are being checked to see if they are empty, and then directing you to the EID=3 page.

To fix this, you need to add the value shop_id to the array that is passed to the check_required_vars function

garage_modification.php

Line 206
Find:

Code: Select all

$params = array('category_id', 'manufacturer_id', 'product_id');
   
Change To:

Code: Select all

$params = array('category_id', 'manufacturer_id', 'shop_id', 'product_id');
   
This is not working...
I will fill all fields and now I always get this

Code: Select all

Garage Error Occured

Required Field Missing

A Field Marked As [Required] Was Not Filled In
Please Use Your Browsers Back Button And Fill It In
No this is correct but not complete. That array is the list of required fields but its not correct its missing shop_id and installer_id. Correct line is

Code: Select all

        $params = array('category_id', 'manufacturer_id', 'product_id', 'shop_id', 'installer_id');
However that is against latest SVN, I can not promise as my memory is not great when the style/html side matched those input names... but would have thought its been like that for a while.

User avatar
poyntesm
Registered User
Posts: 1671
Joined: Tue Jan 18, 2005 11:19 am
Location: Dublin, Ireland
Contact:

Re: [DEV] phpBB Garage 2.0

Post by poyntesm » Thu Oct 07, 2010 2:47 pm

matt1206 wrote:

Code: Select all

General Error
SQL ERROR [ mysqli ]

Unknown column 'p.business_id' in 'where clause' [1054]

SQL

SELECT v.*, i.*, mk.make, md.model, u.username, u.user_colour, count(m.id) AS total_mods FROM (phpbb_garage_vehicles v, phpbb_garage_makes mk, phpbb_garage_models md, phpbb_users u) LEFT JOIN phpbb_garage_modifications m ON (v.id = m.vehicle_id) LEFT JOIN phpbb_garage_vehicles_gallery vg ON (v.id = vg.vehicle_id AND vg.hilite = 1) LEFT JOIN phpbb_garage_images i ON (vg.image_id = i.attach_id) WHERE v.pending = 0 AND (v.make_id = mk.id and mk.pending = 0) AND (v.model_id = md.id and md.pending = 0) AND v.user_id = u.user_id AND p.business_id = 4 GROUP BY v.id ORDER BY date_created ASC LIMIT 30

BACKTRACE


FILE: includes/db/mysqli.php
LINE: 163
CALL: dbal->sql_error()

FILE: includes/db/mysqli.php
LINE: 205
CALL: dbal_mysqli->sql_query()

FILE: includes/db/dbal.php
LINE: 170
CALL: dbal_mysqli->_sql_query_limit()

FILE: includes/mods/class_garage.php
LINE: 757
CALL: dbal->sql_query_limit()

FILE: garage.php
LINE: 474
CALL: garage->perform_search()
I got it after using of garage search function for Modification Manufacturer. If you select Modification Manufacturer and click search you will get this error

OK, it looks like the bug is with how you tell the search to display the results. You get the sql error when you search on product, and set the "Display Results As" Vehicle
Ok, seems I still understand me code which is VERY good :)

So

Code: Select all

				'LEFT_JOIN'	=> array(
					array(
						'FROM'	=> array(GARAGE_MODIFICATIONS_TABLE => 'm'),
						'ON'	=> 'v.id = m.vehicle_id'
					)
					,array(
						'FROM'	=> array(GARAGE_VEHICLE_GALLERY_TABLE => 'vg'),
						'ON'	=> 'v.id = vg.vehicle_id AND vg.hilite = 1'
					)
Becomes

Code: Select all

				'LEFT_JOIN'	=> array(
					array(
						'FROM'	=> array(GARAGE_MODIFICATIONS_TABLE => 'm'),
						'ON'	=> 'v.id = m.vehicle_id'
					)
					,array(
						'FROM'	=> array(GARAGE_PRODUCTS_TABLE => 'p'),
						'ON'	=> 'p.id = m.product_id'
					)
					,array(
						'FROM'	=> array(GARAGE_VEHICLE_GALLERY_TABLE => 'vg'),
						'ON'	=> 'v.id = vg.vehicle_id AND vg.hilite = 1'
					)
However I thought I had tested all permutations of search to find such errors but appears not. So I will need to retest all search criteria for all display types. Feel free though to help and do the same with your data set.

User avatar
matt1206
Registered User
Posts: 213
Joined: Wed Mar 08, 2006 3:04 pm
Location: Sheffield, UK
Name: Matt Worthington

Re: [DEV] phpBB Garage 2.0

Post by matt1206 » Thu Oct 07, 2010 3:37 pm

poyntesm wrote:
Blue Blood wrote:
matt1206 wrote: This is trying to insert an empty value into the array. All the other values are being checked to see if they are empty, and then directing you to the EID=3 page.

To fix this, you need to add the value shop_id to the array that is passed to the check_required_vars function

garage_modification.php

Line 206
Find:

Code: Select all

$params = array('category_id', 'manufacturer_id', 'product_id');
   
Change To:

Code: Select all

$params = array('category_id', 'manufacturer_id', 'shop_id', 'product_id');
   
This is not working...
I will fill all fields and now I always get this

Code: Select all

Garage Error Occured

Required Field Missing

A Field Marked As [Required] Was Not Filled In
Please Use Your Browsers Back Button And Fill It In
No this is correct but not complete. That array is the list of required fields but its not correct its missing shop_id and installer_id. Correct line is

Code: Select all

        $params = array('category_id', 'manufacturer_id', 'product_id', 'shop_id', 'installer_id');
However that is against latest SVN, I can not promise as my memory is not great when the style/html side matched those input names... but would have thought its been like that for a while.
Yep, I found that earlier on:
http://www.phpbb.com/community/viewtopi ... #p12875017

Works as expected. I could also replicate his issue even with the updated data in the php file. You have to navigate away from the page (refresh doesn't work) and navigate back to it and start again.

User avatar
poyntesm
Registered User
Posts: 1671
Joined: Tue Jan 18, 2005 11:19 am
Location: Dublin, Ireland
Contact:

Re: [BETA] phpBB Garage 2.0

Post by poyntesm » Thu Oct 07, 2010 7:03 pm

matt1206 wrote:One thing which really bugged me was the white background on the tabs when browsing a vehicle. ......
Nice find and fix. Thanks. Have added this now.

User avatar
poyntesm
Registered User
Posts: 1671
Joined: Tue Jan 18, 2005 11:19 am
Location: Dublin, Ireland
Contact:

Re: [BETA] phpBB Garage 2.0

Post by poyntesm » Thu Oct 07, 2010 7:08 pm

thejdm wrote:.... it was the easiest edit i done on phpbb ever! haha anyways here is what ya gotta change..

open..
garage_view_garage_business.html
garage_view_shop_business.html
garage_view_insurance_business.html
.....
Thanks thejdm. Nice spot and fix. :)

See sometimes you guys are better than me, I can do all the hard coding and major tasks, but design and css is not my strong suit. If we put all the little fixes together than one by one you work out we get there.

Fixed issue with search producing error page today, the toggle image being cut off, currency in most spent. All small stuff but when you start to add them all up its the final polish we need.

Some anyone else if fixes let me know. I am trying to read the thread .. but am lazy too ;)

User avatar
poyntesm
Registered User
Posts: 1671
Joined: Tue Jan 18, 2005 11:19 am
Location: Dublin, Ireland
Contact:

Re: [DEV] phpBB Garage 2.0

Post by poyntesm » Thu Oct 07, 2010 7:21 pm

vectra-mods/steve ... would you like to have write access to SVN ?? I am work than happy for you to work on the html/css stuff direct. If you make any huge change I hate we can revert it ... but since i want this to be team/group effort I have no problem to open up write access in SVN for you. Let me know :)

User avatar
Blue Blood
Registered User
Posts: 763
Joined: Sat Apr 11, 2009 7:09 am
Location: U§A
Name: Blue Blood
Contact:

Re: [DEV] phpBB Garage 2.0

Post by Blue Blood » Fri Oct 08, 2010 2:55 am

poyntesm wrote: No this is correct but not complete. That array is the list of required fields but its not correct its missing shop_id and installer_id. Correct line is

Code: Select all

        $params = array('category_id', 'manufacturer_id', 'product_id', 'shop_id', 'installer_id');
However that is against latest SVN, I can not promise as my memory is not great when the style/html side matched those input names... but would have thought its been like that for a while.
Yes this is working now!!

User avatar
Blue Blood
Registered User
Posts: 763
Joined: Sat Apr 11, 2009 7:09 am
Location: U§A
Name: Blue Blood
Contact:

Re: [DEV] phpBB Garage 2.0

Post by Blue Blood » Fri Oct 08, 2010 3:39 am

Here are few bugs I have found in the past few days..
Will do more testing..
If have solution please post thanks
===========================================================================================

In the MCP under Comments Awaiting Approval

The Approve , Edit & Disapprove function don't work properly
When you select the comment and select Approve or Disapprove you will get this message
Although the selected action will work you just have to go back and refresh the page

Code: Select all

General Error
Module not accessible
The Edit function don't work at all.
It just redirects to same page.

==========================================================================================

Missing Language variables For Admin log

Code: Select all

ACP_GARAGE_RATING_SETTINGS 	
ACP_GARAGE_GUESTBOOK_SETTINGS 	
ACP_GARAGE_PRODUCT_SETTINGS 	
ACP_GARAGE_SERVICE_SETTINGS 	
ACP_GARAGE_BLOG_SETTINGS 	
ACP_GARAGE_VERSION_CHECK 	
ACP_GARAGE_BUSINESS 	
ACP_GARAGE_CATEGORIES 	
ACP_GARAGE_MODELS 	
ACP_GARAGE_PRODUCTS 	
ACP_GARAGE_QUOTAS 	
ACP_GARAGE_TOOLS 	
ACP_GARAGE_TRACK 	
MCP_GARAGE_UNAPPROVED_VEHICLES 	
MCP_GARAGE_UNAPPROVED_MAKES 	
MCP_GARAGE_UNAPPROVED_MODELS
ACP_GARAGE_SETTINGS 	
ACP_GARAGE_MANAGEMENT 	
MCP_GARAGE 	
UCP_GARAGE 	
ACP_GARAGE_GENERAL_SETTINGS 	
ACP_GARAGE_MENU_SETTINGS 	
ACP_GARAGE_INDEX_SETTINGS 	
ACP_GARAGE_IMAGES_SETTINGS 	
ACP_GARAGE_QUARTERMILE_SETTINGS 	
ACP_GARAGE_DYNORUN_SETTINGS 	
ACP_GARAGE_TRACK_SETTINGS 	
ACP_GARAGE_INSURANCE_SETTINGS 	
ACP_GARAGE_BUSINESS_SETTINGS
MCP_GARAGE_UNAPPROVED_BUSINESS 	
MCP_GARAGE_UNAPPROVED_QUARTERMILES 	
MCP_GARAGE_UNAPPROVED_DYNORUNS 	
MCP_GARAGE_UNAPPROVED_GUESTBOOK_COMMENTS 	
MCP_GARAGE_UNAPPROVED_LAPS 	
MCP_GARAGE_UNAPPROVED_TRACKS 	
MCP_GARAGE_UNAPPROVED_PRODUCTS 	
UCP_GARAGE_OPTIONS 	
UCP_GARAGE_NOTIFY
===========================================================================================

When you have more than 30 comments in your guestbook, the newest ones no longer show.

In the ACP under the Garage General Settings
Vehicles Per Page:
The number of vehicles that is shown on a page.

Default is 30

The comments are tied into this setting.

Not sure if this is a bug, I guess it could be configured differently.

===========================================================================================

When you edit Guestbook comments you get this error on submit.

Code: Select all

SQL ERROR [ mysqli ]

Column 'bbcode_options' cannot be null [1048]

SQL

UPDATE phpbb_garage_guestbooks SET post = 'TEST TEST TEST', bbcode_uid = '', bbcode_bitfield = '', bbcode_options = NULL WHERE id = 45

BACKTRACE

FILE: includes/db/mysqli.php
LINE: 163
CALL: dbal->sql_error()

FILE: includes/mods/class_garage_guestbook.php
LINE: 131
CALL: dbal_mysqli->sql_query()

FILE: garage_guestbook.php
LINE: 333
CALL: garage_guestbook->update_vehicle_comment()
===========================================================================================

In the ACP under Index page settings

Columns On Index:
Number of columns used on index page. ---> 1-4

Enable User Collumn Index: <--- Collumn Misspelled
Allow users override board default. ---> YES & NO
This option does not work. it will always show only one column.

Even went set to yes and the user changes to 2, 3 or 4 columns.
Still don't work

===========================================================================================

Under MCP ---> Vehicles awaiting approval ---> select vehicle and disapprove
I get this error

Code: Select all

Fatal error: Call to a member function get_modifications_by_vehicle() on a non-object in C:\xampp\htdocs\garage\includes\mods\class_garage_vehicle.php on line 1114
===========================================================================================

Under MCP ---> Products awaiting approval ---> select product and disapprove
Delete product page Title text is white
also when select Delete all modifications and submit
I get this error

Code: Select all

Fatal error: Call to a member function get_modification_gallery() on a non-object in C:\xampp\htdocs\garage\includes\mods\class_garage_modification.php on line 106
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Also if you select more then one Product and click edit the
Missing Language variable
TOO_MANY_SELECTED

===========================================================================================

IN ACP Version Check Page Missing Language variables
{ VERSION_CHECK }

{ CURRENT_VERSION }

{ LATEST_VERSION }


===========================================================================================

Under MCP ---> ¼ miles awaiting approval ---> select ¼ miles and disapprove
I get this error

Code: Select all

Fatal error: Call to a member function get_quartermile_gallery() on a non-object in C:\xampp\htdocs\garage\includes\mods\class_garage_quartermile.php on line 99
===========================================================================================

MCP ---> Comments awaiting approval
Do not make a selection and submit "approve" or "disapprove" Don't know about "Edit" because it just redirect to same page
Missing Language variable
NO_COMMENT_SELECTED

===========================================================================================

Under MCP ---> Laps awaiting approval ---> select Lap and disapprove
I get this error

Code: Select all

Fatal error: Call to a member function get_lap_gallery() on a non-object in C:\xampp\htdocs\garage\includes\mods\class_garage_track.php on line 142

===========================================================================================

Under MCP ---> Tracks awaiting approval ---> selectTrack and EDIT
Make your edits and submit
I Get this even though the rquired field is filled

Code: Select all

Garage Error Occured
Required Field Missing
A Field Marked As [Required] Was Not Filled In
Please Use Your Browsers Back Button And Fill It In
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Under MCP ---> Tracks awaiting approval ---> select Track and disapprove

Delete product page Title text is white

also when select Delete all modifications and submit
Also same error when Move laps to
I get this error

Code: Select all

SQL ERROR [ mysqli ]

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 [1064]

SQL

SELECT t.* FROM (phpbb_garage_tracks t) WHERE t.id =

BACKTRACE

FILE: includes/db/mysqli.php
LINE: 163
CALL: dbal->sql_error()

FILE: includes/mods/class_garage_track.php
LINE: 306
CALL: dbal_mysqli->sql_query()

FILE: includes/mods/class_garage_track.php
LINE: 630
CALL: garage_track->get_track()

FILE: includes/mcp/mcp_garage.php
LINE: 1233
CALL: garage_track->delete_track()

FILE: includes/functions_module.php
LINE: 507
CALL: mcp_garage->main()

FILE: mcp.php
LINE: 244
CALL: p_master->load_active()
===========================================================================================

User avatar
poyntesm
Registered User
Posts: 1671
Joined: Tue Jan 18, 2005 11:19 am
Location: Dublin, Ireland
Contact:

Re: [DEV] phpBB Garage 2.0

Post by poyntesm » Fri Oct 08, 2010 12:05 pm

Blue Blood wrote:Here are few bugs I have found in the past few days..
Will do more testing..
If have solution please post thanks
===========================================================================================

In the MCP under Comments Awaiting Approval

The Approve , Edit & Disapprove function don't work properly
When you select the comment and select Approve or Disapprove you will get this message
Although the selected action will work you just have to go back and refresh the page

Code: Select all

General Error
Module not accessible
The Edit function don't work at all.
It just redirects to same page.
Approve/Disapprove fixed. Edit needs effort to build page yet.
Blue Blood wrote: ==========================================================================================

Missing Language variables For Admin log

Code: Select all

ACP_GARAGE_RATING_SETTINGS 	
ACP_GARAGE_GUESTBOOK_SETTINGS 	
ACP_GARAGE_PRODUCT_SETTINGS 	
ACP_GARAGE_SERVICE_SETTINGS 	
ACP_GARAGE_BLOG_SETTINGS 	
ACP_GARAGE_VERSION_CHECK 	
ACP_GARAGE_BUSINESS 	
ACP_GARAGE_CATEGORIES 	
ACP_GARAGE_MODELS 	
ACP_GARAGE_PRODUCTS 	
ACP_GARAGE_QUOTAS 	
ACP_GARAGE_TOOLS 	
ACP_GARAGE_TRACK 	
MCP_GARAGE_UNAPPROVED_VEHICLES 	
MCP_GARAGE_UNAPPROVED_MAKES 	
MCP_GARAGE_UNAPPROVED_MODELS
ACP_GARAGE_SETTINGS 	
ACP_GARAGE_MANAGEMENT 	
MCP_GARAGE 	
UCP_GARAGE 	
ACP_GARAGE_GENERAL_SETTINGS 	
ACP_GARAGE_MENU_SETTINGS 	
ACP_GARAGE_INDEX_SETTINGS 	
ACP_GARAGE_IMAGES_SETTINGS 	
ACP_GARAGE_QUARTERMILE_SETTINGS 	
ACP_GARAGE_DYNORUN_SETTINGS 	
ACP_GARAGE_TRACK_SETTINGS 	
ACP_GARAGE_INSURANCE_SETTINGS 	
ACP_GARAGE_BUSINESS_SETTINGS
MCP_GARAGE_UNAPPROVED_BUSINESS 	
MCP_GARAGE_UNAPPROVED_QUARTERMILES 	
MCP_GARAGE_UNAPPROVED_DYNORUNS 	
MCP_GARAGE_UNAPPROVED_GUESTBOOK_COMMENTS 	
MCP_GARAGE_UNAPPROVED_LAPS 	
MCP_GARAGE_UNAPPROVED_TRACKS 	
MCP_GARAGE_UNAPPROVED_PRODUCTS 	
UCP_GARAGE_OPTIONS 	
UCP_GARAGE_NOTIFY
I believe and need to check these are the value for the module name as stored in modules in column module_langname. There are indeed language entries for these so I think its just when its logged they use the value and not language convert it. Not critical but I will try check
Blue Blood wrote: ===========================================================================================

When you have more than 30 comments in your guestbook, the newest ones no longer show.

In the ACP under the Garage General Settings
Vehicles Per Page:
The number of vehicles that is shown on a page.

Default is 30

The comments are tied into this setting.

Not sure if this is a bug, I guess it could be configured differently.
I will not add a config variable for it now to be honest and probably switch to to use topics value from forum. However the displaying needs to be fixed.
Blue Blood wrote: ===========================================================================================

When you edit Guestbook comments you get this error on submit.

Code: Select all

SQL ERROR [ mysqli ]

Column 'bbcode_options' cannot be null [1048]

SQL

UPDATE phpbb_garage_guestbooks SET post = 'TEST TEST TEST', bbcode_uid = '', bbcode_bitfield = '', bbcode_options = NULL WHERE id = 45

BACKTRACE

FILE: includes/db/mysqli.php
LINE: 163
CALL: dbal->sql_error()

FILE: includes/mods/class_garage_guestbook.php
LINE: 131
CALL: dbal_mysqli->sql_query()

FILE: garage_guestbook.php
LINE: 333
CALL: garage_guestbook->update_vehicle_comment()
Bug fixed but guestbook overall not finished so fixing that brings to next error .. but on my overall list
Blue Blood wrote: ===========================================================================================

In the ACP under Index page settings

Columns On Index:
Number of columns used on index page. ---> 1-4

Enable User Collumn Index: <--- Collumn Misspelled
Allow users override board default. ---> YES & NO
This option does not work. it will always show only one column.

Even went set to yes and the user changes to 2, 3 or 4 columns.
Still don't work
Spelling fixed. Option works only in subSilver at the moment.
Blue Blood wrote: ===========================================================================================

Under MCP ---> Vehicles awaiting approval ---> select vehicle and disapprove
I get this error

Code: Select all

Fatal error: Call to a member function get_modifications_by_vehicle() on a non-object in C:\xampp\htdocs\garage\includes\mods\class_garage_vehicle.php on line 1114
Fixed
Blue Blood wrote: ===========================================================================================

Under MCP ---> Products awaiting approval ---> select product and disapprove
Delete product page Title text is white
also when select Delete all modifications and submit
I get this error

Code: Select all

Fatal error: Call to a member function get_modification_gallery() on a non-object in C:\xampp\htdocs\garage\includes\mods\class_garage_modification.php on line 106
Fixed
Blue Blood wrote: +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Also if you select more then one Product and click edit the
Missing Language variable
TOO_MANY_SELECTED
Fixed
Blue Blood wrote: ===========================================================================================

IN ACP Version Check Page Missing Language variables
{ VERSION_CHECK }

{ CURRENT_VERSION }

{ LATEST_VERSION }
Blue Blood wrote:
===========================================================================================

Under MCP ---> ¼ miles awaiting approval ---> select ¼ miles and disapprove
I get this error

Code: Select all

Fatal error: Call to a member function get_quartermile_gallery() on a non-object in C:\xampp\htdocs\garage\includes\mods\class_garage_quartermile.php on line 99
Fixed.
Blue Blood wrote: ===========================================================================================

MCP ---> Comments awaiting approval
Do not make a selection and submit "approve" or "disapprove" Don't know about "Edit" because it just redirect to same page
Missing Language variable
NO_COMMENT_SELECTED
Fixed
Blue Blood wrote: ===========================================================================================

Under MCP ---> Laps awaiting approval ---> select Lap and disapprove
I get this error

Code: Select all

Fatal error: Call to a member function get_lap_gallery() on a non-object in C:\xampp\htdocs\garage\includes\mods\class_garage_track.php on line 142
Fixed.
Blue Blood wrote: ===========================================================================================

Under MCP ---> Tracks awaiting approval ---> selectTrack and EDIT
Make your edits and submit
I Get this even though the rquired field is filled

Code: Select all

Garage Error Occured
Required Field Missing
A Field Marked As [Required] Was Not Filled In
Please Use Your Browsers Back Button And Fill It In
Fixed
Blue Blood wrote: +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Under MCP ---> Tracks awaiting approval ---> select Track and disapprove

Delete product page Title text is white

also when select Delete all modifications and submit
Also same error when Move laps to
I get this error

Code: Select all

SQL ERROR [ mysqli ]

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 [1064]

SQL

SELECT t.* FROM (phpbb_garage_tracks t) WHERE t.id =

BACKTRACE

FILE: includes/db/mysqli.php
LINE: 163
CALL: dbal->sql_error()

FILE: includes/mods/class_garage_track.php
LINE: 306
CALL: dbal_mysqli->sql_query()

FILE: includes/mods/class_garage_track.php
LINE: 630
CALL: garage_track->get_track()

FILE: includes/mcp/mcp_garage.php
LINE: 1233
CALL: garage_track->delete_track()

FILE: includes/functions_module.php
LINE: 507
CALL: mcp_garage->main()

FILE: mcp.php
LINE: 244
CALL: p_master->load_active()
===========================================================================================
White text not solved. But error is.

Please do not expect me to show where/how its fixed :) If you are interested monitor the SVN repo and watch for commits. I do not commit after every single small change. So you might need to wait a day ;)

Locked

Return to “[3.0.x] Abandoned MODs”