+1.Kamahl19 wrote:I like MODs which looks more like plugins / addons and thats why I am looking forward to 3.1
Emphasis to the above quote added by me, was not part of the original statement by Erik. It does, however, highlight one of the possible issues with a plug-in system. I think that the possibility exists that plug-ins are going to trade one problem (editing core code) with another (too many MODs performing similar functions in separate coding streams), but that's another topic. In my opinion, nothing is as efficient as a MOD that is fully integrated into the core, and that may mean more core edits.Erik Frèrejean wrote:For one of my boards I've rewritten every single MOD we've installed to make them as un intrusive as possible which only resulted in way worse performance and quite often hard to trace bugs as the stack trace gets cluttered with "magic" calls.
The difference between editing the code and events in 3.1 is almost completely un-noticable. Erik was referring to the way the current olympus hooks system is which, because of small amount of hooks makes a small dent upon performance.drathbun wrote:Emphasis to the above quote added by me, was not part of the original statement by Erik. It does, however, highlight one of the possible issues with a plug-in system. I think that the possibility exists that plug-ins are going to trade one problem (editing core code) with another (too many MODs performing similar functions in separate coding streams), but that's another topic. In my opinion, nothing is as efficient as a MOD that is fully integrated into the core, and that may mean more core edits.Erik Frèrejean wrote:For one of my boards I've rewritten every single MOD we've installed to make them as un intrusive as possible which only resulted in way worse performance and quite often hard to trace bugs as the stack trace gets cluttered with "magic" calls.
But I digress.
The number of edits was the last thing I looked at when selecting MODs to install. The number of edits is probably a fairly good indication of how complex the MOD is, but thinking back to the phpBB2 days to add a new field to a profile required edits to way too many files. That's one of the reasons that custom profile fields was such a welcome addition in phpBB3.
Yes I was talking about the 3.0 hook system, however the 3.1 event system will suffer from the exact same thing. IMO people are to easily disregarding the potential downsides of a plugin system over core edits, however as the community wants plugins it is only sensible to introduce a decent plugin system. I personally however will always look twice whether a given event wouldn't be better off as a core edit.Unknown Bliss wrote:The difference between editing the code and events in 3.1 is almost completely un-noticable. Erik was referring to the way the current olympus hooks system is which, because of small amount of hooks makes a small dent upon performance.drathbun wrote:Emphasis to the above quote added by me, was not part of the original statement by Erik. It does, however, highlight one of the possible issues with a plug-in system. I think that the possibility exists that plug-ins are going to trade one problem (editing core code) with another (too many MODs performing similar functions in separate coding streams), but that's another topic. In my opinion, nothing is as efficient as a MOD that is fully integrated into the core, and that may mean more core edits.Erik Frèrejean wrote:For one of my boards I've rewritten every single MOD we've installed to make them as un intrusive as possible which only resulted in way worse performance and quite often hard to trace bugs as the stack trace gets cluttered with "magic" calls.
But I digress.
The number of edits was the last thing I looked at when selecting MODs to install. The number of edits is probably a fairly good indication of how complex the MOD is, but thinking back to the phpBB2 days to add a new field to a profile required edits to way too many files. That's one of the reasons that custom profile fields was such a welcome addition in phpBB3.