[ABD] AOS Notifications

Any abandoned MODs will be moved to this forum.

WARNING: MODs in this forum are not currently being supported or maintained by the original MOD author. Proceed at your own risk.
Forum rules
IMPORTANT: MOD Development Forum rules

WARNING: MODs in this forum are not currently being supported nor updated by the original MOD author. Proceed at your own risk.
User avatar
4_seven
I've Been Banned!
Posts: 5155
Joined: Wed Apr 30, 2008 1:41 am

Re: [DEV] AOS Notifications

Post by 4_seven »

spiritdead wrote:FIXED in the forum http://phpbb-es.com
Can you link to the solution post. This can be helpfull for others with the same error.
Current Mods | Mod Base | php(BB) programming | No help via PM
spiritdead
Registered User
Posts: 6
Joined: Wed May 02, 2012 3:26 am

Re: [DEV] AOS Notifications

Post by spiritdead »

4_seven wrote:
spiritdead wrote:FIXED in the forum http://phpbb-es.com
Can you link to the solution post. This can be helpfull for others with the same error.
http://www.phpbb-es.com/foro/soporte-ph ... 35814.html

:) but i have a little bug and is in the limit, well see the last comment
spiritdead
Registered User
Posts: 6
Joined: Wed May 02, 2012 3:26 am

Re: [DEV] AOS Notifications

Post by spiritdead »

spiritdead wrote:
4_seven wrote:
spiritdead wrote:FIXED in the forum http://phpbb-es.com
Can you link to the solution post. This can be helpfull for others with the same error.
http://www.phpbb-es.com/foro/soporte-ph ... 35814.html

:) but i have a little bug and is in the limit, well see the last comment
well the little bug respect of the limits load, my error

IS THE BIG BUG

if the mod not work the limits, this mod can load 3000 querys or more :S
spiritdead
Registered User
Posts: 6
Joined: Wed May 02, 2012 3:26 am

Re: [DEV] AOS Notifications

Post by spiritdead »

well the big problem is

the mod social network and aos notifications (if you have the 2 mods activated )

generate errors,

specific in the files hook_aos_notification.php and hook_socialnet.php :S
User avatar
Histomil
Registered User
Posts: 56
Joined: Tue Oct 25, 2011 3:34 am
Location: Amsterdam
Name: Henk

Re: [DEV] AOS Notifications

Post by Histomil »

It is a nice mod , congrats Alorse.
Test Installed it on my board , like the info it gives but it doesnt look too good in how it is placed on the page by default ..so had it disabled for now .. (the functioning is fine btw ) .
I have some mods already right below the header , and the notifications mod is placed above them by default so the page starts now with a large notification block wich shouldnt be the first block to see really ..its additional info meant for less 'hot' visual places on a page and i think it should not be the most important visual block a index or portalpage should offer to members ..

My board also runs portal 3 (latest version with the custom blocks)
In the portal the notificationsblock shows auto on the wide top custom block on the top above the welcome block.
Also here 'Notifications' should not be displayed on the most prominent visual place on the page ..

My question is .. can it be set so that in the forumindex its not shown, or is only shown in a block somewhere above the footer ? For me it would be ideal when its not shown in the index.php at all but only in a lower center custom block in the portal3 ..Maybe you want to consider this mod as a plugin for portal3?
I think it would be massively used if available as plugin.. ..

kind regards:
Henk
vipaka
Registered User
Posts: 493
Joined: Sun Aug 28, 2011 7:25 pm

Re: [DEV] AOS Notifications

Post by vipaka »

This mod was working 100% up until I upgraded to 3.0.11. Now there is a permission error for accessing the notifications page (can be remedied by removing the following line from the hook codes)

Code: Select all

/**
		 *  fix for bug: http://tracker.phpbb.com/browse/PHPBB3-9842
		 */
		if (!defined('IN_AOS_N'))
		{
			define('IN_AOS_N', true);
		}
		else
		{
			return;
		}
but even with the permissions problem fixed, it then loops incorrectly. Topics and users following topics are shown multiple times, usually 3 (no attachments in any of the posts).
Curious about my work? See it for yourself.
Image
User avatar
Jessica
Former Team Member
Posts: 4342
Joined: Sun Jul 18, 2010 2:53 pm
Location: Pennsylvania, USA
Name: Jessica

Re: [DEV] AOS Notifications

Post by Jessica »

vipaka wrote:This mod was working 100% up until I upgraded to 3.0.11. Now there is a permission error for accessing the notifications page (can be remedied by removing the following line from the hook codes)

Code: Select all

/**
		 *  fix for bug: http://tracker.phpbb.com/browse/PHPBB3-9842
		 */
		if (!defined('IN_AOS_N'))
		{
			define('IN_AOS_N', true);
		}
		else
		{
			return;
		}
but even with the permissions problem fixed, it then loops incorrectly. Topics and users following topics are shown multiple times, usually 3 (no attachments in any of the posts).
how did you get the permissions error? I want to see if I have it. I upgraded to 3.0.11 before installing this mod. also right now the topics are shown only once for me, but I'm going to see if I get the same as you (showing multiple times)
Pro-choice, Atheist, Pro-LGBT rights
Everybody is a genius. But if you judge a fish by its ability to climb a tree, it will live its whole life believing that it is stupid. - Albert Einstein
vipaka
Registered User
Posts: 493
Joined: Sun Aug 28, 2011 7:25 pm

Re: [DEV] AOS Notifications

Post by vipaka »

The permissions error shows up on the aos_notifications.php page. It says "You are not authorized to access this page" because of the lines listed above.

After wasting an hour fighting with this mod, I found this line at the bottom of the hooks file

Code: Select all

$phpbb_hook->register(array('template', 'display'), 'aos_notifications');
is calling the hook multiple times on the actual aos_notifications page (not on any other page) and causing the duplicate entries when the permission error lines are removed. However, removing this line or changing the conditional renders the mod inert for the rest of the site (notifications will not show up, UCP controls say that the mod is disabled and so forth). So...have to remove the code in the post above to access the page, and then the line above in this post to remove the duplicates...and then the mod is completely broken. The mod author is going to have help me out on this one because I'm just going in circles here.

Why does this mod even need a hook? It seems to just make it unnecessarily complicated.

Edit: My circles paid off. I figured out the error. It was my own fault for a mistake in the 3.0.11 update.
Curious about my work? See it for yourself.
Image
Peter77sx
Registered User
Posts: 3260
Joined: Wed Nov 09, 2005 2:51 pm

Re: [DEV] AOS Notifications

Post by Peter77sx »

Great idea with this. Just maybe a suggestion for members with nothing: show a text to say (for example) "You have no notifications yet" etc. so to prevent confusion on why there is a pop-up with nothing in it. :) other than that, good job. looking forward to further development of this MOD.
forumvisa4uk
Registered User
Posts: 41
Joined: Wed Sep 26, 2012 6:45 pm

Re: [DEV] AOS Notifications

Post by forumvisa4uk »

there is a problem about timing....

you can see that how it goes off in 5-10 seconds

www.forumvisa4uk.com
AbbeyG
Registered User
Posts: 88
Joined: Fri Feb 08, 2013 7:14 pm

Re: [DEV] AOS Notifications

Post by AbbeyG »

Hey!

I love this mod! but I am getting a small error when I install it.

Instead of this showing up in the Breadcrumbs bar, it appears near the footer :(

Here is a screenshot: http://s6.postimage.org/6cfsri6rl/fdas.png

Any ideas?
User avatar
Tigerman75
Registered User
Posts: 84
Joined: Wed Jan 25, 2012 6:52 am
Location: {postrow.U_DELETE}---->Italy
Name: Tiger

Re: [DEV] AOS Notifications

Post by Tigerman75 »

This is a very ,very good mod.

Thanks the Best Alorse. :P
The war to be continues.
User avatar
Jessica
Former Team Member
Posts: 4342
Joined: Sun Jul 18, 2010 2:53 pm
Location: Pennsylvania, USA
Name: Jessica

Re: [DEV] AOS Notifications

Post by Jessica »

AbbeyG wrote:Hey!

I love this mod! but I am getting a small error when I install it.

Instead of this showing up in the Breadcrumbs bar, it appears near the footer :(

Here is a screenshot: http://s6.postimage.org/6cfsri6rl/fdas.png

Any ideas?
Refresh styles, clear browser cache, refresh page by pressing Ctrl + F5
Pro-choice, Atheist, Pro-LGBT rights
Everybody is a genius. But if you judge a fish by its ability to climb a tree, it will live its whole life believing that it is stupid. - Albert Einstein
AbbeyG
Registered User
Posts: 88
Joined: Fri Feb 08, 2013 7:14 pm

Re: [DEV] AOS Notifications

Post by AbbeyG »

That worked! Thankyou!
vipaka
Registered User
Posts: 493
Joined: Sun Aug 28, 2011 7:25 pm

Re: [DEV] AOS Notifications

Post by vipaka »

Feature suggestion: allow topics to be marked read (and remove notification for it) without forcing users to actually visit every topic listed in their notifications.
Curious about my work? See it for yourself.
Image

Return to “[3.0.x] Abandoned MODs”