Hey Jessica. Thanks for picking up this mod!
Please correct me if I'm wrong, but from looking at the current code it seems like you still have open that exploit that allowed users to nominate others for any medal id, even if that medal has nominations disabled or even if that medal doesn't exist at all. Suggested fix looks like this:
FIND
Code: Select all
generate_text_for_storage($message, $uid, $bitfield, $m_flags, $allow_bbcode, $allow_urls, $allow_smilies);
ADD BEFORE
Code: Select all
if ($medals[$medal_id]['nominated'] == 0)
{
trigger_error(sprintf($user->lang['CANNOT_AWARD_UNNOMINATED'], append_sid('medals.php?m=nominate&u=' . $user_id)));
}
And add appropriate lang var (CANNOT_AWARD_UNNOMINATED in this example) in /language/../mods/info_medals_mod.php