Attached Images Resizer, Converter & File Size Reducer

Holger · Post by **Holger** » Wed Nov 19, 2014 3:47 pm

Walther wrote:
Holger wrote:No, the code is mine, because I bought it.
urm, are you sure, because it is not always so that you are also free to distribute it for example.

Of course I'll ask him!

][Moon][Shine][ · Post by **][Moon][Shine][** » Wed Nov 19, 2014 3:48 pm

Holger wrote:
Walther wrote:
Holger wrote:...
This is custom programmed and was rather expensiv
...
I see, that would be a problem then to share the code.
No, the code is mine, because I bought it.

Well, then it looks like we should convince you to release it.

It's totally understandable if that's not on your agenda (for now), as long as you can not benefit from such a v3.1.x extension yourself (I guess you are using more than just one custom mod preventing you from upgrading?). If it was me, I'd put it on github, as it's always a good idea to prevent others from having to reinvent the wheel. Too bad that you had to pay for it though.

DavidIQ is definitely on the right track with having his extension on github. That way if someone wants to fork and pull for added functionality, even better. I wish I had the knowledge to contribute and the time for it.

YouTube · Post by **DavidIQ** » Wed Nov 19, 2014 3:49 pm

Volksdevil wrote:+1 to the original idea, but I'd rather it was kept simple.

Attachments resized upon upload as per the original request, with maybe an option of watermarking all images. << That would be a superb enough addition for me

I think the whole swapping of external to internal will just complicate things for a potential dev (David?) But if not then...Why not I suppose.

I wouldn't do it in ReIMG 3.1 where the attachments thing would go in. Would probably leave it for ReIMG 3.2 (my versioning is currently at 3.0. Just happens to sort of coincide with phpBB's current version

)

Holger · Post by **Holger** » Wed Nov 19, 2014 3:51 pm

My major board is heavily modified and has heavy traffic. It will take several months to convert it to phpBB 3.1.
But if the coder released the snippet to me then David or someone else will be welcome to use it!

Volksdevil · Post by **Volksdevil** » Wed Nov 19, 2014 3:54 pm

DavidIQ wrote: I wouldn't do it in ReIMG 3.1 where the attachments thing would go in. Would probably leave it for ReIMG 3.2 (my versioning is currently at 3.0. Just happens to sort of coincide with phpBB's current version )

Ah, so this wouldn't be a standalone 'Attachment resize' extension David? It would be added to the ReImg Extension? Just that I already use https://github.com/VSEphpbb/lightbox

YouTube · Post by **DavidIQ** » Wed Nov 19, 2014 3:57 pm

Volksdevil wrote:Ah, so this wouldn't be a standalone 'Attachment resize' extension David? It would be added to the ReImg Extension?

Yes. I'm having to rewrite pretty much all of it so might as well just add some additional feature planning while I'm at it and extend it. It's obvious the original purpose of the MOD is short-reaching nowadays so might as well go with making it more feature full.

][Moon][Shine][ · Post by **][Moon][Shine][** » Wed Nov 19, 2014 3:59 pm

It's really great to see that much excitement for this extension request, WTG guys!

Volksdevil · Post by **Volksdevil** » Wed Nov 19, 2014 4:12 pm

Good stuff. I'm pleased to hear it, although it may cause some issues for me to use ReImg rather than Lightbox. Will have to consider options at the time.

Main issue being that I can currently easily add lightbox functionality to any image/link outside of the viewtopic pages, anywhere on my site (Custom old style 3.0.x pages, the official 'Pages' extension' etc) by adding a small bit of code:

<a href="/images/about.png" itemprop="image" [b][color=#FF0000]data-lightbox="post-gallery1" data-title="Test title"[/color][/b] style="height: auto; max-height: none; overflow: visible;">

<img src="/images/about_thumb.png" class="history-image" alt="Test alt" [b][color=#FF0000]onclick="viewableArea(this);"[/color][/b]></a>

Achievable?

YouTube · Post by **DavidIQ** » Wed Nov 19, 2014 4:17 pm

ReIMG comes with its own lightbox already though I'm considering replacing it. In any case the MOD version sort of works just like what you posted already although the application of the resizing properties is not always straightforward outside of the forum.

Volksdevil · Post by **Volksdevil** » Wed Nov 19, 2014 4:26 pm

Would it work if the above code had no image size (Width/height) properties, basically a thumb and the actual size of the image was already OK? Then the clicking of it lead to a larger <a target> version?

IIRC I had to do a workround for ReImg in 3.0.x to stop it automatically applying an image size set in the ACP.

Anyway, glad to see you working on this. Dare I mention Avatars?

**My CDB Contributions** · Post by **HiFiKabin** » Wed Nov 19, 2014 4:40 pm

][Moon][Shine][ wrote:
DavidIQ wrote:I'm currently working on the JavaScript for ReIMG so once I finish I'll take a look at adding some attached image server side resizing functionality unless someone else picks this up. What would be the desired features?
Sounds great!

Desired features:

Automatic down-sizing of image to configured resolution

If it's a PNG, conversion to JPG

Saving as JPG with configured JPG-quality setting

Option to remove EXIF data

And @Holger's one-click import function would be the added super-bonus
Did I forget something?

Just downsizing (both physical and file size) would suit me.
Configurable in the ACP.
Ignore images smaller than the ACP setting. (so that it doesn't overscale images)

Holger · Post by **Holger** » Wed Nov 19, 2014 5:54 pm

Holger wrote:
Walther wrote:
Holger wrote:No, the code is mine, because I bought it.
urm, are you sure, because it is not always so that you are also free to distribute it for example.
Of course I'll ask him!

I have talked to the coder and we came to the following conclusion:

The mod is developed under GPL and paid by me.
You have to add "Based on mod x by y" or similar to retain a copyright.
Other then that the code is free to use.

][Moon][Shine][ · Post by **][Moon][Shine][** » Wed Nov 19, 2014 7:12 pm

That's exceptional news, @Holger. I'm delighted by the idea where this all is heading.

Lumpy Burgertushie · Post by **Lumpy Burgertushie** » Wed Nov 19, 2014 7:14 pm

actually , if it is under GPL then all you have to do is credit the original copyright holder. It doesn't matter if it was paid for or not. you can then give it away or sell it to someone else if you wish as long as the above is done and you give the buyer the source code etc. they can then sell it or give it away or whatever.

just FYI

robert

Swanny · Post by **Swanny** » Tue Nov 25, 2014 1:22 am

DavidIQ wrote:I'm currently working on the JavaScript for ReIMG so once I finish I'll take a look at adding some attached image server side resizing functionality unless someone else picks this up. What would be the desired features?

THANK YOU!

All I really ask is that the original photo attachment that is uploaded be resized to a maximum dimension as set by admin after the upload is successfully complete.

So a user uploads their 5+ MB photo that is 4000 px wide, and the extension magically resizes it to a max of 1024 px wide or tall (as I configure in ACP). Of course it needs to keep the aspect ratio. At the same time, if someone uploads a 500px wide photo, the extension needs to recognize that and not “upsize” it.

I don’t care about watermarks, converting from one format to another, import, exif, etc. Resizing the original file size is all I need. Keep things simple for now is my advice.