OK. It seems that some language variables are (I wouldn't say hardcoded) loaded only from English language file. I'm trying to translate gallery_notification.php and the language strings (in notification settings) are not updated even if I upload the files on server. I can see translated strings only if I replace original English language file with my non English translation (so it mean that I use Czech language, but it read language strings from English language file). This is not everywhere, just in notification and link on phpBB header to Gallery (file info_acp_gallery.php)
in language file gallery_notification.php:
Code: Select all
'NOTIFICATION_PHPBBGALLERY_IMAGE_FOR_APPROVAL' => '%2$s uploaded images for approval in album <strong>%1$s</strong>',
I think this should be also singular (in case that user uploaded only one image). I didn't check it, but I guess it apply for these string too:
'NOTIFICATION_PHPBBGALLERY_IMAGE_APPROVED' => 'Images in album <strong>%1$s</strong> were approved',
'NOTIFICATION_PHPBBGALLERY_NEW_IMAGE' => 'New images were uploaded to album <strong>%1$s</strong>',
I think the following string:
'NOTIFICATION_TYPE_PHPBBGALLERY_NEW_COMMENT' => 'New comments',
should be more descriptive, because users will not know that it means comments in Gallery. I think it should be something like:
'NOTIFICATION_TYPE_PHPBBGALLERY_NEW_COMMENT' => 'Someone send new comments to Gallery',
While speaking about notification - it would be nice if it is divided into categories. For example
Images waiting for approval
and
New image report
should be in "Moderation Notifications".