[RC] Hide BBcode

[Tekamei]

Do I need simple hide bbcode to run it on 3.1.4 or 3.1.6? Simple Hide bbcode is outdated so what I need to do?

[marcovo]

This extension can be installed on any phpBB 3.1 installation (from phpBB 3.1.4/6 onwards).
If furthermore the 3.1 installation is an upgrade from phpBB 3.0, this extension will replace the functionality of the simple hide bbcode mod.

[marcovo]

Version 1.0.1 has been released, primarily to fix an incompatibility with the ABBC extension. See the releases page on github for more information.

Translators note there is a new language string.

[marcovo]

Today I've made a lot of changes to establish a connection with ThanksForPosts in the near future. On GitHub the latest version can be found, which now contains an ACP page (translators note: more language strings have been added), and the bridge with ThanksForPosts has been implemented.

Which means; testers please test!

EDIT: A pull request has been made to the ThanksForPosts extension to make the connection fully compatible.

[LavIgor]

Translators note there is a new language string.

Russian.
https://github.com/marcovo/phpbb_hidebbcode/pull/11

[marcovo]

Thanks, the PR had been merged.

[marcovo]

As of the latest commit of today, all issues and requests that were made in this topic are implemented (or rejected). For an overview see this page:
https://github.com/marcovo/phpbb_hidebb ... is%3Aissue

Since version 1.0.1, these have been implemented

• ACP option for hiding attachments (still needs testing)
• Compatibility with Thanks for Posts (still needs testing)
• Also unhide texts on search page (still needs testing)

These have been rejected:

• Implement [hide=X] to hide posts for users that have fewer than X posts (does not fit within scope of this extension)
• Group rule on the bbcode (is provided by ABBC extension)

Today the language files also got an update. Since yesterday:

• info_acp_hidebbcode.php : HIDEBB_HIDE_ATTACH_EXPLAIN has been updated
• hide_bbcode.php : All strings except HIDEBB_HIDDEN_MESSAGE, HIDEBB_MESSAGE_UNHIDE, HIDEBB_MESSAGE_HIDDEN, HIDEBB_TFP_NO_DELETE have been updated

As all features have now been implemented I will now feature-freeze this extension until it will be released under version number 1.0.2 . Until then, I hope some of you want to test the extension to make sure there will be no bugs in the final release .

[FomenkoAndrey]

thank U for your work!
i tested.
everything works fine, except thanks:
1 - I use thanks with the Ajax-addon-for Thank by Alg, so I have to reload the page, or the content is still hidden.
2 - I can remove thanks after the message was unhide and looked hidden content.

[marcovo]

Thank you for testing!
1) I see. I didn't know about it so it indeed isn't supported yet. I will look whether I can add support for it in the future, but then also the TFP-addon extension should implement an new event just as the ThanksForPosts extension. However, this would be after 1.0.2, I now want to focus on the currently added features.

2) Ah indeed, it depends on an event that is not yet implemented by the ThanksForPosts extension. I've made a pull request for it. If you want to test it you should add the event yourself. For testing purposes, the edits in this commit will be sufficient to test the functionality. (The other, more complicated, commit was made to comply to coding guidelines.)


(Do note that it is possible to disable deleting of thanks board-wide, in the ACP for ThanksForPosts. The functionality of preventing the removal of thanks by this extension is just an extra for those who don't want to disable it board-wide.)

[marcovo]

Regarding ThanksForPosts, the pull request has just been merged so the latest master version of TFP on github will work be compatible with the latest master version of the [hide]-code extension.

[FomenkoAndrey]

1 - I use thanks with the Ajax-addon-for Thank by Alg, so I have to reload the page, or the content is still hidden.

I wrote to the author of the addon for Thanks, she asked to do PR and she joined it.
https://github.com/alg5/AddonForThanksForPosts

[marcovo]

@FomenkoAndrey: what kind of PR and what will be joined? Is that something you'll be doing?

Further; I've created a new branch that's aimed at adapting the extension to phpBB 3.2. The version for phpBB 3.2 will be released under version number 2.0.*, as it will not be backwards compatible.

[Miri4ever]

Fixed German translations for new Version:

Code: Select all

$lang = array_merge($lang, array(
	'HIDEBB_HIDDEN_MESSAGE'   =>   'Versteckte Nachricht',
	'HIDEBB_MESSAGE_UNHIDE'   =>   'Versteckt: Aus',
	'HIDEBB_MESSAGE_HIDDEN'   =>   'Versteckt: An',
	'HIDEBB_TFP_NO_DELETE'	  =>   'Löschen der Bedankung is deaktiviert, da eine Versteckte Nachricht [hide]-BBCode im Beitrag existiert.',

	'HIDEBB_HIDE_HELPLINE_REPLY'			=> 'Verstecke vor Leuten welche im Beitrag nicht geantwortet haben: [hide]text[/hide]',
	'HIDEBB_HIDE_HELPLINE_THANK'			=> 'Verstecke vor Leuten welche im Beitrag sich nicht bedankt haben: [hide]text[/hide]',
	'HIDEBB_HIDE_HELPLINE_REPLY_THANK'		=> 'Verstecke vor Leuten welche im Beitrag nicht geantwortet oder sich nicht bedankt haben: [hide]text[/hide]',

	'HIDEBB_MESSAGE_HIDDEN_DESCRIPTION_REPLY'			=> 'Sie müssen antworten damit Sie die Versteckte Nachricht lesen können',
	'HIDEBB_MESSAGE_HIDDEN_DESCRIPTION_THANK'			=> 'Sie müssen sich bedanken damit Sie die Versteckte Nachricht lesen können',
	'HIDEBB_MESSAGE_HIDDEN_DESCRIPTION_REPLY_THANK'		=> 'Sie müssen antworten oder sich bedanken damit Sie die Versteckte Nachricht lesen können.',

	'HIDEBB_MESSAGE_HIDDEN_ATTACH'				=> 'Dieser Beitrag enthält einen Versteckten Dateianhang',
	'HIDEBB_MESSAGE_HIDDEN_ATTACH_REPLY'		=> 'Um den Dateianhang zu sehen, müssen Sie eine Antwort verfassen.',
	'HIDEBB_MESSAGE_HIDDEN_ATTACH_THANK'		=> 'Um den Dateianhang zu sehen, müssen Sie sich bedanken.',
	'HIDEBB_MESSAGE_HIDDEN_ATTACH_REPLY_THANK'	=> 'Um den Dateianhang zu sehen, müssen Sie eine Antwort verfassen oder sich bedanken.',
));

Code: Select all

$lang = array_merge($lang, array(
	'ACP_HIDEBBCODE_CAT'			=>	'[hide] BBCode',
	'ACP_HIDEBBCODE_SETTINGS'		=>	'Allgemeine Einstellungen',

	'HIDEBB_SETTINGS'				=>	'[hide] BBCode Allgemeine Einstellungen',
	'HIDEBB_SETTINGS_EXPLAIN'		=>	'Hier können Sie das Verhalten von [hide] BBCode festlegen.',

	'HIDEBB_REPLY_ENABLE'			=>	'Der [hide] Befehl wird nicht versteckt wenn ein Benutzer auf den Beitrag antwortet.',
	'HIDEBB_REPLY_ENABLE_EXPLAIN'	=>	'Dies erlaubt den Benutzern den Inhalt von [hide] BBCode durch antworten im Beitrag zu sehen.',
	'HIDEBB_TFP_ENABLE'				=>	'Der [hide] Befehl wird nicht versteckt wenn ein Benutzer sich für Beitrag bedankt.',
	'HIDEBB_TFP_ENABLE_EXPLAIN'		=>	'Dies erlaubt den Benutzern den Inhalt von [hide] BBCode durch bedanken im Beitrag zu sehen. Wenn sich ein Benutzer für einen Beitrag bedankt hat, welcher [hide] BBCode enthält, so kann er diese Bedankung nicht mehr löschen.<br />Diese Funktion beeinflußt nur die ThanksForPosts Erweiterung wenn diese installiert ist.',
	'HIDEBB_HIDE_ATTACH'			=>	'Auch Dateianhänge verstecken',
	'HIDEBB_HIDE_ATTACH_EXPLAIN'	=>	'Versteckt Dateianhänge in Beiträgen wenn [hide] BBCode aktiv ist. Inline Dateianhänge sind versteckt wenn sie innerhalb von [hide] stehen, ansonsten werden sie angezeigt. Andere Dateianhänge werden versteckt wenn [hide] bbcode im Beitrag aktiv ist.',

));

[FomenkoAndrey]

marcovo, I detected a problem.

some 1-page topics, when adding a post through a quick replay by Tatyana, are reloaded the page, although Ajax enabled.

for example here http://motobratva.com/viewtopic.php?f=73&t=5255

the problem is only in chrome, adding message in firefox occur without reloading the page.
Console error is nothing.

I found that the problem disappears if I disable the extension [hide] BBcode, although neither in the message of nor the topic no tag HIDE.

UPD:
the problem in this file: quick_reply.js

Code: Select all

$(document).ready(function (e) {
   // If we are on viewtopic and parts of posts are hidden, we'll need to refresh the page if a post is submitted through AJAX (QuickReply)
   $('#qr_postform').on('ajax_submit_success', function (e) {
      location.reload(true);
   });
});

If i delete this code - everything is working correctly.
that is not the correct operation of the script, because the topic have no one post with bbcode hide.

[Sepp71]

Sorry for this stupid question, but:
Where do I have to put the files to get it to run?
phpbb/ext/phpbb_hidebbcode-1.0.1 looks strange and doesn't work. phpbb/ext/phpbb_hidebbcode-1.0.1/phpbb_hidebbcode-1.0.1 either.

Copy and paste like a mod for 3.0?
Anything to do in the ACP?

Maybe I didn't get through the history of changes in the first posting.
I am interested in this extension very much, my users love the HIDE-mod and this is what keeps me off from updating to 3.1. (But my question refers to a 3.1 testing version thats running on my local xamp!)
Thank you!

Sepp

Edit 28.09.2015, 8:00:
Finally got it myself: The files go to ext/marcovo/hideBBcode (case sensitive!).